Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Aug 2016 at 11:43 UTC
Updated:
23 Feb 2017 at 17:44 UTC
Jump to comment: Most recent
Comments
Comment #2
a.novolokov commentedComment #3
a.novolokov commentedComment #4
a.novolokov commentedComment #5
a.novolokov commentedComment #6
a.novolokov commentedComment #7
PA robot commentedFixed the git clone URL in the issue summary for non-maintainer users.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #8
a.novolokov commentedComment #9
a.novolokov commentedComment #10
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxanovolokov2781855git
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #11
a.novolokov commentedYes, I have corrected all errors.
Comment #12
icurk commentedYou didn't set git default branch.
I tested the module and all works as described.
Comment #13
a.novolokov commentedHi icurk,
The default branch has been changed to 8.x-1.x.
Comment #14
poojasharmaece commentedHi a.novolokov,
Module working fine. RTBC +1
I think you want to write "Please enter your Google API KEY" instead of "Press enter your Google API KEY".
If yes then please update accordingly. Its better if you provide Google API URL also as help text.
Comment #15
visabhishek commentedReview of the 8.x-1.x branch (commit 45ff916):
No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
1: Update readme file as https://www.drupal.org/node/2181737
2: Remove "package: Custom" from info.yml file.
3: Most of the Commit messages are "Fix code standart". Commit message should be proper.
4: Please check following point also.
https://www.drupal.org/node/2781941#comment-11891263
Otherwise all looks good for me.
Thanks for your contribution, a.novolokov!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #16
visabhishek commentedAssigning issue credits.