# Summary

Shorten urls in comment
This module uses Google Shorten URL API to shorten URLs in comments. When you save the comment , a long URL is automatically reduced in a short link . Also, the links becomes clickable.

# Project URL

https://www.drupal.org/sandbox/anovolokov/2781855

# Where is the code?

git clone --branch 8.x-1.x https://git.drupal.org/sandbox/a.novolokov/2781855.git

# Dependencies

Google API key

# Who's doing the project?

Aleksandr Novolokov

# What help do they need?

Unknown

# Is there any demo site?

# D8 roadmap

Unknown

# Background and reference information

Unknown

Manual reviews of other projects:

https://www.drupal.org/node/2825145#comment-11772570
https://www.drupal.org/node/2826819#comment-11781458

Comments

a.novolokov created an issue. See original summary.

a.novolokov’s picture

Assigned: Unassigned » a.novolokov
a.novolokov’s picture

Project: Shorten urls in comment » Drupal.org security advisory coverage applications
Component: Code » module
a.novolokov’s picture

Assigned: a.novolokov » Unassigned
a.novolokov’s picture

Title: Shorten urls in comment » [D8]Shorten urls in comment
a.novolokov’s picture

Title: [D8]Shorten urls in comment » [D8] Shorten urls in comment
PA robot’s picture

Issue summary: View changes

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

a.novolokov’s picture

Issue summary: View changes
a.novolokov’s picture

Issue summary: View changes
PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxanovolokov2781855git

I'm a robot and this is an automated message from Project Applications Scraper.

a.novolokov’s picture

Status: Needs work » Needs review

Yes, I have corrected all errors.

icurk’s picture

Status: Needs review » Reviewed & tested by the community

You didn't set git default branch.

I tested the module and all works as described.

a.novolokov’s picture

Hi icurk,
The default branch has been changed to 8.x-1.x.

poojasharmaece’s picture

Hi a.novolokov,

Module working fine. RTBC +1

I think you want to write "Please enter your Google API KEY" instead of "Press enter your Google API KEY".

public function buildForm(array $form, FormStateInterface $form_state) {
    $config = $this->config('shorten.settings');
    $form['google_api_key'] = array(
      '#type' => 'textfield',
      '#title' => $this->t('Press enter your Google API KEY'),
      '#default_value' => $config->get('google_api_key'),
    );

    return parent::buildForm($form, $form_state);
  }

If yes then please update accordingly. Its better if you provide Google API URL also as help text.

visabhishek’s picture

Status: Reviewed & tested by the community » Fixed

Review of the 8.x-1.x branch (commit 45ff916):

No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

1: Update readme file as https://www.drupal.org/node/2181737
2: Remove "package: Custom" from info.yml file.
3: Most of the Commit messages are "Fix code standart". Commit message should be proper.
4: Please check following point also.
https://www.drupal.org/node/2781941#comment-11891263

Otherwise all looks good for me.

Thanks for your contribution, a.novolokov!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

visabhishek’s picture

Assigning issue credits.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.