[D8] Appnotch Easy Web to App

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi AppNotch,
1) You do not practiced a Coding standards Drupal. In all files larger amount of markup errors.
All errors you can see on the page http://pareview.sh/pareview/httpsgitdrupalorgsandboxappnotch2825140git
Use Coder Sniffer to avoid this further.
2) File AppnotchEasyWebToAppSettingsForm.php line 15, incorrect variable name. Do not use "_" in the early. And should use lowerCamel naming.

Hello, AppNotch!

As you may have noticed on the Comment #2, in order to have your module approved, you will have to evaluate the project of 3 other fellow programmers.

Well, I am on the same boat. I have submitted a Drupal 8 theme and need 3 Drupal.org members to evaluate it. I would appreciate if you could test it and give me your opinion. I promise to do the same for your project. Que-pro-quo! :)

Following is the link to my Drupal 8 Theme:
https://www.drupal.org/node/2829866

By the way, I checked your git project with pareview.sh again and it still found errors:

https://pareview.sh/node/1270

You need to address them before your code can be approved.

Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting

./config/appnotch_easy_web_to_app.settings.yml: ASCII text, with CRLF line terminators
./appnotch_easy_web_to_app.links.menu.yml: ASCII text, with CRLF line terminators
./README.txt: ASCII text, with CRLF line terminators
README.txt
appnotch_easy_web_to_app.links.menu.yml
config/appnotch_easy_web_to_app.settings.yml

Coder Sniffer has found some issues with your code (please check the Drupal coding standards).

FILE: ...oot/repos/pareviewsh/pareview_temp/appnotch_easy_web_to_app.info.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
7 | ERROR | All dependencies must be prefixed with the project name, for
| | example "drupal:"
--------------------------------------------------------------------------

HI Appnotch,

Please find my reviews:

1. src/Form/AppnotchEasyWebToAppSettingsForm.php file "Short array syntax must be used to define arrays".

2. Instead of using hook_menu in appnotch_easy_web_to_app.module you can use routing to define routes. That you already did but, remove hook_menu code from .module file.

Please, see automated review of your project as its showing some errors.

https://pareview.sh/node/45

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.