[D7] Commerce Authnet ARB

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please Set the default branch

http://pareview.sh/pareview/httpsgitdrupalorgsandboxmanojapare2745895git

@rakesh.gectcr: did you add the review bonus tag by accident? There are no reviews in the issue summary.

Setting the default branch alone is not an application blocker, anything else that you found or should this be RTBC instead?

@klausi, That was accidental. :(

Hi Manoj

Please find the review comments

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

All looks good except the below changes
1)Missing t() in hook_menu commerce_authnet_arb.module line no 16
'title' => 'Authorize.Net ARB Settings',
Needs to be Changed to 'title' => 't(Authorize.Net ARB Settings)',
2) The usage of "100" in commerce_authnet_arb.module line number 401 is not documented. It would be better to have documented.

Hi manojapare,

please add module name after the git clone url so that it will get cloned easily to module name folder.

Git clone url changed.

Automated Review

Please check the errors in automatic reviews
http://pareview.sh/pareview/httpsgitdrupalorgsandboxmanojapare2745895git

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (*) 1. On 'admin/config/commerce-authnet-arb' page when i click on save configuration then i am getting this bunch of notices, as mentioned in the screenshot so please look into this issue & fix this.
2. (+) 1. It would be good, if you implement hook_help & hook_permission in your module.
3. Just a recommendation - Nothing

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Automated Review

Click for results of the Automated Review.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Does not include all of the required sections of the README, i.e. Introduction, Requirements, Configuration

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. Function parameters missing from many methods, e.g. commerce_authnet_arb_payment_pane

This review uses the Project Application Review Template.

@manojapare,

Thanks for the module, Ones this application approved, would love to see the 8.x version.

Looks fine, Lets make it to RTBC and will wait and see the review of git admins.

Quick Manual Review :

1. From Install.txt, Please add hook_requirements and check on the runtime $phase that cURL, JSON,SimpleXML PHP Extension are enabled and show the status on the status report page.
2. Remove used variables commerce_authnet_arb_login_id, commerce_authnet_arb_tran_key, commerce_authnet_arb_sandbox, commerce_authnet_arb_md5_hash on hook_uninstall of the module.
3. Move the configuraiton form commerce_authnet_arb_settings_form to a seperate .admin.inc file to get the performance hit
4. For menu commerce-authnet-arb-silentpost and commerce-authnet-arb-silentpost-testAdd atleast least permissions here 'access content'

Looks like the issues is mentioned is fixed, Lets make it to RTBC, will wait and see what is admin's comments.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2803641

Project 2: https://www.drupal.org/node/2756405

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.