[D7] Symlink

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxasiby2653566git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I have downloaded this module, it worked good when I added symlink to test node. But when i tried to view that node through symlink this warning showed up:
Warning: Creating default object from empty value in symlink_node_view() (line 95 of /home/www/test/d7-symlink/sites/default/modules/symlink/symlink.module).
It seems that redundant node title wasn't properly removed, but when i changed line 95 from
$output['body']['#object']->title = '';
to
$output['#node']->title = '';
warning didn't showed up again (node title also).

To test your module I have used Drupal 7.43 with Coder and Devel modules enabled.
I have pulled the newest version from git, no warnings showing up now. But still I see change at line #95 not #118, maybe I'm doing something wrong.

Hi asiby,

Your module looks good. See below comments which needs a little work:

1. As you are creating the Symlink for any node, So in the link field, the value should be auto populated and should not be editable by user.
2. If any User edit any Symlink content and fill the link field value with its self nid, Its breaking the site when you visit the page.

So there should be a validation for that.

User input in symlink field is not validated properly. I can enter any number (nid of non-existing node), any alphanumeric string and it will be saved. Validate the user input by checking if nid is number and is pointing to existing node.
Making field not editable by user is not enough, it's easy to circumvent.

When I add symlink directly by accessing /node/add/symlink, not by "Add symlink" tab node/add/symlink?symlink=, link field shouldn't be disabled.
In function symlink_node_validate you just set error An invalid value was given for the Link field. without any validation, consequently I can't add any symlink anymore ...

/**
 * Implements hook_node_validate().
 */
function symlink_node_validate($node, $form, &$form_state) {
  if ($node->type != 'symlink') {
    return;
  }

  form_set_error('field_symlink', t('An invalid value was given for the Link field.'));
}

Ok, so it would be good to add in function symlink_form_symlink_node_form_alter some message when this statement if ($symlink !== NULL) is false:

  // Attempt to pre-populate the fields only if value is passed in the symlink
  // query string.
  if ($symlink !== NULL) {
  }
  else {
    // Display some message ...
  }

In file symlink.install, line 37:

file_put_contents('/tmp/TYPE.TXT', print_r($type, TRUE));

I think this is for debug and not needed now.
Besides that, it looks good.

Ok, let's mark this RTB and see what will happen ...

Thanks for your contribution, Abdoulaye!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Hi Asiby,

Thank you for your contribution to Drupal.

For creating a content type in a module, the best practice is to implements hook_node_info().
after that your field instances should be attached to the content type in the .install file.

Any suggestions ??

Thank you Asiby for following the coding standard of Drupal.
Good Suggestion, I am going to add it in the issue queue.

Thanks,