Sandbox url

https://www.drupal.org/sandbox/dietervmo/2706891

Description

Context Profiles is a UI module based on context.

I have strived to keep Context profiles a KISS module ( keeping it stupid & simple ).

Currently the main focus of context profiles lays on placement of blocks on content entities.

Additionally, this module allows you to organise blocks placed by different contexts on the same page/entity view.

The module also allows you restrict block providers and regions on a role base, so you can select which users can place which blocks in whatever region.

GIT

From Drupal root.
git clone --branch development https://git.drupal.org/sandbox/DieterVMO/2706891.git modules/custom/context_profiles

CommentFileSizeAuthor
#9 Screenshot from 2016-06-23 19-45-39.png128.9 KBsandeepguntaka

Comments

Napche created an issue. See original summary.

PA robot’s picture

PA robot commented
Issue summary: View changes
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxDieterVMO2706891git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

napche’s picture

napche commented
Issue summary: View changes
napche’s picture

napche commented
Status: Needs work » Needs review
asiby’s picture

asiby commented
Status: Needs review » Needs work

Please check the PAReview at http://pareview.sh/pareview/httpsgitdrupalorgsandboxdietervmo2706891git

It really needs some massaging before we can take a look closer look at the code. If you need assistance in getting rid of these error, I can assist if you don't mind giving me access to the git repo temporarily.

napche’s picture

napche commented
Status: Needs work » Needs review

Thanks for initial review.

I fixed the comments, except for the return comments, which I implemented according to other contrib modules.

bapi_22’s picture

bapi_22 commented

Site goes down after installing the module(Drupal 8.1.1).
Error is below:
Symfony\Component\Routing\Exception\RouteNotFoundException: Route "context_profiles.settings" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 186 of D:\xampp\htdocs\drupal-8.1.1\core\lib\Drupal\Core\Routing\RouteProvider.php).

napche’s picture

napche commented

Apparently it does indeed on fresh installs. Fixed that.

Thanks for your time!

sandeepguntaka’s picture

sandeepguntaka commented
StatusFileSize
new Screenshot from 2016-06-23 19-45-39.png128.9 KB

Hi @napche! Its a good idea for a module on D8, Below are the issues I went across while looking into the module.
Missing Folder Name in Git Url:

In the issue description where you put the Git clone command the folder name was missing from the end of the command. Because of that when I used the command the folder name was '2706891'. Do add "cd [MODULE NAME]" at the end of the command.

Unable to Install the module through drush:

When i tried installing the module from the terminal(drush command) i ve got Route "context_profiles.settings" does not exist. exception so that needs to be handled properly. And the site was down totally. facing "The website encountered an unexpected error. Please try again later." error.
please find the screenshot for the above.

I hope this helps!

napche’s picture

napche commented
Issue summary: View changes

- added folder name to git command
- committed fix for routing e1df2574f229c3e66d46ad4c52d1009867ccf69a to development

Thanks for your feedback!

mlncn’s picture

mlncn commented
Status: Needs review » Fixed

Hi Dieter! You now have vetted git user status and can make Context Profiles a full module. Please keep reviewing and improving your code. Your last changes in November of code comments to just say 'object' should instead have been made a specific class/interface, e.g. " * @param \Drupal\views\Entity\View $view"

Thanks sandeepreddyg and bapi_22

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Assigning issue credits.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.