Summary

A Feeds fetcher module that handles OpenAM authentication

Features

Access Feed URIs that are secured by OpenAM

  • OpenAM Login Details
    • URL, Username, Password ( using the Key module for encryption )
    • Advanced
      • Feed request cookie name, Username header, Password header, Json session Id, User-Agent
  • OpenAM Logout Details
    • URL
    • Advanced
      • Session Id Header, Successful Result search text

Project Page: https://www.drupal.org/project/feeds_auth_openam

Git Repo:
git clone --branch 8.x-1.x https://git.drupal.org/project/feeds_auth_openam.git feeds_auth_openam

Known Issues

Manual Reviews of other projects

Screenshots

Adding a new Feed Type

Add Feed Type

Adding a new Feed 1

Add Feed 1

Adding a new Feed 2

If you only have 1 Feed Type, you won't see this screen.

Add Feed 2

Adding a new Feed 3

Add Feed 3

CommentFileSizeAuthor
#12 feeds_auth_openam_add_feed_3.png111.33 KBhedrickbt
#12 feeds_auth_openam_add_feed_2.png8.15 KBhedrickbt
#12 feeds_auth_openam_add_feed_1.png14.5 KBhedrickbt
#12 feeds_auth_openam_add_feed_type.png46.01 KBhedrickbt

Comments

hedrickbt created an issue. See original summary.

hedrickbt’s picture

hedrickbt commented
Issue summary: View changes
PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxhedrickbt2728667git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

hedrickbt’s picture

hedrickbt commented
hedrickbt’s picture

hedrickbt commented

I have resolved all of the pareview.sh items.

hedrickbt’s picture

hedrickbt commented
Issue summary: View changes
hedrickbt’s picture

hedrickbt commented

The branch with -dev in the name has been removed and the default branch for the project has been set.

hedrickbt’s picture

hedrickbt commented
Issue summary: View changes
hedrickbt’s picture

hedrickbt commented
Status: Needs work » Needs review
hedrickbt’s picture

hedrickbt commented
Issue summary: View changes
hedrickbt’s picture

hedrickbt commented
Issue summary: View changes
hedrickbt’s picture

hedrickbt commented
Issue summary: View changes
StatusFileSize
new feeds_auth_openam_add_feed_type.png46.01 KB
new feeds_auth_openam_add_feed_1.png14.5 KB
new feeds_auth_openam_add_feed_2.png8.15 KB
new feeds_auth_openam_add_feed_3.png111.33 KB
hedrickbt’s picture

hedrickbt commented
Issue summary: View changes
hedrickbt’s picture

hedrickbt commented
Issue summary: View changes
hedrickbt’s picture

hedrickbt commented
Issue summary: View changes
hedrickbt’s picture

hedrickbt commented
Issue summary: View changes
Gorka Guridi’s picture

Gorka Guridi commented

Checked the branch 8.x-1.x and it still has errors in pareview.sh:
http://pareview.sh/pareview/httpsgitdrupalorgsandboxhedrickbt2728667git-...

Am I using the correct branch?

hedrickbt’s picture

hedrickbt commented

I have completely cleaned up all of the code formatting warnings/errors now.

http://pareview.sh/pareview/httpsgitdrupalorgsandboxhedrickbt2728667git-...

warped’s picture

warped commented
Status: Needs review » Postponed (maintainer needs more info)

Thank you for your contribution!

After 2017 March 7 everyone can promote a project to a full project.  A full project has a short project name and a drupal.org/project URL.  It can also have releases (like alpha1 or 1.0).  Edit your sandbox project, and then choose the 'Promote' tab.

https://www.drupal.org/docs/8/understanding-drupal-version-numbers/drupa...
https://www.drupal.org/docs/8/choosing-a-drupal-version/what-do-version-...
https://www.drupal.org/docs/8/understanding-drupal-version-numbers/what-...
https://www.drupal.org/docs/8/choosing-a-drupal-version/release-stable-v...

If you'd like to opt into security coverage, please ensure your module is ready for a full release, and then set this issue back to 'needs' review 

Immense apologies for how long it took to get to this review completed.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

I am closing this application for the lack for replies. I take the OP just needed to be able to promote the project.

hedrickbt’s picture

hedrickbt commented

Sorry I hadn't replied. I lost track of it. It took a couple of years from when I had completed the requirements and when it was approved, but got closed 2 months after it was approved!!

Thanks for helping me get moved along. I have gone to the sandbox and promoted it.

hedrickbt’s picture

hedrickbt commented

Can someone help me understand what "won't fix" means, though? As far as I knew, I did everything I was supposed to, I was waiting on Drupal admins to run with the ball.

I put the ticket back to needs review just to make sure someone sees it and can comment. From what I can tell there isn't anything else I need to do. The Close Won't Fix status confuses me, and probably anyone else that submits a sandbox project.

Thanks
Brooke

hedrickbt’s picture

hedrickbt commented
Status: Closed (won't fix) » Needs review
sleitner’s picture

sleitner commented
Status: Needs review » Needs work

Automated Review

Pareview details: https://pareview.sh/pareview/https-git.drupal.org-project-feeds_auth_ope...

Review of the 8.x-1.x branch (commit 6b9a995):

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template. see pareview
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
  1. (*) use Request API for $_SERVER['SERVER_PORT'] and $_SERVER['HTTP_HOST']
  2. (*) see pareview

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

sleitner’s picture

sleitner commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

@#22: #19 was asking if you wanted to apply to be able to opt into security coverage, or you were fine with being able to create full projects but not opt into security coverage.

This application has never been approved from any reviewers, so far.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.