[D8] Drupalcreate Form Field Type module

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2723953

Project 2: https://www.drupal.org/node/2722137

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxDrupalcreate2723947git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

Best practice issues identified by pareview.sh / drupalcs / coder.

Very little to address

Review of the 8.x-1.x branch (commit 46057b2):

README.md or README.txt is missing, see the guidelines for in-project documentation.

FOUND 1 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------
3 | ERROR | [x] Namespaced classes, interfaces and traits should not
| | begin with a file doc comment
   FILE: ...ew_temp/src/Plugin/Field/FieldFormatter/FormfieldDefaultFormatter.php
   FILE: ...upal-7-pareview/pareview_temp/src/Plugin/Field/FieldType/FormItem.php
   FILE: ...pareview_temp/src/Plugin/Field/FieldWidget/FormfieldDefaultWidget.php

The solution is to move the namespace line just above the @file comment section.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.
https://www.drupal.org/u/drupalcreate

No duplication

Yes: Does not cause module duplication and/or fragmentation.
https://www.drupal.org/search/site/Form%20Field%20Type

Master Branch

Yes: Follows the guidelines for master branch.
Cloning the repo defaults to the 8.x-1.x branch as expected.

Licensing

Yes: Follows the licensing requirements.No license files nor was the word license found in any files.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.
I didn't find any recognizeable 3rd party libraries included in the project

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.
There is no README file.

Code long/complex enough for review

Yes: Follow the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.
I am new to this process but I didn't see any issues.

Coding style & Drupal API usage

List of identified issues in no particular order.

1. (*) Drupal 8.1.1 Test. Added a field custom|Form to a new content type with label of: form. Then, clicked Save and continue:
   • Not Found
   • The requested resource /d/es/admin/structure/types/manage/test/fields/node.test.field_form/storage?destinations%5B0%5D%5Broute_name%5D=entity.field_config.node_field_edit_form&destinations%5B0%5D%5Broute_parameters%5D%5Bfield_config%5D=node.test.field_form&destinations%5B0%5D%5Broute_parameters%5D%5Bnode_type%5D=test&destinations%5B1%5D%5Broute_name%5D=entity.node.field_ui_fields&destinations%5B1%5D%5Broute_parameters%5D%5Bfield_config%5D=node.test.field_form&destinations%5B1%5D%5Broute_parameters%5D%5Bnode_type%5D=test&destinations%5B2%5D=/d/es/admin/structure/types/manage/test/fields/add-field was not found on this server.

   Not sure if this matters, but my test site base is /d/es/ and not just /

2. (+) 3 items listed as ERRORS by PAReview. Very easy fixes
3. I noticed your username is Drupalcreate, but drupalcreate_form_field_type.info.yml refers to Digicreate in the description. Maybe there is a reason for this difference.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

This review uses the Project Application Review Template.

PAReview: Individual user account

It seems you are using a non-individual account.
All user accounts are for individuals. Accounts created for more than one user or those using anonymous mail services will be blocked when discovered (see Get a Drupal.org account).
Please note that organization accounts cannot be approved for git commit access. See https://drupal.org/node/1966218 and https://drupal.org/node/1863498 for details on what is/isn't allowed. Please update your user profile so that we don't have to assume that this is a group account.

Hey @Drupalcreate,

1. PAReview. How are you running phpcs? I use --standard=Drupal and --standard=DrupalPractice and this passes for me

<?php

namespace Drupal\feeds_auth_openam\Feeds\Fetcher;

/**
 * @file
 * Contains \Drupal\feeds_auth_openam\Feeds\Fetcher\HttpFetcherAuthOpenAM.
 */

use Drupal\Component\Serialization\SerializationInterface;

2. Issue I ran into when using the module... This gets more interesting. I created a brand new Drupal site, on my local machine, from the latest 8.1.1 and installed only your module. I was able to recreate the exact same error again. Please note, when I do most of my module development/testing, I just run "php -S localhost:8000" in the Drupal site folder. Very easy, lightweight solution and to date this hasn't caused me any issues when developing/testing.

That said, I decided to sign up for a Digital Ocean 5$ account and created a Droplet to give your module another try. I figured out how to install Drupal w/NGINX using Drush and would you believe it...? I didn't have the same issue with your module! I haven't tried to dig in to figure out why it doesn't work for me using the built in PHP server, but I don't feel that this issue alone should be enough to hold the module back from moving to project status.

I am only putting this back to needs work to get your feedback on which standard of phpcs you are testing with.

Make sure to move the status back to needs review after you add any comments or make changes.

Thanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues (here you get to ask fans of your project to help you!)

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Please note that i strongly recommend you choose module names that aren't tied to an organization (e.g. drupalcreate) if the module itself isn't.