This is a simple, elegant and responsive theme and can be used for multiple purpose. This theme has been built by using simple css, which required SASS code to customize as per user requirement.

Project Screenshot:

https://www.drupal.org/files/project-images/screenshot_230.png

Sandbox Page

https://www.drupal.org/sandbox/brahmjeet789/2654802

Git clone URL

git clone --branch 7.x-1.x https://git.drupal.org/sandbox/brahmjeet789/2654802.git

PAreview

http://pareview.sh/pareview/httpsgitdrupalorgsandboxbrahmjeet7892654802git

Reviews for other projects:

https://www.drupal.org/node/2639174#comment-10797994

Comments

brahmjeet789 created an issue. See original summary.

brahmjeet789’s picture

Category: Support request » Task
PA robot’s picture

Issue summary: View changes
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxbrahmjeet7892654802git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

manjit.singh’s picture

Automated Review

Please resolve the coding standard errors http://pareview.sh/pareview/httpsgitdrupalorgsandboxbrahmjeet7892654802git

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements
Coding style and Other issues
  1. What is the use case of adding http://www.drupal-responsive.com in the footer ? Or Are you taking a design refrence from http://www.drupal-responsive.com ?
  2. Seems like you have forget to add the bootstrap_carousel template in templates directory. check 'template' => 'templates/bootstrap_carousel', in template.php.
  3. Remove .sass-cache directory from code. Does not require.
  4. Add @file description in responsive.css.
  5. Default branch is not set.
manjit.singh’s picture

And probably the name should be [D7] Flame .
There is no need to mention theme in the name. Hope you got my point.

Also please add latest code reviews to speed up your project review process.

brahmjeet789’s picture

Title: D7 Flame Theme » [D7] Flame
PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

brahmjeet789’s picture

Status: Closed (won't fix) » Needs review

I have fixed the issues,please review it again.

manjit.singh’s picture

Status: Needs review » Needs work

There is still an issues in http://pareview.sh/pareview/httpsgitdrupalorgsandboxbrahmjeet7892654802git . Please resolve that.
Also add review bonus.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

brahmjeet789’s picture

Status: Closed (won't fix) » Closed (fixed)

i have fixed all the errors ,please check.

brahmjeet789’s picture

Status: Closed (fixed) » Needs review
gisle’s picture

Issue summary: View changes
Status: Needs review » Needs work

brahmjeet789 wrote:

i have fixed all the errors, please check.

Checking…

PAreview says there still is a PHP Parse error (7.x-1.x branch commit 1a364af):

  • PHP Parse error: syntax error, unexpected end of file in ./templates/page.tpl.php on line 221
    Errors parsing ./templates/page.tpl.php

This automated report was generated with PAReview.sh, your friendly project application review script.

You can run the same script yourself. Why don't you save us all some time by doing it before requesting another review.

brahmjeet789’s picture

Status: Needs work » Needs review

@gisle , now i have fixed all the errors ,please check http://pareview.sh/pareview/httpsgitdrupalorgsandboxbrahmjeet7892654802git
Thanks,
Brahmjeet

brahmjeet789’s picture

userium’s picture

Pareview looks fine, no errors. I checked the code. Nice sass.
Just a very small typo in the readme.txt; Pintrest -> Pinterest.

brahmjeet789’s picture

@userium i have fixed the typo mistake, please check.

brahmjeet789’s picture

brahmjeet789’s picture

Issue summary: View changes
brahmjeet789’s picture

Issue summary: View changes
PA robot’s picture

Issue summary: View changes

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

brahmjeet789’s picture

steniya’s picture

Status: Needs review » Reviewed & tested by the community
steniya’s picture

I tested your theme in my local system, and it work fine for me

misc’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, brahmjeet789!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.