Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
theme
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
18 Apr 2016 at 09:00 UTC
Updated:
22 Oct 2016 at 08:04 UTC
Jump to comment: Most recent
Comments
Comment #2
brahmjeet789 commentedComment #3
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxbrahmjeet7892654802git
Fixed the git clone URL in the issue summary for non-maintainer users.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #4
manjit.singhAutomated Review
Please resolve the coding standard errors http://pareview.sh/pareview/httpsgitdrupalorgsandboxbrahmjeet7892654802git
Manual Review
'template' => 'templates/bootstrap_carousel',in template.php.Comment #5
manjit.singhAnd probably the name should be [D7] Flame .
There is no need to mention theme in the name. Hope you got my point.
Also please add latest code reviews to speed up your project review process.
Comment #6
brahmjeet789 commentedComment #7
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #8
brahmjeet789 commentedI have fixed the issues,please review it again.
Comment #9
manjit.singhThere is still an issues in http://pareview.sh/pareview/httpsgitdrupalorgsandboxbrahmjeet7892654802git . Please resolve that.
Also add review bonus.
Comment #10
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #11
brahmjeet789 commentedi have fixed all the errors ,please check.
Comment #12
brahmjeet789 commentedComment #13
gislebrahmjeet789 wrote:
Checking…
PAreview says there still is a PHP Parse error (7.x-1.x branch commit 1a364af):
Errors parsing ./templates/page.tpl.php
This automated report was generated with PAReview.sh, your friendly project application review script.
You can run the same script yourself. Why don't you save us all some time by doing it before requesting another review.
Comment #14
brahmjeet789 commented@gisle , now i have fixed all the errors ,please check http://pareview.sh/pareview/httpsgitdrupalorgsandboxbrahmjeet7892654802git
Thanks,
Brahmjeet
Comment #15
brahmjeet789 commentedComment #16
userium commentedPareview looks fine, no errors. I checked the code. Nice sass.
Just a very small typo in the readme.txt; Pintrest -> Pinterest.
Comment #17
brahmjeet789 commented@userium i have fixed the typo mistake, please check.
Comment #18
brahmjeet789 commentedComment #19
brahmjeet789 commentedComment #20
brahmjeet789 commentedComment #21
PA robot commentedFixed the git clone URL in the issue summary for non-maintainer users.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #22
brahmjeet789 commentedComment #23
steniya commentedComment #24
steniya commentedI tested your theme in my local system, and it work fine for me
Comment #25
misc commentedThanks for your contribution, brahmjeet789!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.