[D7] Auro

Thank you for your contribution. There are a bunch of errors in the automated tests that you should fix first. See http://pareview.sh/pareview/httpgitdrupalorgsandboxaryashreep2637820git.

You can ignore errors in libraries such as modernizr.js, etc... On that note, I am not sure if you can include modernizr.js (and other third party components) in your theme package. I am not really sure on policies for themes but I believe code hosted on drupal.org cannot contain non-GPL compatible code.

I am moving the issue in the correct queue.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I cloned your theme and after installing your theme i found some issues Either

.postBox {
    margin-bottom: 10px;
    width: 62.4%;
}

or

.postBox .postBoxMid {
    background: #ffffff;
}

Hi aryashreep,
I just downloaded your theme and was checking it out....you would need to use base_path(), while you are trying to print the images.
it should be something like : <img alt="Author" src="<?php print base_path().path_to_theme() . "/images/ico_author.png";?>">

instead of

<img alt="Author" src="<?php print path_to_theme() . "/images/ico_author.png";?>">

It happens that the image doesnt appear, when I create an article. Please fix and also review to see it similarly exists in the other files as well.

Thank You,
Anup
anup_ns

Good job with the readme. One of the best I've seen for a while. A few notes form it though. You telling people ot put libraries in /sites/all/themes/auro/js
I'd think the thing to do is put them in /sites/all/libraries
That way we wont end up with multiple versions if theres more than one module that needs them.

You've also suggested people change the name ot make their own theme. This unneccaserily duplicates stuff. It would be better to advise subtheming in most cases I would think.

As regards your project page I really don't think "Easy to install" should be on the features list since almost all Drupal themes follow the same install method this is irrelevant. In fact since your theme requires libraries and many do not your theme is actually difficult to install by most Drupal theme standards so this feature is erroneous and should be removed.

The automated review is still throwing several errors. You should fix all those errors before changing the status to Needs Review.
Read up on the coding standards - https://www.drupal.org/coding-standards
or simply follow the info in the automated review report since they are all fairly simple fixes.

Changing the status to "Needs Work"

Automated Review

drupalcs errors

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

drupalcs found four errors, three of which were reported multiple times.

1. Spaces must be used to indent lines; tabs are not allowed
2. Spaces must be used for alignment; tabs are not allowed
3. Expected 1 blank line before function; 0 found
4. Expected 1 blank line after function; 0 found

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Yes, these are minor errors that would not block this application. But I posted this review to also point out there are invalid property functions and file references that are not resolved in the stylesheets, particuraly in tabs.css.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

@Richard Buchanan: I think you forgot to change the status. Is this now RTBC after your review or are there application blockers left and this should be "needs work"?

@klausi: You're right, ha. I see no application blockers, updating the status. Thanks.

Thanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues (here you get to ask fans of your project to help you!)

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.