[D7] Application tiles

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxgaydamaka2695167git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi, i reviewed your module project. I think everything looks good. But, good practice is adding the hook_help (https://api.drupal.org/api/drupal/modules!system!system.api.php/function...).

Hi gaydamaka,

Is there a special reason to set "'#disabled' => TRUE"?, if no, please remove "'#disabled' => TRUE" from below mentioned code of "apptiles_form_system_theme_settings_alter" function as it does not allow to select which size to set to customize web-application:-

"$form['tiles'][$os][$dimension] = [
'#type' => 'checkbox',
'#title' => pathinfo($file, PATHINFO_FILENAME),
'#disabled' => TRUE,
'#default_value' => file_exists($file),
];"

Thanks,

Hey,

I liked the idea of your module and i believe this can really be a help to lots of users
I found the following issues while reviewing it on pa review --

FILE: /var/www/drupal-7-pareview/pareview_temp/apptiles.module
---------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------
78 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
79 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
80 | ERROR | [x] Array closing indentation error, expected 4 spaces but
| | found 6
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------

Please fix it.

Change the git clone command to
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/gaydamaka/2695167.git

git clone --branch 7.x-1.x https://git.drupal.org/sandbox/gaydamaka/2695167.git apptiles
cd apptiles

Add a package to the .info file so that your module is bundled under a correct group.

Automated Review

Passed automated reviews on paraview.sh and locally via Coder

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template. The README file and project page could stand to have some more configuration instruction added to them. Without reading the code, it's not intuitive (to me anyway) to look for the configuration to belong at global theme configuration. Please also add links back to the page project, documentaion, and issues pages if there are any.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

No coding issues identified

This review uses the Project Application Review Template.

Your code is very clean and easy to read through. The functionality that this module adds is very valuable and I look forward to this being available. I feel like there should definitely be some more documentation around the setup, or at least where to do it in the Drupal interface, but the functionality looks good as it is.

You might also put some more documentation surrounding what the "Add tiles to admin page?" option does. I can discern what it does by reading through the code, but an end-user might be confused by this.

It's completely ready!

Thanks for your contribution, Vladimir!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.