[D7] Twitter Lite

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxtk421jag2451325git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Found some issue. Kindily look into it.
1. Class name must be prefixed with project name.

2. Does not qualifies the pareview. Most of the errors are of indentation. Please fix it. Below is the link provided:
http://pareview.sh/pareview/httpsgitdrupalorgsandboxtk421jag2451325git

3. Please follow the coding standard.
https://www.drupal.org/coding-standards

Hi tk421jag,

I had a quick look at your module and done my bit of review :)

Automated Review:
Automated code review passed.

Manual Review:
1. Use project page template for the project page.
2. Add hook_help in module.
3. Use proper commit messages see the documentation
4. Use standard comments where ever you implement hooks.
Comment should be like
/**
* Implements hook_menu().
*/
5. Use default value with variable_get in function
6. I think you declared function linkify_tweet2() inside another function by mistake at line no. 285 in twitter_lite.module file

Moving back to N/W due to open issues.

Hi

Maybe beter replace:

'#options' => array(
      1 => t('1'),
      2 => t('2'),
      3 => t('3'),
      4 => t('4'),
      5 => t('5'),
      6 => t('6'),
      7 => t('7'),
      8 => t('8'),
      9 => t('9'),
      10 => t('10'),
    ),

to:

'#options' =>  drupal_map_assoc(range(1, 10)),

Hi tk421jag,

Please see below for answers to your questions:

1. For project page template refer Project page template.
2. As per Drupal module documentation guidelines it is necessary to Provide help text in the Drupal UI.
   

   All but the most trivial modules should implement hook_help().

   Refer Module documentation guidelines.

3. You should pass default value to the variable_get() function to use value if variable is not set. eg: variable_get('twitter_lite_username', '') Refer variable_get().
4. linkify_tweet2() function is defined inside twitter_lite_search() function and also the function linkify_tweet2() not using elsewhere in code. Please correct that in your code.
5. Use module_load_include() instead of require_once() in twitter_lite.module line no 235.

   module_load_include() function does over and above the standard PHP require_once is that it references the module's path when locating the file, using drupal_get_path().

   If you were to use require_once, you would have to do this bit yourself. Refer module_load_include().

Thanks,
ARUN AK

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.