[D7] Mobile Registration

Hi Kashmira,

First of all, Thank you for contributing to Drupal.org.

I've not tested module, but reviewed code. The module code looks fine to me and has also cleared all PAReview test.

Minor Improvement in GIT management as per PAReview:

Git errors:

Git default branch is not set, see the documentation on setting a default branch.

Just a note for future updates:
Since the module currently support mobile numbers only from India, it would be good if you can integrate the module with Telephone module.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[No: Does not follow] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[No: Does not follow] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[No: Does not follow] the guidelines for project length and complexity.

* The reason is your project has less than five function or class method definitions(don't include hook_install and hook_uninstall function)

Secure code

[Yes: Meets the security requirements. / No: List of security issues identified.]

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (*) Explain the usages of what your module do?. You are creating the text field and insert into the table.So I think no need to create a module you can develop the patch for depending module as I listed below.

1. https://www.drupal.org/project/email_registration
2. https://www.drupal.org/project/user_registrationpassword

Or
Creating the functionality like that.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

i have just installed you modules and enabled its not working fine mobile number field validation during update user also multiple login same mobile number.
attached screenshots

setp1

Create admin1 user and moblie number
trying to again create same mobile "Mobile number already exists." its fine.
than i have fill different name and different mobile user register success. than update both account same mobile number updated success.
also login both account both user same mobile number.

i think there is validation problem during user updating.
http://cgit.drupalcode.org/sandbox-shinde_kashmira-2667422/tree/mobile_r...

Hi shinde_kashmira,

I think pattern should be at least international number, or make it as variable (module configrtion ) to make the module usable,

$pattern = '/[2-9]{2}\d{8}/'

@shinde_kashmira Can you describe that how is your module diffrent from https://www.drupal.org/project/phoneuser ?

@Manjit.Singh: duplication is bad and we should definitely point that out to applicants, but it is not an application blocker. Can you do a review of the code?

Removing review bonus tag, you have not done all manual reviews, you just posted the review template in one review. I'm going to remove the bonus tag, as well as the link on reviews from the issue summary.

Make sure to read through the source code of the other projects, as requested on the review bonus page.

Hi,

I reviewed your module project.

I got the below error in the user registration without enter any data. Please check

Notice: Undefined index: user in _mobile_registration_mobile_field_validate() (line 29 of /var/www/html/d77/sites/all/modules/mobile_registration/mobile_registration.module).
Notice: Trying to get property of non-object in _mobile_registration_mobile_field_validate() (line 29 of /var/www/html/d77/sites/all/modules/mobile_registration/mobile_registration.module).

Kindly refer the screen shot(user-reistration-issue.png).

You can also implement hook_help, so that users gets more idea about the module.

/var/www/html/d7/modules/mobile_registration.module
-------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------
21 | ERROR | [x] Whitespace found at end of line
28 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found

Changing the status as per the latest comment. For more information check this out. http://pareview.sh/pareview/httpgitdrupalorgsandboxshindekashmira2667422git

Those 2 minor coding standard error are surely not application blockers, anything else that you found or should this be RTBC instead?

Hi shinde_kashmira,

Please do mobile number validation properly as of now i am able to create account with 3333333333 , 9999999999. As these type of mobile number are not valid.

Hi Shinde,

I tried using your module. I can see the mobile number field on registration form. I have enabled the checkbox of "Allow users login with mobile number or username" as per your read me file. However I cannot find the mobile number field on login page.
I am attaching the screenshots.

Currently there are no validations when the mobile number is edited in the settings form from back end as an administrator. Validate the same.

Automated Review:

Review of the 7.x-1.x branch (commit 0f26123):

Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: /root/repos/pareviewsh/pareview_temp/mobile_registration.module
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
| | line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/mobile_registration.install
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
| | line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Manual Review:

Please fix the following error:

1. No validation of pattern of phone in user edit form. (The field is accepting letters also)
2. No validation of existing phone number in the user edit form.
3. Suggestion: This is a module which does not serve the purpose. Any phone number taken by the user must be validated using the OTP otherwise any random can be used by the customers which makes a security whole on the site.

Individual user account
Yes: Follows the guidelines for individual user accounts.

No duplication
Yes: Does not cause module duplication and/or fragmentation.

Master Branch
Yes: Follows the guidelines for master branch.

Licensing
Yes: Follows the licensing requirements.

3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.

README.txt
Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.

Secure code
Yes: Meets the security requirements.

Coding style & Drupal API usage
List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
It is good to put drupal template file in template directory.
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.