[D7] Facebook Instant Articles

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxvgardner2676800git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

Some issues found, you can check on this link:http://pareview.sh/pareview/httpgitdrupalorgsandboxvgardner2676800git

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

List of identified issues:

1. Warning: Invalid argument supplied for foreach() in facebook_instant_articles_get_article_nodes() (line 234 of /Applications/MAMP/htdocs/fresh-drupal/sites/all/modules/2676800/facebook_instant_articles.module).

This review uses the Project Application Review Template.

I took some time to install the module and go through its code. Overall everything looks great, just found one small thing:

/**
* Implements hook_help().
*/
function facebook_instant_articles_menu() {

The comment should say hook_menu not hook_help.

Looks good to me... changing it to RTBC.

@vgardner - great work!

Second RTBC here and hoping this gets promoted soon as we're going to be implementing shortly for an early access whitelisted site for us.

I had a chance to look at the code and there is a $nodes += node_load_multiple(array(), array('type' => $content_type, 'status' => 1)); on line 236, which may break the large sites. Since its trying to load all the content on some particular content type without any limit. But this won't be an issue on smaller sites which has less nodes.

So my suggestion here is like instead of loading all the content load only top 25 or 50 like that. so this will avoid the performance hit or page timeout.

I ran into the issue described by anbarasan.r in #16 and created a patch to address the issue: https://www.drupal.org/node/2684395.

@anbarasan.r - nice catch, I just saw this patch earlier addressing this issue #2684395: Use EntityFieldQuery instead of node_load_multiple. While this is an important patch, I don't think it should prevent getting this module promoted and live as it's a very timely module that we need efforts aligned behind in the community (in my opinion - kudos to vgardner on the work here.

Thank you for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go also to the dedicated reviewer(s) as well.

I am giving credits to the users who participated in this issue.