Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
1 Oct 2015 at 02:38 UTC
Updated:
11 Jun 2016 at 17:54 UTC
Jump to comment: Most recent
Comments
Comment #2
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
gaja_daran commentedHi jackfoust,
Remove the variables capterra_roles, capterra_vid and capterra_vkey when your module has uninstall.
Refer:
https://api.drupal.org/api/drupal/modules!system!system.api.php/function...
Comment #4
jackfoust commentedGreat catch Selva,
Added hook_uninstall for the 3 variables above and a 4th that was also set by the variable.
Thanks!
Comment #5
cherebedov.s commentedHi. You should provide the hook_help to allow site builders to find information about your module using Drupal UI.
Comment #6
jackfoust commentedAdded hook_help on module configuration page.
Comment #7
vgardnerManual Review
Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
None, good to see that you've addressed those issues from the previous review.
This module looks good to me and does what it says on the tin.
Comment #8
vgardnerComment #9
heykarthikwithuLooks fine, a minor change as per paraview needs to be done.
http://pareview.sh/pareview/httpgitdrupalorgsandboxjackfoust2428237git
@jackfoust, And also review other issues on this project applications, for that you will get yourself a tag for this issue,
so that this particular issue will move as priority :)
Comment #10
jackfoust commentedThanks for the review vgardner.
Thanks for the review heykarthikwithu. I have fixed the line length and re-verified with pareview. I'll take a look at other issues. Thanks for the suggestion.
Comment #11
damienmckennaThanks for your contribution, Jack!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.