This modules enables payline.ir payment method for drupal commerce module.
For additional information about payline check their website: http://www.payline.ir

REQUIREMENTS
Just drupal `commerce` and `commerce payment` submodule.

INSTALLATION
* Install as usual, see https://drupal.org/documentation/install/modules-themes/modules-7 for further information.

CONFIGURATION
* Configure payline gateway in Administration » Store » Configuration » Payment methods:
- Find Payline Gateway and click on edit link.
- In Actions section click on edit link in front of "Enable payment method: Payline Gateway".
- Fill in required information like api code and gateway addresses which you've obtained from payline.
* you can select "Debug" checkbox to use payline test api for assuring everything is fine before going live.

https://www.drupal.org/sandbox/sepehrmm/2179893
git clone --branch master http://git.drupal.org/sandbox/sepehrmm/2179893.git commerce_payline
Intended Drupal core version 7.x

Comments

sepehr.sadatifar created an issue. See original summary.

sepehr.sadatifar’s picture

Issue summary: View changes
Status: Active » Needs review
PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxsepehrmm2179893git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

sepehr.sadatifar’s picture

Status: Closed (won't fix) » Needs review
vgardner’s picture

Hi @sepehr.sadatifar,
Looks like you have some issues being reported by preview - http://pareview.sh/pareview/httpgitdrupalorgsandboxsepehrmm2179893git

- On the commerce_payline_send and commerce_payline_get functions, you should consider creating one function function that makes the requests and accepts the post fields as a parameter.

- When calling curl_exec, check if the request was successful or not an handle the error accordingly.

- On the .info file you are referencing a specific instant of a payment method for the configuration page - configure = "admin/commerce/config/payment-methods/manage/commerce_payment_commerce_payline/edit/3". This should be used in case you are declaring your own configuration page in your module.

- The URLs http://payline.ir/payment/gateway-send and http://payline.ir/payment-test/gateway-result-second are being referenced many times in your code as strings. Consider putting them in Drupal variables or constants so they are easily configurable.

- Also, please fill in the description in your project page - https://www.drupal.org/sandbox/sepehrmm/2179893

Regards
Vin

djalxs’s picture

Status: Needs review » Needs work

This module has now been inactive for 12 months as the 'Needs Work' status was not set on the previous comment.

Have any of the issues in the previous comment been fixed?

sepehr.sadatifar’s picture

Status: Needs work » Closed (outdated)

The 3rd party service has been re-branded and use different name and possibly different API so there's no reason for this sandbox to become full project anymore.
Another sandbox project named Commerce Bitpayir has been developed for the new service by another developer.
Thanks everyone for spending time to check the code, the effort is not wasted as the code of the new project has been inspired by this one.