[D7] Cart Deletion Undo

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Your git clone command you've goiven contains your username and was for you only. It did not allow others to clone your project. As a developer, you're expected to understand how to specify how to use git to let others iteract with your code in the Drupal.org repo.

To get people to review your application, you need to set its state to "Needs review" (not "Active"). Please see project applicaton workflow.

According to PAreview there is a lot that is wrong:
http://pareview.sh/pareview/httpsgitdrupalorgsandboxpandya-hardik2668930...

Why don't you fix some of the errors while waiting for a manual review?

You should at least fix the following, as they IMHO will block promotion:

• Git default branch is not set, see the documentation on setting a default branch.
• Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
• Remove all emacs backup files from your repository.
• Use cart_deletion_undo as variable prefix (not cart-deletion-undo).
• Don't use an open callback (e.g. 'access callback' => TRUE). Use a real permission.
• Do not use t() in hook_menu()

@Hardik,

Please fix below mention issues of automated preview.

http://pareview.sh/pareview/httpsgitdrupalorgsandboxpandya-hardik2668930git

Hello hardik.p,

My findings for your module as follows:

1) cart_deletion_undo.module
- Do not use t() in hook_menu() function
- Line 16 - A comma should follow the last multiline array item
- Indentation after very first line of each function is not correct. Expected 2 spaces, but found 4 spaces in each function
- A comma should follow the last multiline array item - line no 31.

2) README.txt
- There is one line in README.txt file which exceeds 80 characters limit

Thanks

Hi Hardik,

The variable "cart_deletion_undo_substring" is a configuration variable and should be removed/deleted on module un-installation. Check hook_uninstall().

Hi hardik.p,

Automated Review

Please check the errors in automatic reviews
http://pareview.sh/pareview/httpsgitdrupalorgsandboxpandya-hardik2668930git

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (*) 1. The variable "cart_deletion_undo_substring" is a configuration variable and should be removed/deleted on module un-installation. as mentioned by @neha_patil please check hook_uninstall() for this.
2. (+) 1. It would be good, if you implement hook_help in your module.
   2. As mentioned in the README.txt 'admin/admin/config/cart-deletion-undo-setting' configuration link is wrong you should have to remove one 'admin' word from the configuration link. you can also add configuration page link in .info file
3. Just a recommendation - Nothing

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Hi hardik.p

The URL's which you have added in above comment has to be added into the original post. You can edit this issue and add these URL's in post itself with heading 'Manual reviews of other projects'.

Reference URL - https://www.drupal.org/node/1975228 See 2nd point in How it Works section.

Thanks

@hardik.p

Also please change the status of this issue to 'Needs review' if you have done with suggested changes. Or keep the status 'Needs work' if you are still working on changes/issues.

Thanks

This module looks good and working for me. also there are no blocker points left.
So i am marking this module as RTBC.

Upgrading to critical since this hasn't received attention for over 4 weeks.

Removing review bonus tag, you have not done all manual reviews, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.

Automated Review

PAReview came up clean.

Manual Review

cart_deletion_undo(): Usages of drupal_goto() sometimes becomes hacky, hence it should be avoided. It looks fine in your case though.

cart_deletion_undo_exit(): do not create link markup yourself, use url() or l() instead. Also, all user facing text (e.g. Undo) must run through t() for translation.

Your settings form can go in a .admin.inc file; this can help cut down on the memory footprint for people who can't access admin pages.

Project Page: Extend this little bit more, better to go through Tips for a great project page again.

cart_deletion_undo.info: Looks like there is no need to wrap configure link within single-quote('). See https://www.drupal.org/node/542202

I am not seeing any blocking issues, code is very well written and docs are very well organised so I am keeping RTBC. Assigning to @mpdonadio for a second look if he has time.

no objections for more than a week, so ...

Thanks for your contribution, Hardik Pandya!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.