[D7] Commerce order status background

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi genzer,

My Observations:

1. The variables "commerce_order_background_border_color" and "commerce_order_background_colors" are configuration variables and should be removed/deleted on module un-installation. Check hook_unistall().
2. Incorrect spelling of background at line number 5 of commerce_order_background.module.
3. :) in drupal_set_message line number 91 of commerce_order_background.module.I suggest you remove it.
4. It would be good if you could provide more flexibility with the views this module works with.Currently it only works with Commerce Backoffice Orders.

Best Regards

Hi genzer

Here some additional observations:

1. I would rename commerce_order_background_setting_form to _commerce_order_background_setting_form and commerce_order_background_setting_form_submit to _commerce_order_background_setting_form_submit so it's clear that those functions are callbacks and not hook implementing functions.
2. Add a README.txt (or README.md) to your module
3. The spectrum JS/CSS should be saved under sites/all/libraries and your module should implement a hook_library
4. The javascript should look as follows:
   

   /**
    * @file
    * JS script to module Commerce order status background.
    */
   (function ($, Drupal) {
     'use strict';
   
     Drupal.behaviors.commerce_order_background = {
       attach: function (context) {
         // YOUR CODE
       }
     };
   
   })(jQuery, Drupal);
   
   

Cheers!
David

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

• Remove "version" from the ./commerce_order_background.info file, it will be added by drupal.org packaging automatically.
• Remove "project" from the ./commerce_order_background.info file, it will be added by drupal.org packaging automatically.
• Remove "datestamp" from the ./commerce_order_background.info file, it will be added by drupal.org packaging automatically.

click the check more detailed issues

It seems still its not fixed
got to the url https://pareview.sh
give the git url in the text box https://git.drupal.org/sandbox/Genzer/2735009.git
then subit it shows the error

Hi

I have manually reviewed the project and below are the issue I found

1. _commerce_order_background_setting_form is a form in your module, it should start with the module name without "_"
2. No need to call the submit function in $form['submit'], by default hook_validate and hook_submit gets called for each form

Example :

function form_example_form($form, &$form_state) {
  
  $form['submit_button'] = array(
    '#type' => 'submit',
    '#value' => t('Click Here!'),
  );
  
  return $form;
}

function form_example_form_validate($form, &$form_state) {
}

function form_example_form_submit($form, &$form_state) {
}

3. css and js file should be prefixed with name of the module to avoid confusion.

Thanks
anup.singh

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Thank you for your contribution!

After 2017 March 7 everyone can promote a project to a full project.  A full project has a short project name and a drupal.org/project URL.  It can also have releases (like alpha1 or 1.0).  Edit your sandbox project, and then choose the 'Promote' tab.

https://www.drupal.org/docs/8/understanding-drupal-version-numbers/drupa...
https://www.drupal.org/docs/8/choosing-a-drupal-version/what-do-version-...
https://www.drupal.org/docs/8/understanding-drupal-version-numbers/what-...
https://www.drupal.org/docs/8/choosing-a-drupal-version/release-stable-v...

If you'd like to opt into security coverage, please ensure your module is ready for a full release, and then set this issue back to 'needs review'

Immense apologies for how long it took to get to this review completed.

I am closing due to lack of replies.

If you are still working on this application, and you need to be able to opt in the security coverage for the projects you maintain, please set the status to Needs review. (See also the project application workflow).