[D8] Foundation Layouts

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjosebc2649374git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

There are a handful of minor coding standards issues. Evidently, "Namespaced classes, interfaces and traits should not begin with a file doc comment" is a fairly new change to the standards (see #2304909: Relax requirement for @file when using OO Class or Interface per file).

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

The text in the README documentation for the project is fairly minimal, but covers the basics. If you can provide more a bit more information it would be helpful. Please also include the same information—requirements, in particular—on the project description page.

Code long/complex enough for review

No: Does not follow the guidelines for project length and complexity.

Not exactly; there are four functions/methods and just about 120 lines of code, but most of the functionality comes from Twig template files and YAML definitions, so more functions are not necessary.

Secure code

Yes: Meets the security requirements.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

@rlhawk: I think you forgot to change the status. Are there any blockers left or is this now RTBC?

Yes, RTBC..

manual review:

1. project page: what does the module do? What is the use case, why would I use it? Can you describe that according to https://www.drupal.org/node/997024 ?
2. FoundationLayouts::submitConfigurationForm(): why do you have to unset attributes here? Please add a comment.

Otherwise looks good to me.

Thanks for your contribution, Yousef!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.