The intention of this module is to display start and end dates in a fancy
way by combining them together. My recommendation is to use it when your
date format is displaying only date, not time, because is useless to group
time by hours or minutes.
Example: you have a formatted date: May 01, 2016 with format (F d, Y)
using this module you will receive next formatted dates combinations.
* May 01-03, 2016
* May 05-June 06, 2016
* August 27, 2016-May 14, 2017
Common parts like same month or same year are merged together. First date
range occurs in same month and year, second in same year and the last in
two different years.
See project page for more information and screenshots.
Project Page:
https://www.drupal.org/sandbox/sdstyles/2642570
Git:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/sdstyles/2642570.git date_group
cd date_group
Manual reviews:
https://www.drupal.org/node/2630256#comment-10757184
https://www.drupal.org/node/2641216#comment-10758858
https://www.drupal.org/node/2633498#comment-10761320
Comments
Comment #2
sdstyles CreditAttribution: sdstyles at FFW commentedComment #3
sdstyles CreditAttribution: sdstyles at FFW commentedComment #4
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxsdstyles2642570git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #5
sdstyles CreditAttribution: sdstyles at FFW commentedComment #6
sdstyles CreditAttribution: sdstyles at FFW commentedComment #7
atul4drupal CreditAttribution: atul4drupal commentedHello sdstyles,
Please look into the observations:
.module file
1) Use l() instead of line 36.
Rest looks fine.
Comment #8
atul4drupal CreditAttribution: atul4drupal commentedComment #9
sushilck CreditAttribution: sushilck commentedAutomated Review
No Issue pareview.sh http://pareview.sh/pareview/httpgitdrupalorgsandboxsdstyles2642570git
Manual Review
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #10
sdstyles CreditAttribution: sdstyles at FFW commentedHi guys, thank you for the reviews.
I've made changes to source code and updated issue summary to be more concise and informative.
Comment #11
sdstyles CreditAttribution: sdstyles at FFW commentedComment #12
cbuvaneswaran CreditAttribution: cbuvaneswaran as a volunteer commentedAutomated Review
No issue http://git.drupal.org/sandbox/sdstyles/2642570.git
Manual Review
Individual user account
Yes: Follows
Master Branch
Yes: Follows.
Licensing
Yes: Follows.
README.txt/README.md
Yes: Follows
Coding style & Drupal API usage
It is recommended to use configuration path in the info file to display the configuration settings in the module page.
Comment #13
sdstyles CreditAttribution: sdstyles at FFW commented@Buvanesh thanks for review, but this module doesn't have own config page, it's only add new format option for date field type, so I think it's not necessary.
Comment #14
josebc CreditAttribution: josebc at Vardot commentedThis module seams like a good idea and can save a lot of development time over projects
Did some manual review and found the following issue
1 - Create new date field without checking the collect end date .
2 - Select Dates Group in the manage display tab.
3 - Create content with single date.
On view the following warning is shown
Warning: date_timezone_set() expects parameter 1 to be DateTime, boolean given in format_date() (line 2046 of /var/www/drupal/includes/common.inc).
Warning: date_format() expects parameter 1 to be DateTimeInterface, boolean given in format_date() (line 2056 of /var/www/drupal/includes/common.inc).
Maybe adding some additional validation or fallback would help
Comment #15
sdstyles CreditAttribution: sdstyles at FFW commentedHi @josebc, thanks for feedback.
Issue was only for date field of type timestamp no matter a end date was collected or not.
Comment #16
pankajsachdeva CreditAttribution: pankajsachdeva at QED42 commentedHi @josebc,
This module works fine. I have a suggestion to you that to use hook_help() in your code.
Comment #17
pankajsachdeva CreditAttribution: pankajsachdeva at QED42 commentedComment #18
kattekrab CreditAttribution: kattekrab as a volunteer commentedComment #19
mpdonadioUp next in my queue.
Comment #20
mpdonadioAutomated Review
Review of the 7.x-1.x branch (commit f9d2fcd):
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
Manual Review
Nothing juped out at me.
You don't need the quotes around the description in the.info file.
In date_group_field_formatter_settings_form(), don't pass formatted links to t(). See https://www.drupal.org/node/322774
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
No blockers. Assigning to @er.pushpinderrana for a second look, if he has time. Otherwise, I will approve in seven days.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #21
sdstyles CreditAttribution: sdstyles at FFW commentedHi mpdonadio, big thank you for review and feedback,
I corrected info file description, and problem with translation of strings with a link, looking forward for your feedback.
Comment #22
klausilooking at this now.
Comment #23
klausiLooks good to me!
Thanks for your contribution, Sorin!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #24
sdstyles CreditAttribution: sdstyles at FFW commentedThank you Klaus for the great news.