[D7] Date Group

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxsdstyles2642570git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello sdstyles,

Please look into the observations:

.module file
1) Use l() instead of line 36.

Rest looks fine.

Automated Review

No Issue pareview.sh http://pareview.sh/pareview/httpgitdrupalorgsandboxsdstyles2642570git

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[No: Causes] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (+)Need to check time factor else everything looks fine

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Automated Review
No issue http://git.drupal.org/sandbox/sdstyles/2642570.git
Manual Review
Individual user account
Yes: Follows
Master Branch
Yes: Follows.
Licensing
Yes: Follows.
README.txt/README.md
Yes: Follows
Coding style & Drupal API usage
It is recommended to use configuration path in the info file to display the configuration settings in the module page.

This module seams like a good idea and can save a lot of development time over projects

Did some manual review and found the following issue

1 - Create new date field without checking the collect end date .
2 - Select Dates Group in the manage display tab.
3 - Create content with single date.

On view the following warning is shown

Warning: date_timezone_set() expects parameter 1 to be DateTime, boolean given in format_date() (line 2046 of /var/www/drupal/includes/common.inc).
Warning: date_format() expects parameter 1 to be DateTimeInterface, boolean given in format_date() (line 2056 of /var/www/drupal/includes/common.inc).

Maybe adding some additional validation or fallback would help

Hi @josebc,

This module works fine. I have a suggestion to you that to use hook_help() in your code.

Up next in my queue.

Automated Review

Review of the 7.x-1.x branch (commit f9d2fcd):

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Nothing juped out at me.

Coding style & Drupal API usage

You don't need the quotes around the description in the.info file.

In date_group_field_formatter_settings_form(), don't pass formatted links to t(). See https://www.drupal.org/node/322774

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

No blockers. Assigning to @er.pushpinderrana for a second look, if he has time. Otherwise, I will approve in seven days.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

looking at this now.

Looks good to me!

Thanks for your contribution, Sorin!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.