[D7] Views Exposed Field Filter

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxshabirahmad2642802git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello shabirahmad,

To make your module more standard please add README.txt file to your module.
Its good practice to add one and brief others about the module in it.

Hello shabirahmad,

In addition to the above point, just test your module for common code formating errors at "http://pareview.sh".

For instance :
1) In module file add ablank line at end of the file.
2) Function comment ends with a period.

You can see the automated error report at 'http://pareview.sh/pareview/httpgitdrupalorgsandboxshabirahmad2642802git'.

NW for the following errors which are not yet addressed.

FILE: ...eview_temp/views/views_handler_filters_views_exposed_field_filter.inc
---------------------------------------------------------------------------
FOUND 38 ERRORS AFFECTING 20 LINES
---------------------------------------------------------------------------
15 | ERROR | [x] Doc comment short description must end with a full stop
25 | ERROR | [ ] Visibility must be declared on method
| | "option_definition"
35 | ERROR | [ ] Visibility must be declared on method "options_form"
64 | ERROR | [ ] Visibility must be declared on method "value_form"
96 | ERROR | [ ] Visibility must be declared on method "query"
100 | ERROR | [x] No space found before comment text; expected "// In
| | case the the user select any field" but found "//In
| | case the the user select any field"
100 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, or question marks
135 | ERROR | [x] Functions must not contain multiple empty lines in a
| | row; found 2 empty lines
140 | ERROR | [x] No space found before comment text; expected "// if
| | field selected send it to along with value to operator
| | functions" but found "//if field selected send it to
| | along with value to operator functions"
140 | ERROR | [x] Inline comments must start with a capital letter
140 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, or question marks
155 | ERROR | [ ] Visibility must be declared on method "op_equal"
163 | ERROR | [ ] Visibility must be declared on method "op_contains"
170 | ERROR | [ ] Visibility must be declared on method "op_word"
205 | ERROR | [ ] Visibility must be declared on method "op_starts"
212 | ERROR | [ ] Visibility must be declared on method "op_not_starts"
219 | ERROR | [ ] Visibility must be declared on method "op_ends"
226 | ERROR | [ ] Visibility must be declared on method "op_not_ends"
233 | ERROR | [ ] Visibility must be declared on method "op_not"
240 | ERROR | [ ] Visibility must be declared on method "op_regex"
247 | ERROR | [ ] Visibility must be declared on method "op_empty"
257 | ERROR | [x] Expected 1 newline at end of file; 0 found
257 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: ...r/www/drupal-7-pareview/pareview_temp/views_exposed_field_filter.info
---------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------
4 | ERROR | [ ] It's only necessary to declare files[] if they declare a
| | class or interface.
5 | ERROR | [ ] It's only necessary to declare files[] if they declare a
| | class or interface.
7 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/README.md
-----------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------
3 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
7 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
9 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
9 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------

FILE: ...www/drupal-7-pareview/pareview_temp/views_exposed_field_filter.module
---------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 5 LINES
---------------------------------------------------------------------------
4 | ERROR | [x] Doc comment short description must end with a full
| | stop
8 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
8 | ERROR | [x] Doc comment short description must end with a full
| | stop
12 | ERROR | [x] Array indentation error, expected 4 spaces but found 3
13 | ERROR | [x] Array indentation error, expected 4 spaces but found 3
15 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

If there is a config option which can hide dependent exposed filters, this module will be much more valuable.

I have reviewed it, It looks like working as expected no release blockers.

Just quickly scanned through the module. It looks solid in general, especially given how similar it is compared to the combine filter.

Hello,
1. Please check coding standard http://pareview.sh/pareview/httpgitdrupalorgsandboxshabirahmad2642802git
2. Please add more information to README about how use your module.

Thanks for your work!

Looks fine, needs an updated readme :)

Hello,
1. Add more step to install and use your module, please refer below template to write README file.
https://www.drupal.org/node/2181737
2. Add new line to each file according to Drupal coding standard.
https://www.drupal.org/coding-standards

Thanks for your hard work, Over all great work.

Automated Review

Best practice issues identified by pareview.sh / drupalcs / coder. Yes, however those seems to be false to me but you should take a look on attached file (pareview.txt) once.

FYI...Review of the 7.x-1.x branch (commit 3f60fa1):

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follow the guidelines for 3rd party assets/code.

README.txt/README.md

Maybe: Follows the guidelines for in-project documentation and/or the README Template. Could be expanded more.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meet the security requirements.

Coding style & Drupal API usage

Some functions needs a proper docblock and Indentations otherwise it looks good to me.

I am not seeing any blocking issues, code is very well organised so I am keeping RTBC. Assigning to @mpdonadio for a second look if he has time.

Automated Review

Review of the 7.x-1.x branch (commit 3f60fa1):

Not attaching output, as they all look like false reports b/c Views requirements.

Manual Review

Secure code

Yes: Meets the security requirements. Didn't see anything wrong.

Coding style & Drupal API usage

Not 100% sure whether CONCAT_WS() is in SQLite, which is a supported database in Drupal 7. May be worth mentioning.

README is really lean. You should expand it.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Not seeing anything to block this, especially since @dawehner gave this a once over from a Views perspective.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Thanks for your contribution, shabirahmad!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.