[D7] HTML Tag Selector

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,
Only thing I got in your "html_tag_selector_block.tpl.php" during manual review the constant text should be under t() function.

Hello Moshnoi,

There are few comments from my side which i think can be worked on

1. There is a spelling mistake for Deactivate line number 10, html_tag_selector_block.tpl.php
2. You are using "<p id='html_tag_selector_block'>HTML Tag Selector Block</p>" on line 46 of html_tag_selector.module which i think is unnecessary you should make it simply as t('HTML Tag Selector Block');
3. In README.txt you can include steps on how to use this module, like first you need to click on webpage of which selector you want to pick

Hi @moshnoi,

Nice module. Works fine.
Just a spelling mistake in your module description: Change JQeury to jQuery

Other than that, I would suggest changing "GET HTML TAG Selector" to "Get Html Tag Selector" in module.info file. Looks more neat.

Thanks

@lhuria94: that seem to be useful improvements, but surely not application blockers. Anything else that you found or should this be RTBC instead?

No. I could not find any other issue.
Looks fine. Works as per expected. Good to go for RTBC.

Automated Review

No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

Link: http://pareview.sh/pareview/httpgitdrupalorgsandboxmoshnoi2643520git

Manual Review

Line #43 best practice is to provide block delta. In your function you didn't provide one. If your module provide another block then you will have to re-write the code in hook_block_view. My suggestion is to use the following:

function html_tag_selector_block_view($delta = '') {
  switch($delta) {
    case 'html_tag_selector_block':
      $block = array();
      $block['subject'] = t("HTML Tag Selector Block");

      if (user_access('access block html tag selector')) {
        $path = drupal_get_path("module", "html_tag_selector");
        drupal_add_css($path . "/css/html_tag_selector_styles.css");
        drupal_add_js($path . "/js/html_tag_selector_script.js");

        $block['content'] = theme('html_tag_selector_block_theme');
      }
      else {
        $block['content'] = t('No content available.');
      }
      break;
  }

  return $block;
}

2) Don't call theme function directly. Its not a good practice. Use render array #theme key instead:

$block['subject'] = t('Your block title');
			$block['content'] = array(
				'#theme' => 'html_tag_selector_block_theme',
				);

Automated Review

Review of the 7.x-1.x branch (commit 960ce55):

No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

No: Causes module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (*) Major finding, needs work
2. (+) Release blocker
3. Just a recommendation
4. Would be good, if you implement hook_help()
5. Need to add more comments.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

You could bump up your priority from normal to major to get attention from the admins.

manual review:

1. project page: what is the use case of this module? Who should use it? Could you add a screenshot? See also https://www.drupal.org/node/997024 . Is this similar to Chrome or Firefox dev tools?
2. html_tag_selector_block_view(): do not use drupal_add_js/css() here, use #attached with the block render array instead. See for example https://api.drupal.org/api/drupal/developer--topics--forms_api_reference...
3. html_tag_selector_block_view(): if the user does not have permission to see the block you can simply let the content empty and Drupal will not show it at all.

I'm not sure what the benefit is over just using developer tools in browsers such as Firefox or Chrome, but otherwise looks good to me.

Thanks for your contribution, Ion!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.