[D7] Reading Progress Bar

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxhimanshupathak3254995...

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

@himanshupathak3 : Fix pareview errors - http://pareview.sh/pareview/httpgitdrupalorgsandboxhimanshupathak3254995...

Hi @Himanshu,
Module functionally working, checked with different styles in configuration and its working fine.

I don't see any code changes required from my side. But i will suggest you to improve README file. Pls check here https://www.drupal.org/node/2181737 and follow template :)

I moving it to RTBC, lets see what others will say.

Automated Review

Review of the 7.x-1.x branch (commit 647a59c):

No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
Source: http://pareview.sh/ - PAReview.sh online service

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows / No: Does not follow] the guidelines for 3rd party assets/code.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

1. In reading_progress_bar_uninstall(), cant we use variable_del, since we have only reading_progress_bar_top_bar subset.
2. Readme.txt : Update the config path in the file.I would suggest you to use Readme Template

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

@himanshupathak3, review other project application and get a PAReview: review bonus to this issue :).

Hi himanshupathak3,

Found some XSS issues with your configuration page.

You can test it by inserting the following value:
;} /*]]>*/--> </style><script>alert('hacked')</script>
After saving, a popup will be visible.

To fix this use functions like filter_xss() or check_plain() (see also: http://drupal.stackexchange.com/questions/114944/how-and-when-to-use-fil...)
Apply this in for every variable that can be printed on the screen (visible like text, images or invisible like inline code).

Some nice additions could be to:

• add form element validation on admin form
• support the color module for color picking.
• excluding/including paths or themes

In this way you can show your skills more and have more luck with getting a project status.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2593421

Project 2: https://www.drupal.org/node/2718615

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Module looks good and working for me. I think we don't have any blocker points. So i am marking as RTBC.

Thanks for your contribution, himanshupathak3!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.