Working on S3FS Drupal-8 Port. Will update more by weekend.

Comments

webankit created an issue. See original summary.

coredumperror’s picture

Category: Support request » Task

Oh cool, thanks! My code shop has no intention of moving to Drupal 8, since we'll be dropping Drupal entirely by the end of next year. So I wasn't planning to make a Drupal 8 port, myself.

I'm very glad that you're taking the initiative!

webankit’s picture

coredumperror: Can you please add me as a maintainer for this project

coredumperror’s picture

You can now commit to git. You should start a new branch called 8.x-2.x

neerajskydiver’s picture

coredumperror, I am working along with Ankit on D8 port. Can you please add permission for me to do git commit or add as co-maintainer?

coredumperror’s picture

You're set up with commit permissions, now. Have at it! :)

no sssweat’s picture

Hello porting people,

Just wanted to let you porting guys know that there is a Drupal Module Upgrader Module

This project is a command-line script that scans the source of a Drupal 7 module, flags any code that requires updating to Drupal 8, points off to any relevant API change notices, and (where possible) will actually attempt to convert the Drupal 7 code automatically to the Drupal 8 version! The goal is to hit the most widely-used Drupal hooks and ensure there's coverage for them.

not sure if you knew about it already, but if not, then check it out!!! it may possibly be helpful to you.

webankit’s picture

Please release 8.x-2.x as a dev version so that we can start creating issues.

coredumperror’s picture

Done. I also gave you guys full co-maintainership, so you can do that yourself in the future.

RaisinBranCrunch’s picture

Awesome to hear that you guys are making a D8 port, we're planning on using it. Let me know when it's test-ready and I'll test it thoroughly.

webankit’s picture

@RaisinBranCrunch Module is ready for initial testing. Composer Manager (latest dev) is needed to install AWS Library.
Go to admin/config/media/s3fs and do S3 Settings. Then choose S3 stream for image in article. It's working!

RaisinBranCrunch’s picture

Awesome, it is indeed working! Installing it crashed on me on a beta14 server, but on an RC1 site it installed and worked perfectly. Due to annoying reasons, our main site is stuck on beta14 for now, so I won't be able to test it too deeply just yet.

coredumperror’s picture

How's the development on this going? With Drupal 8 now live, it'd be great to have a D8 version of S3FS be available for everyone.

lookitscook’s picture

I'd like to echo @coredumperror's question. If it looks like we can get a D8 version of this and the CORS module (https://www.drupal.org/node/2732345) ZEBRADOG (https://www.zebradog.com) would be interested in sponsoring a push.

ouelmart’s picture

I am very interested with this development. is there specific instruction to install on drupal 8?

theVman’s picture

Hi Guys,

I have a noob question on the 8.x-2.x port so please go easy on me. The documentation says that this depends on the libraries 2.x and not 3.x. However, there is no libraries 2.x for drupal 8. How do I get around that?

neetu morwani’s picture

@theVman,
The Readme.txt also has installation instructions for 7.x version of the module.
Please use composer for fetching the dependenciew in case of D8 port. Feel free to ask more if it is still unclear.

theVman’s picture

@neetu: So what you're suggesting is installing the 8.x version via composer manager. correct?

naveenvalecha’s picture

Version: 7.x-2.x-dev » 8.x-2.x-dev

@theVman,
Composer Manager will no longer supported after Feb 2017. See about what/how can you use composer in your drupal project https://www.drupal.org/node/2404989

Filed followup for Readme.txt file https://www.drupal.org/node/2756413

naveenvalecha’s picture

Category: Task » Plan

moving category to plan

naveenvalecha’s picture

Title: S3FS Drupal-8 Port » Drupal 8 Port
webankit’s picture

Title: Drupal 8 Port » Drupal 8 Port Beta Release Plan
deviantintegral’s picture

We've been doing a ton of D8 work over at https://www.drupal.org/project/flysystem and https://www.drupal.org/project/flysystem_s3, if anyone is interested. It'd be good to not split efforts if we don't have to.

coredumperror’s picture

Does Flysystem support the generation of a metadata cache? The big win that S3FS provides is that it caches the metadata for every file in your bucket, so that an S3 call need not be made for simple existence checks, filesize tests, and the like. Drupal is *full* of these, because it assumes that they're essentially instant, which is very much untrue for remote filesystems. If Flysystem doesn't do that, the performance characteristics will likely be inferior.

deviantintegral’s picture

It does, along with pretty extensive tests. The discussion is over at #2713657: Flysystem cache uses a single key for all metadata per scheme. We've also done some preliminary investigation in SNS support at #2779231: Support Amazon SNS for object notifications, which would let us populate the cache even if other clients change objects, and aggressively cache exists checks that return FALSE.

coredumperror’s picture

Neat! Sounds like a pretty solid remote filesystem solution.

jeremdow’s picture

Is there any major advantage / disadvantage to depending on the PHP League's Flysystem libraries over the official AWS SDK?

https://github.com/thephpleague/flysystem
https://github.com/aws/aws-sdk-php

jansete’s picture

Version: 8.x-2.x-dev » 8.x-3.x-dev
jansete’s picture

Status: Active » Closed (duplicate)