Follow-up to #2568589: Drupal 8 Port Beta Release Plan
Improve Readme.txt file

CommentFileSizeAuthor
#12 improve_readme_file-2756413-12.patch21.67 KBnaveenvalecha
#11 improve_readme_file-2756413-11.patch21.58 KBSumit Gawde
#10 improve_readme_file-2756413-10.patch21.57 KBSumit Gawde
#7 improve_readme_file-2756413-7.patch22.3 KBSumit Gawde
#5 improve_readme_file-2756413-5.patch22.3 KBSumit Gawde
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Version: 7.x-2.x-dev » 8.x-2.x-dev
webankit’s picture

webankit CreditAttribution: webankit as a volunteer and at Valuebound for ZEBRADOG commented
Title: Improve Readme.txt file » Improve Readme.txt file and Module Description for Drupal-8
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Title: Improve Readme.txt file and Module Description for Drupal-8 » Improve Readme.txt file
Sumit Gawde’s picture

Sumit Gawde CreditAttribution: Sumit Gawde at Intelliswift commented
FileSize
improve_readme_file-2756413-5.patch22.3 KB

Hi naveenvalecha,

Patch attached for README file following drupal standards.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Status: Active » Needs work 
+++ b/README.txt
-- Your PHP must be configured with "allow_url_fopen = On" in your php.ini file.
\ No newline at end of file

Add new line at EOF.

Thanks for the patch Sumit, well we need to rewrite the readme.txt for drupal 8. can you re-verify that all the instructions are correct for drupal 8

Sumit Gawde’s picture

Sumit Gawde CreditAttribution: Sumit Gawde at Intelliswift commented
FileSize
improve_readme_file-2756413-7.patch22.3 KB

Hi naveenvalecha,

Please check now.

Sumit Gawde’s picture

Sumit Gawde CreditAttribution: Sumit Gawde at Intelliswift commented
Status: Needs work » Needs review
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Status: Needs review » Needs work 
  1. +++ b/README.txt
-- Your PHP must be configured with "allow_url_fopen = On" in your php.ini file.
+  * Libraries API 2.x - https://drupal.org/project/libraries

    Module is nto dependent on libraries anymore. 

  2. +++ b/README.txt
-- Your PHP must be configured with "allow_url_fopen = On" in your php.ini file.
+  * PHP 5.3.3+ is required. The AWS SDK will not work on earlier versions.

    5.3.3, drupal 8 core requires more than that. So this line is not needed anymore. 

  3. +++ b/README.txt
-- Your PHP must be configured with "allow_url_fopen = On" in your php.ini file.
+  * Install Libraries version 2.x from http://drupal.org/project/libraries.

    not needed as mentioned above. 

  4. +++ b/README.txt
-- Your PHP must be configured with "allow_url_fopen = On" in your php.ini file.
+    sites/all/libraries/awssdk2 folder such that the path to aws-autoloader.php is

    correct libraries path. library is being downloaded/installed using composer 

  5. +++ b/README.txt
-- Your PHP must be configured with "allow_url_fopen = On" in your php.ini file.
+  ¶

    remove extra space. 

  6. +++ b/README.txt
-- Your PHP must be configured with "allow_url_fopen = On" in your php.ini file.
\ No newline at end of file

    Add new line at End of file.

Sumit Gawde’s picture

Sumit Gawde CreditAttribution: Sumit Gawde at Intelliswift commented
Status: Needs work » Needs review
FileSize
improve_readme_file-2756413-10.patch21.57 KB
Sumit Gawde’s picture

Sumit Gawde CreditAttribution: Sumit Gawde at Intelliswift commented
FileSize
improve_readme_file-2756413-11.patch21.58 KB

Hi,

Please find latest patch.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Status: Needs review » Reviewed & tested by the community
FileSize
improve_readme_file-2756413-12.patch21.67 KB

Thanks for initial patch.
Added abhishek anand also as current maintainer.
looks good to me as of now. we will improve it later as we will push the more features.

abhishek-anand’s picture

abhishek-anand CreditAttribution: abhishek-anand at Acquia commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.