[D7] Views Filebrowser

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxfabianvdbor2563313git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

Module looks good. Great work. I found few suggestions with manual review. please check it.

Automated Review

Pareview.sh shows some CodeSniffer errors :

Not a blocker but nice to have it all linted and clean to meet coding standards. Please check coding standards

    FILE: .../pareview_temp/views/views_handler_field_file_filebrowser_preview.inc
    ---------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 1 LINE
    ---------------------------------------------------------------------------
    13 | ERROR | Class name must begin with a capital letter
    13 | ERROR | Class name must use UpperCamel naming without underscores
    ---------------------------------------------------------------------------

    FILE: /var/www/drupal-7-pareview/pareview_temp/views_filebrowser.module
    ---------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ---------------------------------------------------------------------------
    467 | WARNING | Do not concatenate strings to translatable strings, they
    | | should be part of the t() argument and you should use
    | | placeholders
    ---------------------------------------------------------------------------

Manual Review

Individual user account

[Yes: Follows ] the guidelines for individual user accounts.

No duplication

No duplication found.

Master Branch

[Yes: Follows ] the guidelines for master branch.

Licensing

[Yes: Follows / No: Does not follow] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements. / No: List of security issues identified.]

Coding style & Drupal API usage

1. Just a recommendation

views_filebrowser.module : Line no (549)
1. In theme_views_filebrowser_file_icon() function you can theme_image($variables) to create image rather than <img> tag.

This review uses the Project Application Review Template.

Thanks,
Ashish

Looks great! 1+

Hi fabianvdbor,

please fix it.

Automated Review

Review of the 7.x-1.x branch (commit 10f4669):

• ESLint has found some issues with your code (please check the JavaScript coding standards).

modules/views_filebrowser_ckeditor/ckeditor_plugins/views_filebrowser_ckeditor/plugin.js: line 14, col 24, Error - Unexpected space before function parentheses. (space-before-function-paren) 
modules/views_filebrowser_ckeditor/ckeditor_plugins/views_filebrowser_ckeditor/plugin.js: line 78, col 5, Error - Split 'var' declarations into multiple statements. (one-var) 
modules/views_filebrowser_ckeditor/ckeditor_plugins/views_filebrowser_ckeditor/plugin.js: line 78, col 18, Error - fileInput is defined but never used (no-unused-vars) 
modules/views_filebrowser_ckeditor/ckeditor_plugins/views_filebrowser_ckeditor/plugin.js: line 80, col 38, Error - Missing whitespace after semicolon. (semi-spacing) 
modules/views_filebrowser_ckeditor/ckeditor_plugins/views_filebrowser_ckeditor/plugin.js: line 107, col 5, Error - Split 'var' declarations into multiple statements. (one-var) 
modules/views_filebrowser_ckeditor/ckeditor_plugins/views_filebrowser_ckeditor/plugin.js: line 128, col 7, Error - "updateTargetElement" is not defined. (no-undef) 
modules/views_filebrowser_ckeditor/ckeditor_plugins/views_filebrowser_ckeditor/plugin.js: line 144, col 5, Error - Split 'var' declarations into multiple statements. (one-var) 
modules/views_filebrowser_ckeditor/ckeditor_plugins/views_filebrowser_ckeditor/plugin.js: line 152, col 29, Error - "isConfigured" is not defined. (no-undef)

8 problems 

  FILE: ...w/drupal-7-pareview/pareview_temp/views_filebrowser.views_default.inc 
--------------------------------------------------------------------------- 
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE 
--------------------------------------------------------------------------- 
 339 | WARNING | Unused variable $translatables. 
---------------------------------------------------------------------------  
  FILE: /var/www/drupal-7-pareview/pareview_temp/views_filebrowser.module 
--------------------------------------------------------------------------- 
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES 
--------------------------------------------------------------------------- 
 382 | WARNING | Do not use the raw $form_state['input'], use 
     |         | $form_state['values'] instead where possible 
 440 | WARNING | Do not use the raw $form_state['input'], use 
     |         | $form_state['values'] instead where possible 
---------------------------------------------------------------------------  

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

These minor coding style issues should not prevent this nice module to be promoted to a full project. Can anyone please move this project further?

+1 looks alright

Thanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues (here you get to ask fans of your project to help you!)

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.