[D7] Comment Bulk actions

Your git command is not working please uncheck the maintainer checkbox in version control tab and then click on show button
: :- you find the right git command

For reference see the attached screenshot

Automated Review

issues found in pareview, need to be fix.

http://pareview.sh/pareview/httpgitdrupalorgsandboxtusharbodke2551319git

Manual Review

Coding style

Line no: 97 when using node_load its affecting the site performance[its fetching all the node informations]. so if you want node title field, write query for that.

You should also really have a hook_help() with some basic info about the module.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Tushar,

I installed, tested and ran through your code. Everything looks great! This can be used for all nodes migrated from other platform to drupal, where we have comments active/disabled/hidden.

Was looking for this functionality for my previous project.

Reports

Online Automated testing report
http://pareview.sh/pareview/httpgitdrupalorgsandboxtusharbodke2551319git

Code is clean.

Manual review result:
Individual user account
Yes
No duplication
Yes
Master Branch
Yes
Licensing
Yes
3rd party assets/code
Yes
README.txt/README.md
Yes
Code long/complex enough for review
Yes : Code is long enough for review.
Secure code
Yes : Looks secured
Coding style & Drupal API usage
Yes : Looks good and follows drupal coding standards.

Thanks for your contribution.

Hi Tushar,
Thank you for submitting this application. Quite small yet nifty module!

I found a similar module, https://www.drupal.org/project/bulk_apply_comment_settings , which does that same thing. It has no releases, but the git repo contains code that works. That code however, appears to handle loads of nodes efficiently by splitting it to smaller chunks.

- While enabling the module, the module was downloaded to comment_bulk_actions, but the module's name is comment_bulk_action. Please rename the folder name to remove the trailing "s" to prevent confusions.

- In comment_bulk_action_update_node_comment_configuration(), its second argument seems to be the comment enabled status. But the batch process does not send the user-submitted value to that function.

array(
          $nid,
          t('(Operation @operation)', array('@operation' => $operation_count++)),
        ),

See the second array key above.

- Unset $_SESSION['http_request_count'] in the finished

Hi tusharbodke,

Thanks for your contribution,
when we click on help link , I did not see any text after click on help.
As you Implements hook_help().

function comment_bulk_action_help($path, $arg) {
  $help = NULL;
  switch ($path) {
    case "admin/help#comment_bulk_actions":
      $help = t("This module provide option on content type edit form,
      under comment section,
      where Administrator can run batch to apply
      new comment configuration for existing nodes if required.");
      break;
  }
  return "<p> {$help} </p>";
}

Automated Review

Pareview.sh does not show any errors - http://pareview.sh/pareview/httpgitdrupalorgsandboxtusharbodke2551319git

Coder modules does not show any errors.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes : Follows guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. This project name does not match with the modules name. Just like #11 mention. You should either rename your project name without the S or add S to your entire project.
2. You hook_help nor you README.txt have any information on how to use this module. I spend like 15 mins trying to figure out how to use it and I couldn't until I read the summary description in this issue. You should add the same instructions that you have on you summrary description (How to use) and provide that information on hook_help and README.txt.
3. In your project page, you should move the project pictures from attached files into Images field. This will display the pictures in the project page.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

I think the only blocker is lack of documentation. Add the documentation on "How to use" in the README.txt, hook_help and if you can on the project page. The module works like charm but if there instruction how to use it can be useless.

Thanks for your contribution, as i tested this module and it is working fine for me. However i think the help content

/**
 * Where?
 *
 *  Alter NODE TYPE EDIT form,
 * Where admin can select to apply comment configuration.
 *
 *  How?
 * 1) Implement batch to load and save node with new comment configuration.
 */

which you mentioned at the top inside .module file should be removed because you already had this content inside hook_help() and readme.txt to avoid the repetition.

Automated Review

No error found in automated review: http://pareview.sh/pareview/httpgitdrupalorgsandboxtusharbodke2551319git

Manual Review

Individual user account

[Yes] Follows the guidelines for individual user accounts.

No duplication

[Yes] Does not cause module duplication and/or fragmentation.

Master Branch

[Yes] Follows the guidelines for master branch.

Licensing

[Yes] Follows the licensing requirements.

README.txt/README.md

[Yes] follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes] Follows the guidelines for project length and complexity.

Secure code

[Yes] Meets the security requirements. / No: List of security issues identified.]

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
All looks good to me, however some observations mentioned below:

1. +You declared variable $chunk_size = 5;, why it was supposed to have value as '5' or it might be defined at the Top as constant variable.
2. +Instead of using db_query("SELECT nid FROM {node} WHERE type = :node_type ORDER BY node.nid ASC", array(':node_type' => $node_type))->fetchAllAssoc("nid"); it might be used pdo based query e.g. db_select()->condition->fetchAllAssoc.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
FILE: /var/www/drupal-7-pareview/pareview_temp/comment_bulk_action.module
---------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------
5 | ERROR | There must be exactly one blank line after the file comment
8 | WARNING | All constants defined by a module must be prefixed with the
| | module's name, expected "COMMENT_BULK_ACTION_CHUNK_SIZE"
| | but found "CHUNK_SIZE"

Hi Tushar,

I have tested your module again and it works fine. Looked on coding standards for you module and found 1 sniff, so fixed that with some changes on help comments.
Hope this will help developers to debug the exact functionality of this module.

Created patch for this comment_bulk_action-coding_standard_and_help_comments-2554401-32.patch

FILE: ...sites/all/modules/comment_bulk_action/comment_bulk_action.module
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 5 | ERROR | [x] Doc comment short description must be on the first
   |       |     line
 6 | ERROR | [ ] There must be exactly one blank line after the file
   |       |     comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Automated Review

All good here.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. comment_bulk_action.module: line 138-143, seems to be missing indentation

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Other than the 1 minor issue, its looking good!

Individual User Account?
Yes: Follows the guidelines for an individual user account.
No duplication?
No: I don’t see a published module that does this exact thing.
Master Branch?
Yes: Master branch is set.
Licensing?
Licensing looks correct.
3rd party assets/code?
No, I don’t see any 3rd pary assets or code.
README.txt/README.md?
README.txt is present.
Code long/complex enough for review?
Yes, follows the guidelines for project length and complexity.
Secure code?
Everything looks like it’s being run through sanitation and
Coding style & Drupal API usage? The general coding style looks good and syntax looks great.

Recommendation: Line 74 where the progress_message is being assigned a value in comment_bulk_action.module looks like it has replacement tokens, but no values are being passed in (@current, @total).

I tested the module out and it worked for me, I could definitely see myself using this. Very convenient.

Marking as Reviewed & Tested by the Community

Thanks for your contribution, Tushar!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.