[D7] Autofill Forms

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,
I have tested the module.
It worked perfectly for input fields.
But radio and checkbox buttons always set only one and the same value. Shouldn't this be random values?
It failed to autofill textareas.

Note: Readme file and the settings page have spelling mistakes.

Automated Review

pareview.sh : passed

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Pending Review

Secure code

Pending Review

Coding style & Drupal API usage

Pending Review

This review uses the Project Application Review Template.

Automated Review

FILE: /Users/yhessels/Documents/Drupal/autofill_forms/autofill_forms.module
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 115 | ERROR | Line indented incorrectly; expected 12 spaces, found 14
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------

[Finished in 0.2s with exit code 1]

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. Sometimes you use:

   else {
     if () {
   

   instead of

   elseif () {
   

   in autofill_forms.module at lines 154, 143, 165, 188, ...

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Hi,

I installed and tried this module. I enable auto fill feature for Basic page content type, Please see my observation below.

1. I gave a custom value for Textarea field in Form Field Setting. But it still showing random text in form body field.
2. Form field settings is little bit confusing. Is that the default value for the fields or is that the length of the default values? It is not working as expected.
3. Default value functionality is already comes with drupal core.

Thanks,
ARUN AK

I had installed your module and went through the functionality. I found:

• Fields which are available in field collection are not populated with default values
• Basically as mentioned by Arun AK default checkbox value selection is drupal core functionality. Checkbox is selected randomly, if i don't configure default value.
• Taxonomy list selection is also random.
• What functionality you want to implement here. Why random selection is needed? What is business need? Editor will get confused if he has to create huge content, as options are getting selected randomly which might cause data entry errors.

Drupal core provides option to store default values for each field type in content type definition itself. I think one more module load might affect performance.
Also can you please mention how this module will be benefited to developers/editors.

Hi,
@sheetal.nepte:
I find this module useful for testing purposes.

As developer, many times we are faced to try displays, views,.. with different combination of data. And this module make it easy to save random content for selected content types.

One thing is the default value of the field, and another the automatic autofill value of the field.

And autofill can be enable/disable by content type anytime (i.e. start/end of testing).

@Sudhakar:
*I think that fields that have a parent, as field_collections, multifield, profile2,.. should be filled automatically as well. But maybe you are planing to do this later on as an improvement.

*A nice to have would be more than one size of text length for textareas and input fields. So the auto-generated content can have randomly text size as well. Same as previous point this is only a suggestion and can be a future improvement.

'Devel generate' module has the options to generate Generate dummy users, nodes, and taxonomy terms.
Specific content types and so on can be selected.

Could you le me know the main difference or final use between 'Devel Generate' and your module?

Hi Sudhakar,

I have checked the module and got some checklist.

1. Getting two messages after enable the module.
autofill_forms was enabled successfully. [ok]
Your Module has been successfully installed.

2. I am getting some warning in add content form(see attachments authofield.png).

3. i did set FORM FIELD SETTING section (see attachment autofield_config.png) according to instruction but i did not get the actual result(see attachment autofield_sec.png), it should content only 4 words(May be i am clear about the functionality).

Hi Sudhakar,

I reviewed your module and found following issues :

1)

2) Ideally your module file permissions should be -rw-rw-r-- some of your files have permissions -rwxrwxr-x.

3) I think

 foreach (node_type_get_names() as $type_name => $node_type_name) {
    $form['autofill']['permissions']['autofill_forms_using_form_type_' . $type_name . '_node_form'] = array(
      '#type' => 'checkbox',
      '#title' => $node_type_name,
      '#default_value' => variable_get('autofill_forms_using_form_type_' . $type_name . '_node_form') != NULL ? 1 : 0,
    );
  }

in your autofill_forms_configure.admin.inc can be optimized.

Removing review bonus tag, you have not done all manual reviews, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.

@Sudhakar, priority is given to applications with a bonus review tag.

@Sudhakar

1. I noticed that you haven't changed the file permissions yet some files still have -rwxrwxr-x permissions.

2. I haven't went into the details for what purpose you have used below code for content types check in admin configuration :

foreach (node_type_get_names() as $type_name => $node_type_name) {
    $form['autofill']['permissions']['autofill_forms_using_form_type_' . $type_name . '_node_form'] = array(
      '#type' => 'checkbox',
      '#title' => $node_type_name,
      '#default_value' => variable_get('autofill_forms_using_form_type_' . $type_name . '_node_form') != NULL ? 1 : 0,
    );
  }

but if in case you have used it just to get the content types and check/uncheck them instead of loop through the node_type_get_names() ,you can use like :

$form['autofill']['permissions']['autofill_forms_node_types'] = array(
    '#type' => 'checkboxes',
    '#title' => t('your title'),
    '#description' => t('Your description'),
    '#default_value'  => variable_get('autofill_forms_node_types', array()),
    '#options' => node_type_get_names()
   );

manual review:

1. project page: what is the purpose of this module? Why would I need to fill all form fields, why are default values not enough? Please describe an example use case.
2. Please describe the differences to devel_generate and other modules that do similar things on the project page

But otherwise looks good to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to Ayesh as he might have time to take a final look at this.

Hi Sudhakaran,
Thanks for submitting this, and the contributions to this module.

Agreeing with Klausi, I do not see the exact distinction of this module, specially because this works only for node forms (where we have Devel module completely automating the entire node creation). I do understand that this module fills the forms for the user, instead of automating everything. This would be a great tool for demo sites, for example.

A few suggestions, but I think it would be great if you could reply to Klausi's replies first.

- In the settings form, instead of creating a bool variable for each node type, consider adding a select list with multiple options. This would leave the variable table much less complicated, and the uninstallation would be faster too.

- In the subject of uninstallation, you can use db_like in a delete query too, instead of a loop that can be a performance hit.

- Form API types are used almost everywhere, and will require a severe operation across all contribs and core to change. I don't see any immediate benefits of using constants for form API types. You can just use the string literals in the switch statement in the function that generates the values, and have a few less constants in the memory.

- check_plain() is not required for string literals that are not use input. In the admin.inc, see line 37. That check_plain call is not really necessary, because that is already provided by the module. Node type labels' check_plain makes perfect sense though.

The Git commits are not connected to your user account. You need to specify an email address. See https://www.drupal.org/node/1022156 and https://www.drupal.org/node/1051722

But otherwise there were no blocking exceptions for more than a week, so ...

Thanks for your contribution, Sudhakar Dhanapalan - Drupal Geeks!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.