Follow-up to #2247291: Reorder tabs in configuration UI

Problem/Motivation

The Configuration synchronization UI displays the message "There are no configuration changes to import." both when there is no staged configuration, and when the staged configuration is identical to the active configuration. It should be possible to distinguish between these scenarios via the user interface.

Proposed resolution

Display different text for each circumstance.

Remaining tasks

Determine text to dispay in each circumstance.

User interface changes

As proposed resolution.

API changes

None.

Data model changes

None.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because we're only adjusting UI text
Issue priority Normal because the current text is correct but not as helpful as it could be.
Unfrozen changes Unfrozen because it only changes UI strings
Disruption None and no upgrade path needed.
Files: 
CommentFileSizeAuthor
#11 configuration-2540794-10.patch8.9 KBEli-T
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 114,001 pass(es). View
#10 configuration-2540794-9.patch8.91 KBEli-T
#5 configuration-2540794-5.patch8.92 KBcilefen
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 99,016 pass(es). View
#2 configuration-2540794-2.patch765 bytescilefen
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] 98,975 pass(es), 9 fail(s), and 0 exception(s). View

Comments

Eli-T’s picture

Issue summary: View changes
cilefen’s picture

Status: Active » Needs review
FileSize
765 bytes
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] 98,975 pass(es), 9 fail(s), and 0 exception(s). View

Something like this should do, depending on wording. I think this will break a test.

cilefen’s picture

+++ b/core/modules/config/src/Form/ConfigSync.php
@@ -190,7 +190,7 @@ public function buildForm(array $form, FormStateInterface $form_state) {
+        '#empty' => empty($source_list) ? $this->t('There are no staged configurations.') : $this->t('There staged configuration is identical to the active configuration.'),

Mistyped: It should be "The staged configuration..."

cilefen’s picture

Title: Configuration synchronization UI doesn't distinguish between no staged configuration, and staged configuration that matches active. » Configuration synchronization UI does not distinguish between an empty staged configuration, and staged configuration that matches active.
cilefen’s picture

FileSize
8.92 KB
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 99,016 pass(es). View

The last submitted patch, 2: configuration-2540794-2.patch, failed testing.

alexpott’s picture

Issue summary: View changes

Added beta evaluation

Eli-T’s picture

Status: Needs review » Needs work
+++ b/core/modules/config/src/Form/ConfigSync.php
@@ -190,7 +190,7 @@ public function buildForm(array $form, FormStateInterface $form_state) {
+        '#empty' => empty($source_list) ? $this->t('There are no staged configurations.') : $this->t('The staged configuration is identical to the active configuration.'),

I don't think we should refer to "configurations" as a plural.

"There is no staged configuration" would be better.

Eli-T’s picture

Issue tags: +Needs reroll
Eli-T’s picture

Reroll against latest HEAD

Eli-T’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
8.9 KB
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 114,001 pass(es). View

Implemented suggestion in #8

yoroy’s picture

1. This is a good idea
2. The strings look good to me.

tkoleary’s picture

xjm’s picture

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.