Follow-up to #2247291: Reorder tabs in configuration UI

Problem/Motivation

The Configuration synchronization UI displays the message "There are no configuration changes to import." both when there is no staged configuration, and when the staged configuration is identical to the active configuration. It should be possible to distinguish between these scenarios via the user interface.

Proposed resolution

Display different text for each circumstance.

Remaining tasks

Determine text to dispay in each circumstance.

User interface changes

As proposed resolution.

API changes

None.

Data model changes

None.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because we're only adjusting UI text
Issue priority Normal because the current text is correct but not as helpful as it could be.
Unfrozen changes Unfrozen because it only changes UI strings
Disruption None and no upgrade path needed.
CommentFileSizeAuthor
#28 2540794-28.patch8.62 KBkarishmaamin
#11 configuration-2540794-10.patch8.9 KBEli-T
#10 configuration-2540794-9.patch8.91 KBEli-T
#5 configuration-2540794-5.patch8.92 KBcilefen
#2 configuration-2540794-2.patch765 bytescilefen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T commented
Issue summary: View changes
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Active » Needs review
FileSize
configuration-2540794-2.patch765 bytes

Something like this should do, depending on wording. I think this will break a test.

cilefen’s picture

cilefen CreditAttribution: cilefen commented 
+++ b/core/modules/config/src/Form/ConfigSync.php
@@ -190,7 +190,7 @@ public function buildForm(array $form, FormStateInterface $form_state) {
+        '#empty' => empty($source_list) ? $this->t('There are no staged configurations.') : $this->t('There staged configuration is identical to the active configuration.'),

Mistyped: It should be "The staged configuration..."

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Title: Configuration synchronization UI doesn't distinguish between no staged configuration, and staged configuration that matches active. » Configuration synchronization UI does not distinguish between an empty staged configuration, and staged configuration that matches active.
cilefen’s picture

cilefen CreditAttribution: cilefen commented
FileSize
configuration-2540794-5.patch8.92 KB

The last submitted patch, 2: configuration-2540794-2.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Issue summary: View changes

Added beta evaluation

Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T commented
Status: Needs review » Needs work 
+++ b/core/modules/config/src/Form/ConfigSync.php
@@ -190,7 +190,7 @@ public function buildForm(array $form, FormStateInterface $form_state) {
+        '#empty' => empty($source_list) ? $this->t('There are no staged configurations.') : $this->t('The staged configuration is identical to the active configuration.'),

I don't think we should refer to "configurations" as a plural.

"There is no staged configuration" would be better.

Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T commented
Issue tags: +Needs reroll
Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T commented
FileSize
configuration-2540794-9.patch8.91 KB

Reroll against latest HEAD

Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
configuration-2540794-10.patch8.9 KB

Implemented suggestion in #8

yoroy’s picture

yoroy CreditAttribution: yoroy at Wunder commented

1. This is a good idea
2. The strings look good to me.

tkoleary’s picture

tkoleary CreditAttribution: tkoleary at Acquia commented

Added to config management usability meta #2642404: [meta] Usability improvements to configuration management post 8.0

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Parent issue: » #2642404: [meta] Usability improvements to configuration management post 8.0

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams at Nerdery for Nestle Purina PetCare - United States commented

I know I'm jumping into this issue several years after a review is request, better late than never? I've added a test of the change in #11 for Drupal 9 and php 8.1 to see where we stand.

At first glance (without manual testing) the strings look good to me.

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams at Nerdery for Nestle Purina PetCare - United States commented
Issue tags: +Needs reroll

Tests for D9 failed. Needs reroll

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams at Nerdery for Nestle Purina PetCare - United States commented
Status: Needs review » Needs work
karishmaamin’s picture

karishmaamin CreditAttribution: karishmaamin at Specbee commented
Status: Needs work » Needs review
FileSize
2540794-28.patch8.62 KB

Re-rolled against 9.4.x. Please review

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams at Nerdery for Nestle Purina PetCare - United States commented
Status: Needs review » Reviewed & tested by the community

Looks good

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Version: 9.3.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs reroll

Committed and pushed 7493e88678 to 10.0.x and 9076657dcf to 9.4.x. Thanks!

  • alexpott committed 7493e88 on 10.0.x 
    Issue #2540794 by Eli-T, cilefen, karishmaamin, cosmicdreams, yoroy:...

  • alexpott committed 9076657 on 9.4.x 
    Issue #2540794 by Eli-T, cilefen, karishmaamin, cosmicdreams, yoroy:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.