This module creates a content type called immoclient. Immoclient is built after the official German "openimmo" xml-standard to create real estates.
This is used in German speaking countries (Germany, Austria, Swiss).

What this module does:
It creates about 300 fields per click and gives a easy to use UI to manage real estates, used by real-estate agents in German speaking countries.

You only need to enable "immoclient", there are a lot of dependencies which are called then. Easiest way is to use drush. After that you have to build your views, because of the huge amount of fields, and some of them are only for the agencies itself, there is no way to show these nodes any clients.

First you should have a drupal with German language as default then install this module. I hope that you have activated clean urls.

Then follow these steps, the order of these steps makes it easier to use:

  1. Configure entity translation (admin/config/regional/entity_translation):
    Be sure to activate all submodules.
  2. Configure the language (admin/config/regional/language/configure) as follows: this gives the best result in my opinion:
    URL, USER, SESSION
  3. You should replace the title with the title module(de/admin/structure/types/manage/immoclient/fields)
  4. Configure gmap (de/admin/config/services/gmap)
  5. Configure location (de/admin/config/content/location)
  6. Create your impressum (admin/de/impressum), there are a lot of fields that are demanded by openimmo.xml.
  7. Create at least one contact. Salutation,name and telefone should be enough!

Now you can build your first object!

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/maen/2469709.git immoclient
cd immoclient

Manual reviews of other projects:

Background image formatter
BotScout
Xing Connect

If I should fall back to "needs work", here are some other projects too!

smssync
search_replace...
simple_adsense.

Comments

sagesolutions’s picture

sagesolutions commented
Status: Needs review » Needs work

Automated Review

There are multiple issues in the automated review - check http://pareview.sh/pareview/httpgitdrupalorgsandboxmaen2469709git for details

maen’s picture

maen commented

Hello sagesolutions,

could you help me please solving my issues.

1. Problem:
The main module is "immoclient". So the name of the other 11 submodules in "contrib" starts with immo. Because each submodule creates an entity and entities can't have a "_" in their machine names I can't use this convention.

2. Problem:
I don't know how to move my translation to localize.drupal.org!? I am now a member of the German team, but the import fails. Perhaps because there is no project immoclient and for the submodules???

THX in advance,

Marc

maen’s picture

maen commented
Status: Needs work » Needs review

There is no common way to create a module with 11 submodules, each containing an entity. The naming conventions therefore are always clashing!
Also it is a German tool, so the translation has to be there. Localize.drupal.org accepts only modules, not even in the dev status. So in my mind there is no other way than having de po file in the translation file into the project. When the project is accepted I can import this po file.

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

ravi.khetri’s picture

ravi.khetri commented

Hi,

1. Remove unused comment line form module file.
line 30 to 32.

2. Use css folder for place css file separate.

maen’s picture

maen commented

Thx ravi, done and done!

saurabh.tripathi.cs’s picture

saurabh.tripathi.cs commented

Hi ,
Found below points which may need correction:
1)Unused Commented code: line 91 to 95.
2)t() missing from form_set_error :
line 68,78

if ($count_int > 1) {
      form_set_error('field_objektnr_intern', 'Unique "object number intern" is already used.');
    }

3)Comment for form_alter missing in line 202.
4)Implement hook_help() to make users understand your module better.

maen’s picture

maen commented

Thx saurabh,

all 4 points are done!

babusaheb.vikas’s picture

babusaheb.vikas commented

Hi maen,

1. Correct hook comment is: Implements hook_HOOK().. So, go through your *.module file and change it.
2. It would be good if you create a js folder and put your js files in it.
3. Add one empty line at the end of your *.module and *.install file.

maen’s picture

maen commented

Ok, thx babusaheb, everything made.

Although I added this line, I don't know what's the sense??? Could you explain please?

maen’s picture

maen commented
Issue summary: View changes
maen’s picture

maen commented
Issue summary: View changes
babusaheb.vikas’s picture

babusaheb.vikas commented

Hi maen,

take up index.php file that comes with drupal 7, it has 21 lines of code but it actually has 22 lines (the extra one blank line. The same goes with update.php. The best way to identify and understand the coding standards is to open up the drupal core and compare it.

Also, take a look on Coding standards
https://www.drupal.org/node/318#indenting

maen’s picture

maen commented
Issue summary: View changes
Issue tags: +PAreview: review bonus
maen’s picture

maen commented
Issue summary: View changes
maen’s picture

maen commented
Issue summary: View changes
fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community

Great project! Reviewed the code for obvious security problems and found none, code standards are generally followed.

=> RTBC

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.