Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Dec 2014 at 10:47 UTC
Updated:
20 Jul 2019 at 13:49 UTC
Jump to comment: Most recent
Comments
Comment #1
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxarthurbuliva2393087git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
arthurbuliva commentedComment #4
sajiniantony commentedHello,
the Readme.txt file provided is empty.
Comment #5
arthurbuliva commentedI have updated the Readme file
Comment #6
svnindia commentedHi,
Manual
Unable to install the module to test the functionality.
PAReview
Some code style issues found...
Comment #7
svnindia commentedComment #8
arthurbuliva commentedI have fixed the code style issues on the Readme file.
Regarding the error you have shown, I don't think it is genuinely from the module since the last line of my file is line 488
Comment #9
valentine94It appears you are working in the "master" branch in git. You should really be working in a version specific branch.(from pareview.sh)
Comment #10
klausiThe git branch name should be fixed but is not an application blocker. Anything else that you found or should this be RTBC instead?
Comment #11
arthurbuliva commentedFixed branch name issue
Comment #12
svnindia commentedHi,
line no 42 unused if condition found
line no 36,93,102,154,203,204 t() can be used
unable to install in http://simplytest.me/
Comment #13
arthurbuliva commentedI cannot tell you why this is so. Installation into a clean Drupal 7 instance works OK
Comment #14
svnindia commentedHi,
Could you update the page with "How to configure the url in android app ? & Requirements if any".
Will it work in localhost ?
Comment #15
arthurbuliva commentedWith no further issues, how do I get to now move it from sandbox to a full project please?
Comment #16
maen commentedThe above link for cloning the project is wrong!
Comment #17
babusaheb.vikas commentedHi arthurbuliva,
1) Your project contains both README.txt and README.md file.
Remove any one file among them.
2) Incorrect hook comments in line no. 61 in *.module file. Correct hook comment is: Implements hook_HOOK().
3) Found below error when going to install your module
Parse error: syntax error, unexpected '[', expecting ')' in D:\xampp\htdocs\mysite\sites\all\modules\smssync\smssync.module on line 1114) You should provide the hook_help to allow site builders to find information about your module using Drupal UI.
5) There are lots of coder errors. Install coder module, check your module with coder and fix those errors.
Comment #18
kporras07 commentedChanging status due to last comment.
Comment #19
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #20
ugintl commentedAny activity here?