SMSsync is a simple, yet powerful SMS to HTTP sync utility that turns any Android phone into a local SMS gateway by sending incoming messages(SMS) to a configured URL (web service).

This module makes it easier to enable SMSsync to post the SMS messages into your drupal instance.

Project page

https://www.drupal.org/sandbox/arthurbuliva/2393087

Cloning the project

git clone --branch master http://git.drupal.org/sandbox/arthurbuliva/2393087.git smssync
cd smssync

Comments

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxarthurbuliva2393087git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

arthurbuliva’s picture

Status: Closed (won't fix) » Needs review
sajiniantony’s picture

Status: Needs review » Needs work

Hello,

the Readme.txt file provided is empty.

arthurbuliva’s picture

Status: Needs work » Needs review

I have updated the Readme file

svnindia’s picture

Hi,

Manual

Unable to install the module to test the functionality.

Parse error: syntax error, unexpected '[', expecting ')' in /home/sc6f9431ffee1b43/www/sites/default/modules/2393087/smssync.module on line 495

PAReview

Some code style issues found...

svnindia’s picture

Status: Needs review » Needs work
arthurbuliva’s picture

Status: Needs work » Needs review

I have fixed the code style issues on the Readme file.

Regarding the error you have shown, I don't think it is genuinely from the module since the last line of my file is line 488

valentine94’s picture

Status: Needs review » Needs work

It appears you are working in the "master" branch in git. You should really be working in a version specific branch.(from pareview.sh)

klausi’s picture

Status: Needs work » Needs review

The git branch name should be fixed but is not an application blocker. Anything else that you found or should this be RTBC instead?

arthurbuliva’s picture

Fixed branch name issue

svnindia’s picture

Hi,

line no 42 unused if condition found
line no 36,93,102,154,203,204 t() can be used

unable to install in http://simplytest.me/

arthurbuliva’s picture

unable to install in http://simplytest.me/

I cannot tell you why this is so. Installation into a clean Drupal 7 instance works OK

svnindia’s picture

Hi,
Could you update the page with "How to configure the url in android app ? & Requirements if any".
Will it work in localhost ?

arthurbuliva’s picture

With no further issues, how do I get to now move it from sandbox to a full project please?

maen’s picture

The above link for cloning the project is wrong!

 git clone --branch 7.x http://git.drupal.org/sandbox/arthurbuliva/2393087.git smssync
cd smssync 
babusaheb.vikas’s picture

Hi arthurbuliva,

1) Your project contains both README.txt and README.md file.
Remove any one file among them.

2) Incorrect hook comments in line no. 61 in *.module file. Correct hook comment is: Implements hook_HOOK().

3) Found below error when going to install your module
Parse error: syntax error, unexpected '[', expecting ')' in D:\xampp\htdocs\mysite\sites\all\modules\smssync\smssync.module on line 111

4) You should provide the hook_help to allow site builders to find information about your module using Drupal UI.

5) There are lots of coder errors. Install coder module, check your module with coder and fix those errors.

kporras07’s picture

Status: Needs review » Needs work

Changing status due to last comment.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

ugintl’s picture

Any activity here?