The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Description
This module brings Google AdSense AD units into Drupal as responsive block(s) simplely.
More implementation details see: http://ranqiangjun.com/node/408832 (in Chinese).
How to use it?
- Go to
admin/config/content/simple_adsenseand config. Blow are available real world settings for testing purpose:- Client: ca-pub-9513614146655499
- Slot #1: 5270097160
- Slot #2: 5556618763
- Slot #3: 6746830361
- Slot #4: 8955359568
- Slot #5: 3793363962
- Open
admin/structure/block, you'll see block(s) title like this:- Simple Adsense (3793363962)
- Simple Adsense (5270097160)
- Layout those block(s) as usual.
Roadmap
Support entities, so a field/property named simple_adsense_field can be attached.
Similar projects
Sandbox URL
Project page: http://www.drupal.org/sandbox/qiangjun/2512150
Git Access
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Qiangjun/2512150.git simple_adsense
Automated Review
http://pareview.sh/pareview/httpgitdrupalorgsandboxqiangjun2512150git
Manual reviews of other projects
http://www.drupal.org/node/2506013#comment-10099906
http://www.drupal.org/node/2529072#comment-10097642
http://www.drupal.org/node/2522658#comment-10099894
Screenshots
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | block configuration.png | 212.83 KB | jungle |
| #9 | missing_t.patch | 878 bytes | maen |
| #3 | simple_adsense.png | 22.58 KB | babusaheb.vikas |
Comments
Comment #1
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
jungleComment #3
babusaheb.vikas commented1) All simple_adsense_slot block name looking same i.e simple_adsense_slot @val
Needs to show value rather than variable name.
Take a look on attached screenshot.
2) You should provide the hook_help to allow site builders to find information about your module using Drupal UI.
3) Need to add instructions about your module in README.txt file.
4) In README.txt file, More details see: http://ranqiangjun.com/zh-hans/node/408832
this link is broken(Unable to find the requested page).
Need to correct it.
Comment #4
PA robot commentedProject 1: https://www.drupal.org/node/2468875
Project 2: https://www.drupal.org/node/2532406
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #5
rutel95Hello, what is the difference of your module from it https://www.drupal.org/project/adsense?
Comment #6
jungleComment #7
jungleHello babusaheb.vikas,
I have fixed those you pointed.
Thanks!
Comment #8
jungleHello ruslan_03492,
I'd say simple, lightly and more!
https://www.drupal.org/project/adsense , this project bundled with 7 modules, three of them are tagged old. The adsense_managed submodule, provides similar function, but too much dimension options. In my opinion, we don't need so much blocks. we do need fields and blocks.
Simple Adsense Blocks combined with Simple Adsense Fields/Properties (TBD), we can put Google Ads into anywhere like regions, nodes, custom entities etc.
Thanks!
Comment #9
maen commentedAutomated Review
No pareview errors found
Manual Review
Individual user account
Yes follow the guideline
No duplication
Yes follow the guideline. As explained above, more lightweight and reliant than adsense.
Master Branch
Yes follow the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No, doesn't follow the guideline. But it's self explanatory in my mind!
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements
My tests:
You forgot 2 t functions, see at patch.
Usually at drupal_set_message there comes a check_plain I believe, but because the input is validated before this seems unnecessary here. (simple_adsense.inc, line 134)
I cannot open the block configuration in the overlay on both servers, localhost and openshift, but works without overlay.
Because ads are normally without a title in blocks, why don't you give
'<none>'as default for block titles?That's it from my side! Have luck...
PS: I forgot to mention you need a help function!
Comment #10
jungleHello maen,
Some changes I have made:
1. Applied your patch;
2. Modified the README.txt by using template (https://www.drupal.org/node/2181737), and displayed it under
admin/help;3. Ad Block's title default value goes to
<none>;4.
I updated
simple_adsense_settings_submit()(simple_adsense.inc, line 109), more meaningful submitted message was added.It do work for me, see the screenshot.
Thanks!
Comment #11
g089h515r806 commentedThe code looks nice, and the function works correct.
Comment #12
cweagansThanks for your contribution!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #13
jungle