[D7] Show Node Aliases

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxartemkolotilkin250312...

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello,

You have used hook_form_FORM_ID_alter(). But the comment above of this you have written ( Implements hook_form_alter() ).
It should be Implements hook_form_FORM_ID_alter().

Also in the same function show_node_aliases_form_node_form_alter you have not $form_id as a last arguments.

Thanks

Hello,

You have not used hook ( hook_help ). This hook provide help regarding the module in the admin interface.
So user can see what this module does

Thanks

• It's better to use render array to render table and label (see here)
• In case user doesn't have permission to manage aliases, the third cell will be omitted (but there still be present header column), so it will look bad.
• According the Drupal best practices, it's better to use chaining queries.

Automated Review

Pareview.sh - It show couple errors., http://pareview.sh/pareview/httpgitdrupalorgsandboxartemkolotilkin250312...

Coder Review

Coder complains are the same as the Pareview.sh.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

No: Causes duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

No: Does follows the guidelines for project length and complexity.

Secure code

Yes: Meets security requirements.

Coding style & Drupal API usage

List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. The Redirect module have the same functionality and even more. As we change our project application process in #2453587: [policy, no patch] Changes to the project application review process we are not allowed to block applications base on module duplication. We can still recommend collaboration over competition, but we should not enforce it.
2. This project is too short, would be you be interested on Single Project Promotion?

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

No need to postpone this, if there is not enough code we will do a single project promotion automatically.

Anything else that you found or should this be RTBC instead?

I do not see any blockers.

Review of the 7.x-1.x branch (commit f7dcd39):

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Manual Review :

1. show_node_aliases_help : As the Readme.txt is provided by module itself.So there is no need to sanitize the text of it.Please remove filter_xss_admin and check_plain
2. Ideally hook_help should be at top.So please move the show_node_aliases_help to the top of all functions in file.
3. The module is using path module internally.So add the hard dependency on the path module in .info file.
4. Please add some more details to the project page. https://www.drupal.org/sandbox/artem.kolotilkin/2503121

Duplication : Redirect module provides the similar fucntionality AFAIK,As we are not blocking the issues with duplication anymore.
So RTBC
Assigning to sreynen to give it a final look if he has time.

In hook help, you have this line of code:

case 'admin/help#show_node_alias'

Your module's name is show_node_aliasES, and because of that typo, help links do not appear on modules listing page, nor on help page....

You have the same typo on line 14, in file_get_contents function....

In readme.txt, you should mention that this module requires path module.

Thanks for your contribution!

I have promoted this project from sandbox to full project on your behalf.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.