[D7] Google Plus Feeds

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxravimane232469515git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi ravimane23,

I have had a look and you code seems to work fine however I have a few points below.

Automated Review

You have a few problems showing. http://pareview.sh/pareview/httpgitdrupalorgsandboxravimane232469515git

Manual Review

README.txt/README.md

You would need to include a README.txt file, see this template https://www.drupal.org/node/2181737

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (*) For your created variables you should remove them when someone uninstalls the module. This can be down in a .install file and hook_uninstall().
2. (*) You would need a README.txt
3. It would also be nice if you include a hook_help(). You can you link to your README.txt file once that is complete. See https://www.drupal.org/node/161085#hook_help for how this can be down.
4. You documented well how to get the api key but I was not sure how to get the google account id. It would be good to have a few points that show how to get it.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

Hey,

I have Reviewed your project application and found this module useful. But in the meanwhile, found an error which needs to be work upon.
Also please take care, "Priority should not be set by you."

Automated Review

[Git errors:

Git default branch is not set, see the documentation on setting a default branch.]

Manual Review

Individual user account

Yes Follows the guidelines for individual user accounts.

Identified Issue

1. When no configuration settings are saved after installation and we enable block then that case is not handled by your module. (In .block.inc file Probably Line No. 16, 17 should have been used to handle that case.). Attached is the screenshot of warning produced.

Recommendations for Application Issue

Provide Similar Modules and how your module is different from others.

Hi see this i got following issues in your module google_plus_feed_module.file

60 | WARNING | Variable $settings is undefined.
61 | WARNING | Variable $actions is undefined.
63 | WARNING | Variable $actions is undefined.
65 | WARNING | Variable $settings is undefined.

Please fix this and everything looks great.

Some more errors:
../README.txt
-----------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------
12 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
23 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
87 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------
../google_plus_feeds.module
---------------------------------------------------------------------------
FOUND 39 ERRORS AND 1 WARNING AFFECTING 36 LINES
---------------------------------------------------------------------------
60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3
60 | ERROR | [x] There must be no space before the colon in a CASE
| | statement
61 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5
62 | ERROR | [x] Case breaking statements must be followed by a single
| | blank line
63 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3
63 | ERROR | [x] There must be no space before the colon in a CASE
| | statement
64 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5
64 | WARNING | [ ] Do not pass empty strings to t()
65 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5
66 | ERROR | [x] Case breaking statements must be followed by a single
| | blank line
67 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3
67 | ERROR | [x] There must be no space before the colon in a CASE
| | statement
68 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5
69 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5
70 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7
71 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5
72 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5
73 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7
74 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7
75 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found
| | 9
76 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7
77 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5
78 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5
79 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7
80 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5
81 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5
82 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7
83 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7
84 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7
85 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found
| | 9
86 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7
87 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7
88 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found
| | 9
89 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7
90 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5
91 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5
92 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7
93 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5
94 | ERROR | [x] Case breaking statements must be followed by a single
| | blank line
145 | ERROR | [x] Expected 1 newline at end of file; 2 found

Please solve this..

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Please don't assign the project application issue to yourself if you want other people to review it. Please see this page about assigning ownership to issues.

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows / No: Does not follow] the licensing requirements.

3rd party assets/code

[Yes: Follows ] the guidelines for 3rd party assets/code.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (*)To attached css for block_view in line number 134 of .module file look below example
   $block['content'] = array(
   '#markup' => test(),
   '#attached' => array(
   'css' => array(
   drupal_get_path('module', 'mymodule') . '/css/mymodule.css',
   ),
   'js' => array(
   drupal_get_path('module', 'mymodule') . '/js/mymodule.js',
   ),
   ),
   );
2. (*) $response = drupal_http_request($request_url); in line 54 of google_plus_feeds.block.inc. in that your requesting another url and cheking
   response. if you check the request in try and cache block then url giving any response error then you can easily notify
3. (*)What is used of clearing cache in admin setting form.

@ajayNimbolkar: I think you forgot to change the status. Is this now RTBC after your review or are there application blockers left and this should be "needs work"?

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Bro! Great code ;)

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

• Just a tip, i have a module in the application queue too, and it implements the Google PHP Client Library, meaning that you would have a standarized lib with classes to use alongside with your module and all other Google APIs! Take a look if you wish, and if it gets approved, i think it would be nice for you to consider using it in your module, it seems like another great use case for the Client Library! And would be a pleasure to mention your module in mine's "Related Module" section in the project page ;)

Great Job! Keep up the focus.

Thanks for your contribution, ravimane23!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.