[D7] fieldupdate

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Manual Review

Individual user account

Yes: Follows

No duplication

Yes: Follows

Master Branch

Yes: Follows

Licensing

Yes: Follows

3rd party assets/code

Yes: Follows

README.txt/README.md

No: Does not follow. Please check Read me Template also a hook_help will be much appreciated.

Code long/complex enough for review

No: Does not follow. Please check guidelines for project length

Secure code

Yes: Meets the security requirements

Coding style & Drupal API usage

Yes: Meets drupal standard

This review uses the Project Application Review Template.

Fixing tag.

The readme formatting is surely not an application blocker, anything else that you found or should this be RTBC instead?

@klausi,
I have review this application and yes this should be RTCB. I check the module seem to be working alright. There is any errors using the Coder module and the Pareview.sh.

This is a short project because it only have 4 functions and 95 lines.

@rajesh.vishwakarma,
I would recommend to add the hook_help because is best practice. Also, there is a typo on line 9 from the README.txt it said defalur and should default.

No : Does not follow the guidelines for project length and complexity.

So Added Single Project Promote tag.

Duplication

Is there anything that this module can do that VBO can't?

Removing review bonus tag, you have not done all manual reviews, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2418415

Project 2: https://www.drupal.org/node/2420625

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

manual review:

1. "update comment" is not a good git commit message. See https://www.drupal.org/node/52287
2. fieldupdate_form_field_ui_field_edit_form_alter(): doc block: "hook__form_field_ui_field_edit_form_alter" should be "hook_form_field_ui_field_edit_form_alter".
3. "chack box" should be "check box".
4. _fieldupdate_submit_handler(): so you are hard coding the node entity here? Does that mean that your module only works for fields on nodes? What about other entity types such as users or comments or taxonomy terms? Please add that limitation to the README. You could use entity_get_info() to get the base table name for the entity type.
5. _fieldupdate_update_default_value_process(): why do you call field_attach_update() and not node_save() here? Please add a comment.

But otherwise looks good to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to mpdonadio as he might have time to take a final look at this.

@rajesh.vishwakarma: please add a comment in code where you call field_attach_update() why you don't use node_save() here.

no objections for more than a week, so ...

Thanks for your contribution, rajesh.vishwakarma!

I promoted this project for you: https://www.drupal.org/project/fieldupdate

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.