[D7] Useful Commands Drush

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automatic Review

As I checked http://git.drupal.org/sandbox/aamouri/2321973.git link on http://pareview.sh there are many errors. Check this again by opening
http://pareview.sh/pareview/httpgitdrupalorgsandboxaamouri2321973git link.

Manual Review

Individual user account
OK: Follows the guidelines for individual user accounts.

Multiple applications
OK. No additional applications.

Licensing
OK. Follows the Drupal.org licensing requirements.

3rd party (non-GPL) code
OK. No 3rd party code.

Module duplication
OK. No duplication.

README.txt
No: Specify all command that have implemented.

Code length/complecity
OK. About 400 lines of code .

Coding style & Drupal API usage
No: Coding style is very poor follow coding as coding standards.
Don't use error-suppressing operator @, use if condition instead of this.

@aamouri automatic review issues from parreview.sh are not yet fixed. If you are changing status from needs work to needs review then please add some comment about why you are changing it.

I have found some issues in my manual review.

1. In the file useful_commands_drush.drush.inc

$items['drush-revert-views'] = array(
'callback' => 'useful_commands_drush_revert_views',
'drupal dependencies' => array('views'),
'description' => 'Revert overridden views to their default state. Make sure to backup first.',
'arguments' => array(),
'bootstrap' => DRUSH_BOOTSTRAP_DRUPAL_FULL,
'aliases' => array('drv'),
'examples' => array(
'drush drush-revert-views' => 'Reverts all yo views!',
),
);

You have added a dependency over views module in above script but this is not added into module info file. see this article https://www.drupal.org/node/542202

2. There are some misspelling "Revert all yo views" and "connexion" in module inc file.

3. When i run command "drush drv"...it always shows message "Command drv needs the following module(s) enabled to run: views". Although the "views" module is already enabled. Is this need any specific views module version.?

4. When i run "drush clean-system", it doesn't work and shows a message "Command clean-system needs the following module(s) enabled to run:." . However, in message it does not show module name to enable.

Thanks

@aamori as I checked you have created tow repo for you module, there should be only single repo with name7.x-1.x and code should be committed under this. There is no need to add 7.x-1.x-dev repo, remove this repo.

Hi, aamouri.

Here are some quick issues I was able to find:

1. If your command depends on some other modules, you don't have to add that dependency to info file as it disables all other commands which don't have any dependencies. Just add drupal dependencies option to hook_drush_command.
2. There is no need to maintain this project as Drupal module. Most commonly, custom drush commands are placed in sites/all/drush directory or in ~/.drush directory. Have a look at the Drush Entity project. I suppose it would be a nice example.
3. It seems the commands completely duplicate existing ones.
   • remove-nodes-by-type => delete-all (Delete all)
   • clean-system => clean-modules (Clean missing modules)
   • print-db-setting => sql-conf (Drush)
   • drush-revert-views => views-revert (Views)

   Can you describe how your commands differ from commands listed above?

It's not going to be that easy to find missing Drush commands. Most popular contributed modules provide Drush integration themselves. Notice since Drush has been moved to github it might be better to maintain Drush commands there.
https://github.com/drush-ops/drush/issues/572

Hi aamouri,

You have put lot of efforts to make these module, I really appreciate it and humbly request you to just go throw some of suggestions,

1) This is regarding code written useful_commands_drush_help hook in useful_commands_drush.module file,
here if README.md file does not exist then in that case README.txt file suppose to pick up and display,
but in current given module there is no README.txt. So please add README.txt file with related content or you can remove below code.
else {
$path = dirname(__FILE__) . '/README.txt';
if (file_exists($path)) {
$readme = file_get_contents($path);
}
}

2) This is regarding useful_commands_drush.drush.inc file:
$items['clean-system'] = array(
'callback' => 'useful_commands_drush_clean_system',
'description' => dt('Find and remove enabled modules that do not exist from the database.'),
);
from above code, example and aliases are missing.
'examples' => array('drush clean-system'),
'aliases' => array('cs'),

Thanks,
Rahul.

@aamouri,

• You should add some description on the project page.
• (+)There is not need to have 2 README. I know you probably are doing to support markdown for Github, but pick one and stick with it.
• Coder Warning:
  

  useful_commands_drush.drush.inc
  
  231: in most cases, replace the string function with the drupal_ equivalent string functions
  
        $output .= str_pad('', 5 - strlen($percentage)) . $percentage;
  

• In this issue you should add your git clone and your description.
• Pareview - http://pareview.sh/pareview/httpgitdrupalorgsandboxaamouri2321973git have a warning.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.