Module Description
Light social buttons allows to create a block with the social media buttons, without the iframe or the external javascript.
Is named "light" (instead of "fat") because don't include the 340 kb and over required to render the FB button, the twitter button, etc.
The module use the javascript API from the services to get the number of share. For the Google Plus service is used an internal call with POST parameter.
The module is inspired from this article: http://www.sitepoint.com/social-media-button-links/
Screenshots
Block example:
Statistics example:
Why another social media module
There are a lot of social media modules.
The first reasons to exists of Light social buttons is the views integration.
The complete list is:
Views integration.
The module store the shares and allows to order, for example, your nodes by total shares, with an additional sub-module (ligthsocialbutton_views).
Statistics
The module permit to show the growth of sharing in the time with an additional sub-module (ligthsocialbutton_stats)
Total share
The module allow to show the total share, like Mashable or other web magazines.
Sandbox page
https://www.drupal.org/sandbox/marciuz/2444855
Git command
git clone --branch 7.x-1.x marciuz@git.drupal.org:sandbox/marciuz/2444855.git lightsocialbuttons
Drupal Versions
* Drupal 7
About me
I'm an italian php/db developer with around 18 years of experience. I'm working as freelance for the italian public administration (FormezPA) and the European Commission (DG Connect, DG Enterprise). I'm 41 year old and I'm based in Brussels. I used Drupal from the 4.x version and I've developed a lot of custom modules, but this is the first I submit to drupal.org.
Comment | File | Size | Author |
---|---|---|---|
lightsocialbuttons_img.png | 10.59 KB | marciuz | |
aViscbp.png | 54.18 KB | marciuz |
Comments
Comment #1
marciuz CreditAttribution: marciuz commentedComment #2
Ayesh CreditAttribution: Ayesh commentedCiao! (hope I said Hello correctly in Italian :)
Thanks for this. Pareview shows many issues that you might want to fix first: http://pareview.sh/pareview/httpgitdrupalorgsandboxmarciuz2444855git
- Do you really need a separate table to store the services list? Fields for `lightsocialbuttons` table will make the service list fixed, so a variable_set/get to set/get the data would be more light weight.
- Do not call drupal_add_css in the main .module scope. A hook_page_build would ensure module functionality works even if the page is cached.
- Integrations with other web services usually go to "Web services" menu item in the configuration menu. Not a blocker though.
These are not the all issues I found, but more importantly, there is a very similar module, Social Stats, that does the same features. I think we will need to make the functionality more distinct.
Comment #3
rajesh.vishwakarma CreditAttribution: rajesh.vishwakarma commentedAutomated Review
Your module have some error that reported by the automated system. Those need to fix.
http://pareview.sh/pareview/httpgitdrupalorgsandboxmarciuz2444855git
Manual Review
Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: It has additional integration with views also available statics in our system.
Master Branch
No: Follows the guidelines for master branch.
Clone link should be like:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/marciuz/2444855.git lightsocialbuttons
Licensing
Yes: Yes: Follows the licensing requirements
3rd party assets/code
Yes: Follows the guidelines for 3rd party code.
README.txt/README.md
No: Yes: Follows the guidelines for in-project documentation and the README Template.
Code long/complex enough for review
Yes: Yes: Currently follows the guidelines for project length and complexity. There is a possibility of code reduced once suggested changes will done.
Secure code
Yes: Yes. If "no", list security issues identified.
Coding style & Drupal API usage
1) First fixed coding format as reported by http://pareview.sh/pareview/httpgitdrupalorgsandboxmarciuz2444855git
2) Why "; $Id$" at top on lightsocialbuttons.info file.
3) Don't specify version of module just remove this line.
4) Why two block, I think both are same if no specify in readme
5) don't user arg() function this is good if store this value in variable @at line 149,150. $arg = arg(0) and user $arg.
6) User l() function to create link instead of href.
Readme.Me
Why underscore with "_Drupal module that allow the creation of social media buttons with dynamic counters and Views integration_"
follow https://www.drupal.org/node/2181737 for the read me
Comment #4
rajesh.vishwakarma CreditAttribution: rajesh.vishwakarma commentedComment #5
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.