Duringwe've found that if we add a CSS file to a library with a name that already exists, that CSS never loads. It seems like the core CSS is overriding the theme CSS. This is a big WTF for themers.
We already have created way to override CSS filesbut it has to be changed because its designed to remove a single file. If this functionality is left unchanged people would unintentionally override multiple files which has the same name.
Don't allow to override stylesheets anymore explicitly, so remove support for stylesheets-override in theme info files.
Therefore remove those information from the ActiveTheme object as well
Don't override CSS files that have the same name, let them to live in peace together. Stylesheet-override and stylesheet-remove have to be changed so themers can specify the CSS file they want to remove based on the location of the file:
# Remove a CSS file: stylesheets-remove: - core/node/css/node.css
The location of modules can change. In order to make it more stable we could add a placeholder that includes the location of the module or theme:
# Remove a CSS file: stylesheets-remove: - @node/css/node.css
stylesheets-override will be removed because the way its built doesn't support theme hierarchy. There is follow-up issue to address this API change later:.
Beta phase evaluation
|Issue priority||Critical because an important part of the theme system is not working properly.|
|Disruption||This will be a disruptive change, because we will modify the syntax for stylesheets-remove and stylesheets-override will be removed. This mus be done to fix the critical bug.|
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 91,691 pass(es). View
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 91,622 pass(es). View