Active
Project:
Drupal core
Version:
main
Component:
theme system
Priority:
Major
Category:
Plan
Assigned:
Issue tags:
Reporter:
Created:
18 Apr 2015 at 15:26 UTC
Updated:
8 May 2016 at 16:07 UTC
Jump to comment: Most recent
At the moment we have code without proper test coverage in themes. Without tests its very easy to break things so we should investigate which themes includes testable logic and then create child issues for each theme including testable code so that we will have test coverage also there.
Comments
Comment #1
joelpittetAsset removal may be a test we can get in there, but try to avoid writing checks for specific CSS classes as it would be a pain to make CSS changes as it would get a bit out of hand fast and lots of busy work fixing design decision changes.
@LewisNyman may have discussed this with me in the past, it would be nice to get his opinion on the matter.
Comment #2
davidhernandezI agree that trying to test visual regression would be too much. If needed, we could test all the stuff in .info and .libraries. Make sure all the right assets are being loaded.
Do we consider this a major?
Comment #3
joelpittetThis needs a plan and some child issues or we should close this.
Comment #4
joelpittetComment #6
joelpittet@lauriii could you add a simple test plan to the issue summary? Assigned to you