[D7] Yild PoolParty

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I had a look at the module and both I and the automated report could not find any mentionable problem.
Everything was easy to accomplish and working from the scratch.

I only faced three little bugs during the module usage, but I don't think you have influence on since it seems they are caused by the yild-module. I will still list them here in case I am wrong, or if you want to forward them to the yild-development-team:

• These warnings appeared when I created a taxonomy_term_reference field with the yild autocomplete widget the first time (when I didn't select PoolParty as the provider yet):

      Notice: Undefined index: providers in yild_field_widget_settings_form() (line 105 of /var/www/XXX/sites/all/modules/yild/yild.module).
      Notice: Undefined index: providers in yild_field_widget_form() (line 131 of /var/www/XXX/sites/all/modules/yild/yild.module).
      Warning: Invalid argument supplied for foreach() in yild_field_widget_form() (line 131 of /var/www/XXX/sites/all/modules/yild/yild.module).
      Warning: Invalid argument supplied for foreach() in form_type_checkboxes_value() (line 2337 of /var/www/XXX/includes/form.inc).
  

• The label of the field in the backend is always "Look up things using Yild" and does not represent the label I used for the field.
• The 12 characters of the Yild PoolParty configuration name I used were too long to be displayed in the result-list of the autocomplete-widget --> The name was cut there.

Great work so far!

regards
Martin

Sorry for the delay. Make sure to review more project applications and finish the review bonus and this will get finished faster.

Review of the 7.x-1.x branch (commit a429377):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/includes/yild_poolparty_sparql_service.inc
  ---------------------------------------------------------------------------
  FOUND 1 ERROR AFFECTING 1 LINE
  ---------------------------------------------------------------------------
   7 | ERROR | [x] Missing class doc comment
  ---------------------------------------------------------------------------
  PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
  ---------------------------------------------------------------------------
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. project page: what problem does this module solve? What is the use case? See also https://www.drupal.org/node/997024
2. yild_poolparty_admin_settings_list(): do not create URLs with $base_url, use url() instead. Also it looks like you should use theme('image', ...) here?
3. yild_poolparty_admin_settings_form(): doc block is wrong, this not a hook but a form constructor. See https://www.drupal.org/coding-standards/docs#forms
4. yild_poolparty_admin_settings_list(): do not call theme() here, just return the render array. Drupal core will render it later for you. See https://www.drupal.org/node/930760
5. yild_poolparty_admin_settings_list(): do not use drupal_add_js/css() here, use the #attached property on the render array. See https://api.drupal.org/api/drupal/developer--topics--forms_api_reference...
6. yild_poolparty_admin_settings_list(): I tried to perform an XSS on that page, but the setting name is too short (12 characters) to inject a valid XSS string and the setting URL is validated as URL. OIt might still be a good idea to do sanitization here as explained on https://www.drupal.org/node/28984
7. If you require cURL you can add hook_requirements() to make sure it is available see https://api.drupal.org/api/drupal/modules!simpletest!simpletest.install/... for example.

Otherwise looks RTBC to me.

Assigning to er.pushpinderrana as he might have time to take a final look at this.

Automated Review

Best practice issues identified by pareview.sh / drupalcs / coder. None

Review of the 7.x-1.x branch (commit 916655f):

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Manual Review

A hook_help() would be nice.

yild_poolparty_admin_settings_title(): It is always best to use @arg or %arg placeholders unless you are know you are *positive* dealing with safe output.

yild_poolparty_admin_settings_form_validate(): form_set_error('url', t('%field must be a valid URL.', array('%field' => t('URL'))));. I think you forget to replace %field value with $form_state['values']['url'].

but none is application blocker, so...

Thanks for your contribution, Kurt Moser!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.