The suggestion is to add a tooltip or a simple title attribute to the contextual-link button.

CommentFileSizeAuthor
#33 2343777-33.patch4.72 KBameymudras
#21 drupal8-tooltip-toggle-contextual_link-button-2343777-21.patch2.51 KBsudhanshug
#19 drupal8-tooltip-toggle-contextual_link-button-2343777-19.patch2.46 KBsudhanshug
#17 drupal8-tooltip-toggle-contextual_link-button-2343777-17.patch2.46 KBsudhanshug
#15 drupal8-tooltip-toggle-contextual_link-button-2343777-15.patch2.64 KBsudhanshug
#9 drupal8-tooltip-toggle-contextual_link-button-2343777-2.patch9.76 KBdrupaldrop
#1 drupal8-tooltip-toggle-contextual_link-button-2343777-1.patch2.75 KBandriyun
Screenshot from 2014-09-24 00-05-29.png.jpg12.68 KBandriyun

Comments

andriyun’s picture

andriyun commented
Assigned: Unassigned » andriyun
Status: Active » Needs review
StatusFileSize
new drupal8-tooltip-toggle-contextual_link-button-2343777-1.patch2.75 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented
Assigned: andriyun » nod_
Issue summary: View changes
Issue tags: +JavaScript

Looks great! Needs JS approval, +1 RTBC

BarisW’s picture

BarisW commented

JS looks good to me too, but let's nod_ have a look as well. +1

nod_’s picture

nod_
Primary language French
Location Lille
commented

Not sure if this.options = options is a backbone way of doing things.

If someone can confirm it, +1 from me.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Assigned: nod_ » Unassigned
dealancer’s picture

dealancer commented

I would update a screenshot, as it is does not match to what have been implemented.

+      this.options = options;

This is done automatically in in Backbone 1.1, see http://backbonejs.org/#changelog

+        .attr('title', Drupal.t(
+          '@action contextual links', {
+            '@action': (this.model.get('isViewing')) ?
+              this.options.strings.show : this.options.strings.hide
+            }
+          )

That is a bit hard for understanding, would't be simpler to do something like this?

+        .attr('title', this.model.get('isViewing') ? this.options.strings.showLinks : this.options.strings.hideLinks)

Then,

-      // Update the view of the trigger.
-      this.$el.find('.trigger')
-        .text(Drupal.t('@action @title configuration options', {
+      var buttonText = Drupal.t('@action @title configuration options', {
           '@action': (!isOpen) ? this.options.strings.open : this.options.strings.close,
           '@title': this.model.get('title')
-        }))
-        .attr('aria-pressed', isOpen);
+        });
+
+      // Update the view of the trigger.
+      this.$el.find('.trigger')
+        .text(buttonText)
+        .attr({
+          'aria-pressed': isOpen,
+          'title': buttonText
+        });
     }

Looks like it is a fix for the views module (core/modules/contextual/js/views/AuralView.js). Could you tell what does this fix and where exactly? May be attach a screenshot and update ticket description if required.

Everything else looks good!

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented

Patch #1 applying succesfully and also displaying tooltip but its showing message as "Show contextual links" instead of "Show/hide contextual links" as shown in the https://www.drupal.org/files/issues/Screenshot%20from%202014-09-24%2000-....

droplet’s picture

droplet commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
drupaldrop’s picture

drupaldrop commented
Issue tags: -Needs reroll
StatusFileSize
new drupal8-tooltip-toggle-contextual_link-button-2343777-2.patch9.76 KB

Patch is rerolled - got a conflict and reuploaded the patch after fix . find details below

First, rewinding head to replay your work on top of it...
Applying: Applying patch from issue 2343777 comment 9187899
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging core/modules/contextual/js/toolbar/views/VisualView.js
CONFLICT (content): Merge conflict in core/modules/contextual/js/toolbar/views/VisualView.js
Failed to merge in the changes.
Patch failed at 0001 Applying patch from issue 2343777 comment 918789

Patch is clean now..

drupaldrop’s picture

drupaldrop commented
Status: Needs work » Needs review
droplet’s picture

droplet commented
Status: Needs review » Needs work

wrong patch ? We should not just let GIT happy only while rerolling a patch :)

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

sudhanshug’s picture

sudhanshug commented
Status: Needs work » Needs review
StatusFileSize
new drupal8-tooltip-toggle-contextual_link-button-2343777-15.patch2.64 KB

Rerolled the patch according to suggestions in #6.

Status: Needs review » Needs work

The last submitted patch, 15: drupal8-tooltip-toggle-contextual_link-button-2343777-15.patch, failed testing.

sudhanshug’s picture

sudhanshug commented
Status: Needs work » Needs review
StatusFileSize
new drupal8-tooltip-toggle-contextual_link-button-2343777-17.patch2.46 KB

Sorry for the patch in #15. Corrected the patch.

Status: Needs review » Needs work

The last submitted patch, 17: drupal8-tooltip-toggle-contextual_link-button-2343777-17.patch, failed testing.

sudhanshug’s picture

sudhanshug commented
Status: Needs work » Needs review
StatusFileSize
new drupal8-tooltip-toggle-contextual_link-button-2343777-19.patch2.46 KB

Seems like I missed indentation. :/

Status: Needs review » Needs work

The last submitted patch, 19: drupal8-tooltip-toggle-contextual_link-button-2343777-19.patch, failed testing.

sudhanshug’s picture

sudhanshug commented
Status: Needs work » Needs review
StatusFileSize
new drupal8-tooltip-toggle-contextual_link-button-2343777-21.patch2.51 KB

Not a good day for me at all. :(((
Paches in #15 and #17 are same.
Here is the tested patch.
Apologies....

Status: Needs review » Needs work

The last submitted patch, 21: drupal8-tooltip-toggle-contextual_link-button-2343777-21.patch, failed testing.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue tags: -JavaScript +JavaScript, +tooltip
ameymudras’s picture

ameymudras commented
Status: Needs work » Needs review
StatusFileSize
new 2343777-33.patch4.72 KB

A patch for 9.5.x

Status: Needs review » Needs work

The last submitted patch, 33: 2343777-33.patch, failed testing. View results

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.