Problem/Motivation

The update module is still assuming:

  • the base themes can be disabled if a sub theme is installed. #1067408: Themes do not have an installation status changed this assumption. Additionally it uses the hidden property of extensions - this is no longer valid.
  • extensions can be hidden
  • extensions can be disabled

Proposed resolution

Change code to reflect current state of HEAD

Remaining tasks

#3414172: In update module convert comments to use install/uninstall
#3117553: Change UI for /admin/reports/updates/update to not mention "Enabled/Disabled" modules and themes
#3121870: Change implementation details of UpdateManagerUpdateForm to use install/uninstall

These need issues

  • Update docs in update.report.inc although that might just be variable names, there may be stale code to remove.

See #13 for details

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Update module still assumes the base themes can be disabled if a sub theme is installed » Update module is not up-to-date with HEAD's extension system.
Issue summary: View changes
mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Postponed » Active

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
catch’s picture

catch
he/him
Primary language English
commented
Title: Update module is not up-to-date with HEAD's extension system. » Update module terminology still refers to disabled extensions when it should be uninstalled
Category: Bug report » Task

hook_update_projects_alter() and update.report.inc (and possibly other places) still have references to disabled extensions. In many cases, it looks like it's mostly a case of updating variable names and docs from 'disabled' to 'uninstalled'. i.e. we don't actually have separate handling for disable and uninstall still, but all the terminology needs updating.

Will mean a lot of data structures passed to/returned from hooks will change, but might just have to be a CR for that - we can check if those hooks are actually implemented in contrib or not.

Moving to a task since there's no known functional bug here.

quietone’s picture

quietone commented
Issue summary: View changes
Issue tags: +Bug Smash Initiative

@catch, thanks.

Added the work mentioned above to the Issue Summary and tagged

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Issue summary: View changes

Making this a meta and have re-parented some existing issues.

quietone’s picture

quietone commented
Title: Update module terminology still refers to disabled extensions when it should be uninstalled » [meta] Update module terminology still refers to disabled extensions when it should be uninstalled
dww’s picture

dww
we/he/they
commented
Related issues: +#2891294: [Meta] Use Install/Uninstall consistently for turning modules/themes on/off (not Enable)

What should be the relationship between this meta and #2891294: [Meta] Use Install/Uninstall consistently for turning modules/themes on/off (not Enable)? Should we merge them, or keep separate?

quietone’s picture

quietone commented
Parent issue: » #2891294: [Meta] Use Install/Uninstall consistently for turning modules/themes on/off (not Enable)

When I was last here I wasn't sure what to do about this in relation to #2891294: [Meta] Use Install/Uninstall consistently for turning modules/themes on/off (not Enable). Thinking on that more, I like that this is scoped to 'update' so let's make this a child of that. That way this can stay just about updates.

quietone’s picture

quietone commented
Issue summary: View changes
Related issues: -#2891294: [Meta] Use Install/Uninstall consistently for turning modules/themes on/off (not Enable)

Clarify in the Issue Summary that more issues need to be made.

quietone’s picture

quietone commented
Issue summary: View changes
dww’s picture

dww
we/he/they
commented
Version: 9.5.x-dev » 11.x-dev

Thanks for clarifying the scope of this (all of update manager). Moving to 11.x. It does start to get scary when we're changing keys inside our giant ArrayPIs in update manager. But yeah, maybe we have to "go for it" and make some sweeping changes at some point.

quietone’s picture

quietone commented
Category: Task » Plan
Status: Active » Fixed

All the children here are fixed. Changing to a plan as well as this was admin for the work.

I am moving the points from #13 to the parent issue so this module specific meta issue can be closed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.