Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The update module is still assuming:
- the base themes can be disabled if a sub theme is installed. #1067408: Themes do not have an installation status changed this assumption. Additionally it uses the hidden property of extensions - this is no longer valid.
- extensions can be hidden
- extensions can be disabled
Proposed resolution
Change code to reflect current state of HEAD
Remaining tasks
#3414172: In update module convert comments to use install/uninstall
#3117553: Change UI for /admin/reports/updates/update to not mention "Enabled/Disabled" modules and themes
#3121870: Change implementation details of UpdateManagerUpdateForm to use install/uninstall
These need issues
- Update docs in update.report.inc although that might just be variable names, there may be stale code to remove.
See #13 for details
Comments
Comment #1
alexpottComment #2
mgiffordComment #13
catchhook_update_projects_alter() and update.report.inc (and possibly other places) still have references to disabled extensions. In many cases, it looks like it's mostly a case of updating variable names and docs from 'disabled' to 'uninstalled'. i.e. we don't actually have separate handling for disable and uninstall still, but all the terminology needs updating.
Will mean a lot of data structures passed to/returned from hooks will change, but might just have to be a CR for that - we can check if those hooks are actually implemented in contrib or not.
Moving to a task since there's no known functional bug here.
Comment #14
quietone CreditAttribution: quietone at PreviousNext commented@catch, thanks.
Added the work mentioned above to the Issue Summary and tagged
Comment #17
quietone CreditAttribution: quietone at PreviousNext commentedMaking this a meta and have re-parented some existing issues.
Comment #18
quietone CreditAttribution: quietone at PreviousNext commentedComment #19
dwwWhat should be the relationship between this meta and #2891294: [Meta] Use Install/Uninstall consistently for turning modules/themes on/off (not Enable)? Should we merge them, or keep separate?
Comment #20
quietone CreditAttribution: quietone at PreviousNext commentedWhen I was last here I wasn't sure what to do about this in relation to #2891294: [Meta] Use Install/Uninstall consistently for turning modules/themes on/off (not Enable). Thinking on that more, I like that this is scoped to 'update' so let's make this a child of that. That way this can stay just about updates.
Comment #21
quietone CreditAttribution: quietone at PreviousNext commentedClarify in the Issue Summary that more issues need to be made.
Comment #22
quietone CreditAttribution: quietone at PreviousNext commentedComment #23
dwwThanks for clarifying the scope of this (all of update manager). Moving to 11.x. It does start to get scary when we're changing keys inside our giant ArrayPIs in update manager. But yeah, maybe we have to "go for it" and make some sweeping changes at some point.
Comment #24
quietone CreditAttribution: quietone at PreviousNext commentedAll the children here are fixed. Changing to a plan as well as this was admin for the work.
I am moving the points from #13 to the parent issue so this module specific meta issue can be closed.