Change UI for /admin/reports/updates/update to not mention "Enabled/Disabled" modules and themes

So long as we just change the string, just changing "Disabled" to "Uninstalled" or "Not installed" seems like a good idea (and TBH I'm not sure how we missed it during the D8 development cycle).

We'd also have to change "Installed version" to "Local version" or something. Probably worth a UX meeting discussion.

I'm terrified of changing the structured array keys of the project data. Probably could make that a (scarier) followup.

String changes are also backportable during beta, but form structure changes aren't. So let's keep it to strings.

Summary of the discussion at #3129683: Drupal Usability Meeting 2020-04-28:

• +1 to getting rid of the word "Disabled" since that's not a thing anymore.
• +1 to turning it into "Uninstalled"
• +1 to "Installed version" column heading making zero sense for "Uninstalled" modules. :P
• -1 to "Local version" though, since it's not entirely clear what that means (local to what? is that on my localhost? etc.).

We went back and forth a bit on this labeling ("Your" version? — too informal "Current" version? — mistaken with "current" version meaning "the most recent one" like it does in update status XML) and eventually came 'round to suggesting "Site version" for both.

/var/www/html/d91$ git apply -v 3117553-23.patch
Checking patch core/modules/update/src/Form/UpdateManagerUpdate.php...
Hunk #1 succeeded at 275 (offset 2 lines).
Checking patch core/modules/update/tests/fixtures/release-history/ccc_update_test.1_1.xml...
Checking patch core/modules/update/tests/src/Functional/UpdateManagerUpdateTest.php...
Applied patch core/modules/update/src/Form/UpdateManagerUpdate.php cleanly.
Applied patch core/modules/update/tests/fixtures/release-history/ccc_update_test.1_1.xml cleanly.
Applied patch core/modules/update/tests/src/Functional/UpdateManagerUpdateTest.php cleanly.

Agree with "site version". +1 for the finding and fixing this. Weird left over! Patch code seems to have no nitpicking or coding standart issues etc. Applying patch and runnig thru the steps to reproduce the original issue do not show any new issues or flaws with it. Changes apply like expected. Since this patch does not provide any bigger functionality changes or risky code injections I consider this RTBC from here.

Patch #23 before / after screenshots uploaded...

+1 for "Site version"; that's great.

+++ b/core/modules/update/src/Form/UpdateManagerUpdate.php
@@ -273,10 +273,13 @@ public function buildForm(array $form, FormStateInterface $form_state) {
+        // We don't want to just clobber the value in $headers in case it's used
+        // below for another table, so we array_merge here to only update the
+        // copy used for this table.
+        '#header' => array_merge($headers, ['installed_version' => $this->t('Site version')]),

I wonder though, maybe a little clobbering would be OK? Like consistency is also helpful for the user trying to understand the form, and "Site version" would make sense for the other tables too.

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

+1 for this idea and still applies to D10 where disabled is used.

Tagged for reroll. as there are some build errors in #23

Also agree with #25 that consistency would be nice so if "Site version" can be used in the other spots too.

Thanks for rediscovering this issue!

IMO this is a usability bug, so recategorizing.

Trying to fix errors in #23

I rerolled the patch and there was no issues with that task. The test failure was caused by the test not setting up the new xml file to be returned.

It seemed odd to me to see 'Enabled' on the page so I expanded the scope to fix Enabled/Disabled on this single page. It seems sensible to me and was easier to do this in one issue instead of two. There were minimal changes for that in both the code and the test.

Updating the IS, and addingh before/after screenshots.

This patch addresses #25, removing the changes.

Verified the test change by applying patch #37
Install some contrib module
Go to en/admin/reports/updates/update
Verified text change.

An unrelated random failure, #3380433: [random test failure] CronRunTest::testAutomatedCron. I am restoring RTBC.

Ran the failing test locally just to be sure.

Committed 06b7f5c and pushed to 11.x. Thanks!