[Meta] Use Install/Uninstall consistently for turning modules/themes on/off (not Enable)

I installed Xmlsitemap module and got message 'XMLSitemap has been enabled'. Added a corrective patch.

FYI -- on the parent issue #2888657: [meta] Less confusing and more consistent wording needed in module/theme add/install/update the Usability team is discussing the UI text for this and about 10 other issues. Until decisions are made, making another patch here would probably be premature.

We discussed several related UI text issues at the Usability meeting today -- see #2888657-23: [meta] Less confusing and more consistent wording needed in module/theme add/install/update for a summary.

I'm adopting this issue to cover item 2 from that plan:

There is a UI that lets you turn a module/theme on/off. Turning it on adds configuration and often database tables. Turning it off removes content, configuration, and/or database tables. The UI for this should consistently use the verbs "Install" and "Uninstall". Currently it mostly does use these verbs, but it says "Enable" in a few places. This can be fixed in a minor release, as it is only UI text changes.

Updating title and summary accordingly.

Adding list of people to credit from #2856038: Confusing instructions when installing a theme in D8 which is now a duplicate.

And forgot to update title.

This patch will conflict with #2577407: Action of uploading module/theme files should consistently be called "Add", not "Install", so postponing until that one is done.

#2577407: Action of uploading module/theme files should consistently be called "Add", not "Install" has been fixed, so we are no longer using the verb "Install" for the action of adding files for a module/theme to the site. So we can un-postpone this now. The previous patches will not apply any more.

I started looked through the entire core codebase for "enabl" and "disabl" (so that I'd make sure I found "enabling" as well as "enable" "enabled" "enables") and I found a number of spots in the codebase that need to be looked at and/or fixed. Adding them to the issue summary. There are more....

This will be a big patch and it will conflict with #3182405: Do not use verb "Install" for things other than turning on modules/themes, so I think we should postpone this issue after all.

Closed #2532652: Make the install and uninstall message the same as a duplicate. Posting the latest MR from there as a patch here. Credit to Manjit.Singh, Spokje, quietone.

This is now active.

In #16 it is said that this will be a big patch and reading the IS I tend to agree. This needs to be split into smaller manageable child issue.

Converting this to a Meta. I've deliberately trimmed down the IS to make it easier to see the child issues and how they have been scoped. The list of changes in the IS was helpful but I would up doing my own searches anyway when making the changes.

Should we create a dedicated issue for Documentation as well? For example the pages under https://www.drupal.org/docs/extending-drupal needs updating as well. I have already updated these two pages:

• https://www.drupal.org/docs/extending-drupal/themes/installing-themes
• https://www.drupal.org/docs/extending-drupal/installing-modules

... but there are most likely many more instances of "enable" which should be "install".

We have some methods that need renaming too:

+++ b/core/tests/Drupal/KernelTests/KernelTestBase.php
@@ -858,7 +858,7 @@ protected function enableModules(array $modules) {
@@ -884,7 +884,7 @@ protected function disableModules(array $modules) {

More instances to change were found in #3379495-21: Convert enable/disable to install/uninstall in hook_help(). 2 in language_tour_tips_alter and one in system.install. These may need individual issue or a better scope. For example, the tour one might be for all hook_tour_tips_alter. I have added them to the remaining tasks.

longwave found an instance in a test module and I have added that to the list in the issue summary, #3379496-20: Convert enable/disable to install/uninstall in UI not in hook_help.

This meta was for tracking changes to the UI. All the child issues are now closed. If any more instances are found someone can make a new issue.

The points in #27 and #29 are addressed in the 2 referenced instances. #2888654: URLs for module/theme actions are inconsistent with UI text #3182408: [meta] API function names in module/theme install/uninstall space should match UI

Added created per the Issue Summary and closing as fixed.

Just a tip that a discussion of wording for the install command in the new dr tool is taking place in #3594334: Add a module and theme install command, for those who are interested.

FWIW the /admin/modules lists dependent modules that are not installed with the "disabled" suffix. This doesn't bother me at all, but if we want to be consistent it should probably say "not installed".

In \Drupal\system\Form\ModulesListForm::buildRow:

$row['#requires'][$dependency] = $modules[$dependency]->status ? $this->t('@module', ['@module' => $name]) : $this->t('@module (<span class="admin-disabled">disabled</span>)', ['@module' => $name]);

Thanks for the tip @mstrelan, I think we should be consistent. So I created #3611590: Use Installed and Uninstalled on Available updates page which updates it to "uninstalled". I first went for "not installed", but then saw that the Themes ("Appearances") header is "Uninstalled themes", so maybe it's best to use that as well for modules?

About consistency in the dr issue #3594334: Add a module and theme install command, it seems undecided ... so feel free to weigh in.

Ah yes sorry, I added the wrong issue, here's the one I intended to add.