Problem/Motivation

It was decided to use "install" instead of "enable" for modules and themes in #3162049: [meta] Better wording of the module life-cycle admin pages. See also:

Available updates page
Drupal core, contrib modules and themes on the "Available updates" page (/admin/reports/updates) list sub-projects under the words "Enabled:" and "Disabled:", yet use "Uninstalled modules" in the header.

"Uninstalled themes" is also used on the "Appearance" page (/admin/appearance), so we should probably use "uninstalled" to stay consistent, rather than for example "not installed".

For Drupal core code comments, see #3612984: Use install and uninstall in code comments, not enable/disable.

Steps to reproduce

See the list of Modules under "Available updates" page (/admin/reports/updates) use the words "Enabled" and "Disabled", even though we install and uninstall modules, not enable/disable as in Drupal 7.

Proposed resolution

To be consistent, we should probably use "Installed" and "Uninstalled" in the "Available updates" page, for both modules and themes.

Remaining tasks

It is probably too much effort to change disabled to uninstalled in the variables, in the underlying files, but we could update update the template file core/modules/update/templates/update-project-status.html.twig to use "Installed" and "Uninstalled".

User interface changes

Drupal core, modules and themes will list installed sub-modules and -themes under "Installed:", and uninstalled under "Uninstalled:".

Before:
A screenshot of the Available Updates page showing the text "Enabled" and "Disabled"

After:
A screenshot of the Available Updates page showing the changed "Installed" and "Uninstalled" text

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#13 2-installed-w-bg.png60.95 KBressa
#13 1-enabled-w-bg.png59.29 KBressa
#12 2-installed.png55.17 KBressa
#12 1-enabled.png59.22 KBressa
#10 after.png12.36 KBdcam
#10 before.png16.18 KBdcam

Issue fork drupal-3611590

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ressa created an issue. See original summary.

ressa opened merge request !16346

ressa’s picture

ressa
he/him
commented
Assigned: ressa » Unassigned
Status: Active » Needs review
dcam’s picture

dcam commented

I can get behind not changing code like variable names or array keys, but "enabled" and "disabled" are still used in comments throughout Core. I'd suggest updating them to reduce the amount of outdated language in the code base. I used the PHPStorm search feature to try and find them, but I'm not confident that this is a comprehensive list. For one thing, it didn't find the instances in the template being updated by this MR (I had main checked out). And it kept returning different numbers of results for FunctionalTestSetupTrait. I don't know what to make of that. Anyway, if it's decided that they should be in-scope, then here's some that I found related to installing/uninstalling modules:

  • Two instances of "enabled" in core/lib/Drupal.php
  • Three instances of "enabled" in core/lib/Drupal/Core/DrupalKernel.php
  • "enabled"/"disabled" in core/lib/Drupal/Core/DrupalKernelInterface.php
  • "enabled" in core/lib/Drupal/Core/Field/Plugin/Field/FieldType/LanguageItem.php
  • Five instances of "enabled" in core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php
  • "disabled" in core/lib/Drupal/Core/Test/TestDiscovery.php
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Think #4 is perfectly valid

ressa’s picture

ressa
he/him
commented
Title: Use Installed and Uninstalled on Available updates page » Use Installed and Uninstalled on Available updates page and in code comments
Issue summary: View changes

I agree, updating comments as well would be nice. However, there are quite a few instances, and I try to avoid using Git for Drupal contributions, but instead GitLab GUI, where opening and editing so many files is too cumbersome ... but anyone able to do the substitutions locally and push them up with Git should feel free to have a go at it.

I grepped for instances of "module" or "theme" before or after "enable" and "disable" with this:

$ grep -rinoE '.{0,20}module|theme.{0,20}' core | grep -E " enabl| disabl"
$ grep -rinoE '.{0,20}enabl|disabl.{0,20}' core | grep -E " module| theme"

There are some false positives, as well as missed instances, for example where "module" and "enable" are on separate lines, so each file probably needs to be gone through manually.

Here is the combined list of the result from the two searches. After they are fixed, we can do a round 2, to catch the remaining:

  • core/core.api.php:119: " module can also be enabl"
  • core/core.api.php:237: "or theme is already enabl"
  • core/core.api.php:237: "theme is already enabled "
  • core/core.api.php:238: " module or theme is enabl"
  • core/core.api.php:238: "theme is enabled, you wou"
  • core/includes/install.inc:702: " only a few modules enabl"
  • core/includes/module.inc:31: "red list of enabled module"
  • core/includes/module.inc:33: "The list of enabled module"
  • core/includes/update.inc:693: "re that a module be enabl"
  • core/lib/Drupal.php:107: "nd themes cannot be enabl"
  • core/lib/Drupal.php:107: "themes cannot be enabled."
  • core/lib/Drupal.php:18: "roviders of enabled module"
  • core/lib/Drupal/Core/Asset/CssOptimizer.php:146: " to disable certain module"
  • core/lib/Drupal/Core/Asset/CssOptimizer.php:146: "disable certain module CSS"
  • core/lib/Drupal/Core/Config/ConfigImporter.php:913: "ded all the enabled module"
  • core/lib/Drupal/Core/Config/ConfigInstaller.php:407: " // module has been enabl"
  • core/lib/Drupal/Core/Config/ConfigInstaller.php:617: "e currently enabled module"
  • core/lib/Drupal/Core/Config/ConfigInstaller.php:653: "e currently enabled module"
  • core/lib/Drupal/Core/Config/ConfigInstaller.php:679: "e currently enabled module"
  • core/lib/Drupal/Core/Config/ExtensionInstallStorage.php:23: "the list of enabled module"
  • core/lib/Drupal/Core/Config/ExtensionInstallStorage.php:42: "the list of enabled module"
  • core/lib/Drupal/Core/Config/ExtensionInstallStorage.php:77: "is based on enabled module"
  • core/lib/Drupal/Core/DrupalKernel.php:152: "the list of enabled module"
  • core/lib/Drupal/Core/DrupalKernel.php:192: "for reading enabled module"
  • core/lib/Drupal/Core/DrupalKernel.php:612: "// Load all enabled module"
  • core/lib/Drupal/Core/DrupalKernel.php:650: "// Retrieve enabled module"
  • core/lib/Drupal/Core/DrupalKernelInterface.php:13: "ng to modules being enabl"
  • core/lib/Drupal/Core/Entity/entity.api.php:2310: " Language module is enabl"
  • core/lib/Drupal/Core/EventSubscriber/AuthenticationSubscriber.php:147: " language module is enabl"
  • core/lib/Drupal/Core/EventSubscriber/ModuleRouteSubscriber.php:10: "nd on modules being enabl"
  • core/lib/Drupal/Core/Extension/module.api.php:167: "ng those in modules enabl"
  • core/lib/Drupal/Core/Extension/module.api.php:991:date: " The module is enabl"
  • core/lib/Drupal/Core/Extension/ModuleHandlerInterface.php:109: "le for each enabled module"
  • core/lib/Drupal/Core/Extension/ModuleHandlerInterface.php:158: "heck if any enabled module"
  • core/lib/Drupal/Core/Extension/ModuleHandlerInterface.php:201: "hook in all enabled module"
  • core/lib/Drupal/Core/Extension/ModuleHandlerInterface.php:243: "hook in all enabled module"
  • core/lib/Drupal/Core/Extension/ModuleHandlerInterface.php:28: "* Loads all enabled module"
  • core/lib/Drupal/Core/Extension/ModuleHandlerInterface.php:357: "ies for all enabled module"
  • core/lib/Drupal/Core/Extension/ModuleHandlerInterface.php:363: "ies for all enabled module"
  • core/lib/Drupal/Core/Extension/ModuleHandlerInterface.php:42: "Reloads all enabled module"
  • core/lib/Drupal/Core/Extension/ModuleHandlerInterface.php:6: "ge a set of enabled module"
  • core/lib/Drupal/Core/Extension/ModuleHandlerInterface.php:98: "r a given module is enabl"
  • core/lib/Drupal/Core/Extension/ModuleInstaller.php:316: "red list of enabled module"
  • core/lib/Drupal/Core/Extension/ModuleInstaller.php:317: " configured enabled module"
  • core/lib/Drupal/Core/Extension/ModuleInstaller.php:574: "d. A module is only enabl"
  • core/lib/Drupal/Core/Extension/ModuleInstaller.php:574: "ss modules that are enabl"
  • core/lib/Drupal/Core/Extension/ModuleInstaller.php:574: "that are enabled. A module"
  • core/lib/Drupal/Core/Extension/ModuleWeight.php:54: "red list of enabled module"
  • core/lib/Drupal/Core/Extension/ModuleWeight.php:56: "The list of enabled module"
  • core/lib/Drupal/Core/Field/Plugin/Field/FieldType/LanguageItem.php:92: " language module is enabl"
  • core/lib/Drupal/Core/Language/LanguageManager.php:377: " Language module is enabl"
  • core/lib/Drupal/Core/Render/Element/Actions.php:15: "* and enables other module"
  • core/lib/Drupal/Core/Routing/routing.api.php:105: "the Block module is enabl"
  • core/lib/Drupal/Core/StreamWrapper/ModuleStream.php:13: " * Only enabled module"
  • core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:237: "the list of enabled module"
  • core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:244: "1757 so that module enabl"
  • core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:247: " * enabled module"
  • core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:255: " having enabled new module"
  • core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:259: " * modules are enabl"
  • core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:532: " after enabling the module"
  • core/lib/Drupal/Core/Theme/Registry.php:315: "the list of enabled module"
  • core/lib/Drupal/Core/Update/UpdateHookRegistry.php:24: "* A list of enabled module"
  • core/lib/Drupal/Core/Utility/ProjectInfo.php:17: " * enabled module"
  • core/modules/announcements_feed/help_topics/announcements_feed.overview.html.twig:18: " the toolbar module enabl"
  • core/modules/announcements_feed/help_topics/announcements_feed.overview.html.twig:18: "olbar module is not enabl"
  • core/modules/big_pipe/tests/src/FunctionalJavascript/BigPipePreviewTest.php:43: "pe_bypass_js module enabl"
  • core/modules/block/tests/src/Functional/BlockAdminThemeTest.php:54: "disabled in Claro theme."
  • core/modules/block/tests/src/Functional/BlockUiTest.php:165: "stark base theme is enabl"
  • core/modules/block/tests/src/Functional/BlockUiTest.php:165: "theme is enabled');"
  • core/modules/block_content/src/Hook/BlockContentHooks.php:61: " language module is enabl"
  • core/modules/ckeditor5/js/build/ckeditor5.types.jsdoc:4698:disablermixin} module: "ui/b"
  • core/modules/ckeditor5/js/build/ckeditor5.types.jsdoc:4699:disablermixin} module: "ui/b"
  • core/modules/ckeditor5/src/Hook/Ckeditor5Hooks.php:261: "he locale module is enabl"
  • core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageTest.php:53: "ith the test module enabl"
  • core/modules/ckeditor5/tests/src/Kernel/CKEditor5PluginManagerTest.php:101: "cted function enableModule"
  • core/modules/config/tests/src/Functional/ConfigImportAllTest.php:129: "red and not enabled module"
  • core/modules/config/tests/src/Functional/ConfigImportAllTest.php:183: " // all modules are enabl"
  • core/modules/config/tests/src/Functional/ConfigImportAllTest.php:71: "on't need to enable module"
  • core/modules/config/tests/src/Kernel/ConfigOtherModuleTest.php:29: " that module is not enabl"
  • core/modules/contextual/src/Element/ContextualLinks.php:43: " * all enabled module"
  • core/modules/dblog/tests/src/Kernel/DbLogTest.php:48: "e number of enabled module"
  • core/modules/editor/src/Hook/EditorHooks.php:170: "disabled because no module"
  • core/modules/editor/tests/src/Functional/EditorAdminTest.php:221: "disabled because no module"
  • core/modules/editor/tests/src/Functional/EditorAdminTest.php:78: "disabled because no module"
  • core/modules/field/tests/src/Kernel/FieldDefinitionIntegrityTest.php:179: "en, already enabled module"
  • core/modules/field/tests/src/Kernel/FieldTypePluginManagerTest.php:132: "nction enableAllCoreModule"
  • core/modules/field/tests/src/Kernel/FieldTypePluginManagerTest.php:95: "s enable all Drupal module"
  • core/modules/field_ui/tests/src/Kernel/EntityFormDisplayTest.php:123: " case of a disabled module"
  • core/modules/field_ui/tests/src/Kernel/EntityFormDisplayTest.php:123: "disabled module)"
  • core/modules/filter/filter.links.menu.yml:4: "endered, and enable module"
  • core/modules/filter/help_topics/filter.overview.html.twig:16: "xt Editor module is enabl"
  • core/modules/filter/tests/filter_test_plugin/filter_test_plugin.info.yml:3: " 'Tests enabling of module"
  • core/modules/filter/tests/filter_test_plugin/src/Plugin/Filter/FilterSparkles.php:16: "but enabling of its module"
  • core/modules/filter/tests/src/Functional/FilterFormTest.php:77: "nsure that enabling module"
  • core/modules/help/help_topics/core.content_structure.html.twig:31: "ou have that module enabl"
  • core/modules/help/tests/src/Kernel/HelpEmptyPageTest.php:41: "en, already enabled module"
  • core/modules/help/tests/src/Kernel/HelpTest.php:204: "the list of enabled module"
  • core/modules/help/tests/src/Kernel/HelpTest.php:207: " A list of enabled module"
  • core/modules/image/image.api.php:27: "* This hook enables module"
  • core/modules/image/src/Plugin/Field/FieldFormatter/ImageFormatter.php:148: "disabled modules that defi"
  • core/modules/image/src/Plugin/Field/FieldFormatter/ImageFormatter.php:148: "of enabled/disabled module"
  • core/modules/image/src/Plugin/Field/FieldFormatter/ImageUrlFormatter.php:97: "disabled modules that defi"
  • core/modules/image/src/Plugin/Field/FieldFormatter/ImageUrlFormatter.php:97: "of enabled/disabled module"
  • core/modules/image/src/Plugin/Field/FieldWidget/ImageWidget.php:97: "disabled modules that defi"
  • core/modules/image/src/Plugin/Field/FieldWidget/ImageWidget.php:97: "of enabled/disabled module"
  • core/modules/jsonapi/tests/modules/jsonapi_response_validator/jsonapi_response_validator.info.yml:3: "'When enabled, this module"
  • core/modules/jsonapi/tests/src/Kernel/TestCoverageTest.php:45: "on't need to enable module"
  • core/modules/language/src/Hook/LanguageHooks.php:353: " * module is enabl"
  • core/modules/language/tests/src/Functional/LanguageListModuleInstallTest.php:33: "his by enabling the module"
  • core/modules/language/tests/src/Functional/LanguageListModuleInstallTest.php:48: "'Language module is enabl"
  • core/modules/language/tests/src/Kernel/EntityDefaultLanguageTest.php:76: "Disable language module."
  • core/modules/language/tests/src/Kernel/LanguageConfigOverrideInstallTest.php:33: "Need to enable test module"
  • core/modules/language/tests/src/Kernel/LanguageFallbackTest.php:68: "guage module is not enabl"
  • core/modules/layout_builder/modules/layout_builder_expose_all_field_blocks/layout_builder_expose_all_field_blocks.info.yml:3: "'When "enabled, this module
  • core/modules/locale/locale.module:249: "// Not each enabled module"
  • core/modules/locale/locale.module:298: ". Not each disabled module"
  • core/modules/locale/locale.module:298: "disabled module will remov"
  • core/modules/locale/locale.translation.inc:57: "te Status module is enabl"
  • core/modules/locale/src/Hook/LocaleExtensionHooks.php:45: "// Not each enabled module"
  • core/modules/locale/src/Hook/LocaleHooks.php:186: "he locale module is enabl"
  • core/modules/locale/src/LocaleConfigManager.php:618: " // module is enabl"
  • core/modules/locale/src/LocaleProjectStorageInterface.php:114: "te Status module is enabl"
  • core/modules/locale/tests/src/Functional/LocaleConfigTranslationImportTest.php:57: "ale module has been enabl"
  • core/modules/locale/tests/src/Functional/LocaleUpdateTest.php:344: "rt when a module is enabl"
  • core/modules/locale/tests/src/Functional/LocaleUpdateTest.php:385: " * enabled module"
  • core/modules/media/src/Hook/MediaHooks.php:53: "e Media module also enabl"
  • core/modules/media_library/src/Plugin/Field/FieldWidget/MediaLibraryWidget.php:639: "// UI module is not enabl"
  • core/modules/navigation/src/NavigationContentLinks.php:47: "u, based on enabled module"
  • core/modules/navigation/tests/src/Functional/NavigationLinkBlockTest.php:139: " Help module is not enabl"
  • core/modules/node/src/Hook/NodeHelpHooks.php:73: "he Node module also enabl"
  • core/modules/node/src/Hook/NodeModuleHooks.php:28: "f the newly enabled module"
  • core/modules/node/src/Hook/NodeModuleHooks.php:40: "any of the disabled module"
  • core/modules/node/src/Hook/NodeModuleHooks.php:40: "disabled modules implement"
  • core/modules/node/src/NodeServiceProvider.php:21: "anguage modules are enabl"
  • core/modules/node/src/NodeServiceProvider.php:31: " language module is enabl"
  • core/modules/node/tests/src/Kernel/NodeAccessLanguageTest.php:140: " // module enabl"
  • core/modules/node/tests/src/Kernel/NodeAccessLanguageTest.php:210: " // module enabl"
  • core/modules/node/tests/src/Kernel/NodeAccessLanguageTest.php:71: " // module enabl"
  • core/modules/package_manager/tests/modules/package_manager_test_validation/src/EventSubscriber/TestSubscriber.php:64: " * module is "enabl
  • core/modules/package_manager/tests/modules/package_manager_test_validation/src/EventSubscriber/TestSubscriber.php:87: " * module is "enabl
  • core/modules/package_manager/tests/src/Kernel/PackageManagerKernelTestBase.php:140: "cted function enableModule"
  • core/modules/path/tests/src/Functional/PathAliasTest.php:413: "_form_errors module enabl"
  • core/modules/rest/src/Hook/RestHooks.php:26: "n be enabled. Other module"
  • core/modules/rest/src/Hook/RestHooks.php:44: "Node module) is enabl"
  • core/modules/rest/tests/src/Kernel/EntityResource/EntityResourceRestTestCoverageTest.php:51: "on't need to enable module"
  • core/modules/settings_tray/css/settings_tray.toolbar.css:3: "ings Tray module is enabl"
  • core/modules/system/help_topics/system.module_install.html.twig:15: "disabled for the module yo"
  • core/modules/system/help_topics/system.module_install.html.twig:15: "is disabled for the module"
  • core/modules/system/src/Controller/SystemController.php:312: "ermission to enable module"
  • core/modules/system/src/Controller/SystemController.php:329: "disabled module"
  • core/modules/system/src/Controller/SystemController.php:329: "tains only disabled module"
  • core/modules/system/src/Form/ModulesEnabledTrait.php:11: "elpers for enabling module"
  • core/modules/system/src/Form/ModulesEnabledTrait.php:28: "r modules have been enabl"
  • core/modules/system/src/Form/ModulesEnabledTrait.php:34: " any of the enabled module"
  • core/modules/system/src/Form/ModulesEnabledTrait.php:38: "ted function modulesEnabl"
  • core/modules/system/src/Form/ModulesEnabledTrait.php:70: " any of the enabled module"
  • core/modules/system/src/Form/ModulesEnabledTrait.php:74: "nction modulesFailToEnabl"
  • core/modules/system/src/Form/ModulesListConfirmForm.php:16: "n form for enabling module"
  • core/modules/system/src/Form/ModulesListNonStableConfirmForm.php:143: "ted module is being enabl"
  • core/modules/system/src/Form/ModulesListNonStableConfirmForm.php:145: "ted module is being enabl"
  • core/modules/system/src/Form/ModulesListNonStableConfirmForm.php:162: "table modules being enabl"
  • core/modules/system/src/Form/ModulesListNonStableConfirmForm.php:30: " module names to be enabl"
  • core/modules/system/src/Form/ModulesListNonStableConfirmForm.php:37: "ted module is being enabl"
  • core/modules/system/src/Form/ModulesListNonStableConfirmForm.php:44: "ted module is being enabl"
  • core/modules/system/src/Hook/SystemRequirementsHooks.php:98: "ental modules being enabl"
  • core/modules/system/src/Install/Requirements/SystemRequirements.php:106: "write module is not enabl"
  • core/modules/system/src/Theme/SystemAdminThemePreprocess.php:145: "ox for enabling the module"
  • core/modules/system/system.permissions.yml:20: " the Node module is enabl"
  • core/modules/system/templates/system-modules-details.html.twig:11: "ox for enabling the module"
  • core/modules/system/tests/modules/module_test/src/Hook/ModuleTestThemeHooks.php:71: "at the modules were enabl"
  • core/modules/system/tests/src/Functional/Menu/MenuAccessTest.php:127: "t module. It is not enabl"
  • core/modules/system/tests/src/Functional/Module/ClassLoaderTest.php:37: "ed when a module is enabl"
  • core/modules/system/tests/src/Functional/Module/ClassLoaderTest.php:71: "disabled modules."
  • core/modules/system/tests/src/Functional/Module/ClassLoaderTest.php:71: "oaded from disabled module"
  • core/modules/system/tests/src/Functional/Module/DependencyTest.php:204: " * Tests enabling module"
  • core/modules/system/tests/src/Functional/Module/DependencyTest.php:227: " * Tests enabling a module"
  • core/modules/system/tests/src/Functional/Module/DependencyTest.php:247: "hat already enabled module"
  • core/modules/system/tests/src/Functional/Module/HookRequirementsTest.php:11: "Attempts enabling a module"
  • core/modules/system/tests/src/Functional/Module/ModuleTestBase.php:133: "list of modules are enabl"
  • core/modules/system/tests/src/Functional/Module/NonStableModulesTest.php:218: " // Test enabling a module"
  • core/modules/system/tests/src/Functional/Module/NonStableModulesTest.php:95: " // Test enabling a module"
  • core/modules/system/tests/src/Functional/System/ThemeTest.php:293: " // module is not enabl"
  • core/modules/system/tests/src/Functional/System/ThemeTest.php:404: "Disable the admin theme on"
  • core/modules/system/tests/src/Functional/System/ThemeTest.php:95: "disabled theme settings fo"
  • core/modules/system/tests/src/Functional/Theme/ExperimentalThemeTest.php:100: "theme should not be enabl"
  • core/modules/system/tests/src/Functional/Theme/ThemeUiTest.php:50: "disabled modules."
  • core/modules/system/tests/src/Functional/Theme/ThemeUiTest.php:53: "ermission to enable module"
  • core/modules/system/tests/src/Functional/Theme/ThemeUiTest.php:59: " a theme that would enabl"
  • core/modules/system/tests/src/Functional/Theme/ThemeUiTest.php:59: "theme that would enable m"
  • core/modules/system/tests/src/Functional/UpdateSystem/RebuildScriptTest.php:73: "Disable a module by writin"
  • core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php:310: "r modules are still enabl"
  • core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php:357: " '" module is still enabl"
  • core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php:360: "themes are still enabled."
  • core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php:360: "ur themes are still enabl"
  • core/modules/system/tests/src/Kernel/Extension/ModuleHandlerTest.php:131: "at the modules were enabl"
  • core/modules/system/tests/src/Kernel/Extension/ModuleHandlerTest.php:165: "at the modules were enabl"
  • core/modules/system/tests/src/Kernel/Extension/ModuleHandlerTest.php:268: "'), 'Test module is enabl"
  • core/modules/system/tests/src/Kernel/Extension/ModuleHandlerTest.php:269: "'), 'Test module is enabl"
  • core/modules/system/tests/src/Kernel/Extension/ModuleHandlerTest.php:30: " retrieving enabled module"
  • core/modules/system/tests/src/Kernel/Extension/ModuleHandlerTest.php:95: "'), 'Test module is enabl"
  • core/modules/system/tests/src/Kernel/Extension/ModuleHandlerTest.php:97: "hat modules are not enabl"
  • core/modules/system/tests/src/Kernel/Module/InstallTest.php:54: "Tests enabling User module"
  • core/modules/system/tests/src/Kernel/Module/InstallTest.php:56: "ller might enable a module"
  • core/modules/system/tests/src/Kernel/System/InfoAlterTest.php:19: "ld after enabling a module"
  • core/modules/system/tests/src/Kernel/System/InfoAlterTest.php:32: " required module is enabl"
  • core/modules/system/tests/src/Kernel/Theme/ThemeTest.php:116: "disabled themes."
  • core/modules/toolbar/tests/src/Functional/ToolbarCacheContextsTest.php:100: " the comment module enabl"
  • core/modules/toolbar/tests/src/Functional/ToolbarCacheContextsTest.php:103: "with comment module enabl"
  • core/modules/toolbar/tests/src/Functional/ToolbarCacheContextsTest.php:97: "h contextual module enabl"
  • core/modules/user/tests/src/Functional/UserLoginTest.php:163: " one, by enabling a module"
  • core/modules/user/tests/src/Functional/UserTokenReplaceTest.php:102: "the Language module enabl"
  • core/modules/user/tests/src/Kernel/UserRoleDeleteTest.php:146: "Disable the node module."
  • core/modules/views/src/ContextualLinksHelper.php:85: "Links module is not enabl"
  • core/modules/views/src/Plugin/views/wizard/WizardPluginBase.php:369: "gs if the module is enabl"
  • core/modules/views/src/Plugin/views/wizard/WizardPluginBase.php:441: "gs if the module is enabl"
  • core/modules/views_ui/tests/src/Functional/DisplayPathTest.php:285: "enu_ui module being enabl"
  • core/modules/workspaces/src/WorkspacesServiceProvider.php:22: "the pgsql module is enabl"
  • core/profiles/demo_umami/tests/src/Functional/DemoUmamiProfileTest.php:87: "profile modules are enabl"
  • core/profiles/minimal/tests/src/Functional/MinimalTest.php:74: "profile modules are enabl"
  • core/profiles/standard/tests/src/Traits/StandardTestTrait.php:106: " // enabling a module"
  • core/profiles/standard/tests/src/Traits/StandardTestTrait.php:77: "profile modules are enabl"
  • core/profiles/tests/testing/modules/drupal_system_listing_compatible_test/tests/src/Kernel/SystemListingCrossProfileCompatibleTest.php:19: "Attempt to enable a module"
  • core/profiles/tests/testing/modules/drupal_system_listing_compatible_test/tests/src/Kernel/SystemListingCrossProfileCompatibleTest.php:21: "file, but enables a module"
  • core/tests/Drupal/FunctionalTests/Routing/RouteCachingQueryAlteredTest.php:37: "age_cache module is enabl"
  • core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBase.php:66: "th all core modules enabl"
  • core/tests/Drupal/KernelTests/Core/Asset/ResolvedLibraryDefinitionsFilesMatchTest.php:122: "en, already enabled module"
  • core/tests/Drupal/KernelTests/Core/Config/ConfigDependencyTest.php:27: "tity_test module is enabl"
  • core/tests/Drupal/KernelTests/Core/Config/ConfigImporterTest.php:845: "test to the enabled module"
  • core/tests/Drupal/KernelTests/Core/Config/ConfigLanguageOverrideTest.php:41: " Language module is enabl"
  • core/tests/Drupal/KernelTests/Core/DrupalKernel/ServiceDestructionTest.php:68: "efore the module is enabl"
  • core/tests/Drupal/KernelTests/Core/Entity/EntityTypeConstraintsTest.php:46: "// new modules were enabl"
  • core/tests/Drupal/KernelTests/Core/ServiceProvider/ServiceProviderTest.php:52: "eeps up with module enabl"
  • core/tests/Drupal/KernelTests/Core/StreamWrapper/ExtensionStreamTest.php:37: " list of modules to enabl"
  • core/tests/Drupal/KernelTests/Core/Theme/ThemeInstallerTest.php:165: "as an enabled module"
  • core/tests/Drupal/KernelTests/Core/Theme/ThemeInstallerTest.php:307: "disabling admin theme.';"
  • core/tests/Drupal/KernelTests/Core/TypedData/ValidKeysConstraintValidatorTest.php:45: "ema_test module, to enabl"
  • core/tests/Drupal/KernelTests/KernelTestBase.php:301: "r, then enable that module"
  • core/tests/Drupal/KernelTests/KernelTestBase.php:803: " If a module is not enabl"
  • core/tests/Drupal/KernelTests/KernelTestBase.php:829: "the list of enabled module"
  • core/tests/Drupal/KernelTests/KernelTestBase.php:852: "Disables modules for this "
  • core/tests/Drupal/KernelTests/KernelTestBase.php:857: " previously enabled module"
  • core/tests/Drupal/KernelTests/KernelTestBaseDatabaseDriverModuleTest.php:60: "abase driver module enabl"
  • core/tests/Drupal/KernelTests/KernelTestBaseTest.php:331: "abase driver module enabl"
  • core/tests/Drupal/Nightwatch/Commands/drupalInstallModule.js:38: " // module has been enabl"
  • core/tests/Drupal/Nightwatch/Commands/drupalInstallModule.js:9: "the module has been enabl"
  • core/tests/Drupal/Tests/Core/EventSubscriber/ModuleRouteSubscriberTest.php:49: "n the module is not enabl"
  • core/tests/Drupal/Tests/Core/Extension/ModuleHandlerTest.php:259: "hods when module is enabl"
  • core/tests/Drupal/Tests/Core/Extension/modules/module_handler_test/module_handler_test.info.yml:3:ption: " 'Test module enabl"
  • core/tests/Drupal/Tests/Core/Plugin/DefaultPluginManagerTest.php:114: "ation of a disabled module"
  • core/tests/Drupal/Tests/Core/Plugin/DefaultPluginManagerTest.php:114: "disabled module is not ava"
  • core/tests/Drupal/Tests/Core/Plugin/DefaultPluginManagerTest.php:93: "disabled module."
  • core/tests/Drupal/Tests/Core/Plugin/DefaultPluginManagerTest.php:93: "ger with a disabled module"
  • core/tests/Drupal/Tests/Core/Update/UpdateRegistryTest.php:233: "ded modules but not enabl"
  • core/tests/Drupal/Tests/Core/Update/UpdateRegistryTest.php:247: " // not enabled module"
  • core/themes/claro/templates/admin/system-modules-details.html.twig:11: "ox for enabling the module"
  • core/themes/default_admin/templates/admin/system-modules-details.html.twig:11: "ox for enabling the module"
  • core/themes/stable9/css/settings_tray/settings_tray.toolbar.css:3: "ings Tray module is enabl"
  • core/themes/stable9/templates/admin/system-modules-details.html.twig:11: "ox for enabling the module"
  • core/themes/stable9/tests/Kernel/Stable9TemplateOverrideTest.php:68: "al, already enabled module"
  • core/USAGE.txt:26: "s (such as enabling module"
ressa’s picture

ressa
he/him
commented
Title: Use Installed and Uninstalled on Available updates page and in code comments » Use Installed and Uninstalled on Available updates page
Issue summary: View changes
Status: Needs work » Needs review

Perhaps we can spin off updating comments into a separate issue, since it's quite the task? I created #3612984: Use install and uninstall in code comments, not enable/disable.

smustgrave’s picture

smustgrave commented

Will leave for others thing it makes sense here since this current MR is just two line changes

ressa’s picture

ressa
he/him
commented

As I see it, the updates are of different nature: The MR in this issue updates the user facing GUI, which will be often seen by very new Drupal users just getting started, so it's important to not muddy the waters by mixing install/enable, whereas Drupal core comments are by nature only read by Drupal core contributors.

Also, it's unlikely that someone will go through and update all the code comments in the near future, so it could become a long time blocker, for the easy fix here.

dcam’s picture

dcam commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before.png16.18 KB
new after.png12.36 KB

It's fine the way it is. Something else to consider is that this changes translated strings. If there were a smaller number of comments to be changed, then it might be OK to do it all at once. But per #6 there are not. So if there are any issues surrounding the UI change, then the potential exists for this to get stuck in rebase hell due to the volume of things being changed. We can go ahead and keep this separate and leave the rest as a Novice task. I created a follow-up issue for it at #3613650: Replace language about enabling/disabling modules and themes in comments.

Screenshots are generally required for UI changes, so I added them.

This looks good to me.

ressa’s picture

ressa
he/him
commented

Thanks for reviewing, and evaluating if code comments should also be handled here @dcam.

I did already create the #3612984: Use install and uninstall in code comments, not enable/disable follow-up issue (see comment #7), which looks similar to the one you created. (Update: I closed it as a duplicate)

ressa’s picture

ressa
he/him
commented
Issue summary: View changes
StatusFileSize
new 1-enabled.png59.22 KB
new 2-installed.png55.17 KB

Updating the before and after images, since the first examples also had some color changes :)

ressa’s picture

ressa
he/him
commented
Issue summary: View changes
StatusFileSize
new 1-enabled-w-bg.png59.29 KB
new 2-installed-w-bg.png60.95 KB

Fix missing backgrounds for images, I set them to green by switching class color-error with color-success.

ressa’s picture

ressa
he/him
commented

PS. There is also #3610824: Change (disabled) to (uninstalled) on Modules and Themes pages :)

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 997e388673e to main and f871b011177 to 11.x. Thanks!

Not eligible for further backport as a translatable string change.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed f871b011 on 11.x 
    task: #3611590 Use Installed and Uninstalled on Available updates page...

  • longwave committed 997e3886 on main 
    task: #3611590 Use Installed and Uninstalled on Available updates page...
ressa’s picture

ressa
he/him
commented

Thank you @longwave!