It was decided to use "install" instead of "enable" for modules and themes in #3162049: [meta] Better wording of the module life-cycle admin pages. See also:
But modules in the list of modules that are not installed on the "Extend" page (/admin/modules) use the suffix "disabled", in parentheses.
"Uninstalled themes" is used on the "Appearance" page (/admin/appearance) and "uninstalled" in #3611590: Use Installed and Uninstalled on Available updates page, so we should probably use that to stay consistent, rather than for example "not installed".
"disabled" is also used in the text under an uninstalled theme, so also needs an update.
See the list of Modules under /admin/modules ("Extend") use the suffix "(disabled)", even though we install and uninstall modules, not enable/disable as in Drupal 7.
To be consistent, the suffix should probably be "(uninstalled)".
We could do this for both modules and themes.
Update the relevant files and tests for modules and themes to use "(uninstalled)", and not "(disabled)".
Modules that are not installed will use the suffix "(uninstalled)" on the "Extend" page (/admin/modules).
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | disabled-module-list.png | 145.42 KB | ressa |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
ressaComment #4
ressaComment #5
ressaComment #6
berdirNot a native speaker, but uninstall to me only makes sense as an action to apply to to something that is currently installed. You can uninstall an extension that is currently installed, but IMHO something that is currently not installed isn't "uninstalled", it's "not installed".
Comment #7
ressaThanks for weighing in. I am also not a big fan of it ... but "Uninstalled themes" and "Uninstalled modules" is used on the "Appearance" (/admin/appearance) and "Available updates" (/admin/reports/updates) pages.
It could be argued that "Not installed themes" was too clunky, so I suppose it was decided to use "Uninstalled themes"?
... but perhaps we can use "(not installed)" for this case, since it would be a better fit? I have updated the MR.
Comment #8
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. The merge request has merge conflicts and cannot be merged. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #9
ressaI tried and failed to fix the merge error via the GitLab GUI ... Someone with Git skills should feel welcome to resolve it locally :)
Comment #11
quietone commented