Problem/Motivation
On #2888657: [meta] Less confusing and more consistent wording needed in module/theme add/install/update we are trying to make the UI around actions with modules/themes more consistent.
On #2891294: [Meta] Use Install/Uninstall consistently for turning modules/themes on/off (not Enable) we are making sure that when we talk about turning a module/theme on/off, we always use the verbs "Install" and "Uninstall", and on #2577407: Action of uploading module/theme files should consistently be called "Add", not "Install" we are making sure we use the verb "Add" for the action of uploading files for a module/theme.
On this issue, we want to make sure we don't use the verbs Install/Uninstall for other things, such as updating.
Proposed resolution
Make sure we don't use the verbs "Install/Uninstall" in conjunction with modules/themes for anything except turning them on/off. In particular, for updating we should use the verb "Update" not "Install updates".
Remaining tasks
Fix UI text.
User interface changes
More consistent use of the verbs "Install/Uninstall" in conjunction with modules/themes.
API changes
None.
Data model changes
None.
Release notes snippet
Probably not needed for this issue.
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | Screenshot 2023-03-21 at 9.25.04 AM.png | 589.63 KB | smustgrave |
| #12 | 3182405-12.patch | 12.21 KB | ranjith_kumar_k_u |
| #11 | 3182405-nr-bot.txt | 143 bytes | needs-review-queue-bot |
| #9 | 3182405-9.patch | 12.78 KB | smustgrave |
| #9 | interdiff-5-9.txt | 2.2 KB | smustgrave |
Comments
Comment #2
jhodgdonThe patch for #2577407: Action of uploading module/theme files should consistently be called "Add", not "Install" was committed. I spent the time to look for "install" in UI text throughout the core directory of the latest Drupal 9.2.x. I found a bunch of strings that look like they should be addressed in this issue, and added them to the issue summary.
Comment #3
jhodgdonHere's a patch for the items I found that I think need to be done. The last item in the list I had thought we needed to do contained two lines that were actually talking about whether the module was installed (in the sense of turned on), so I didn't patch them. I also looked through all of the strings with "install" in them on localize.drupal.org for Drupal 9.1 to find additional spots that needed attention. Here's a patch.
Removing the list of items to do from the summary, as it doesn't match what I found this time around (there are more items in the patch).
Comment #4
dwwLooks like a great start, thanks! A few initial concerns looking at the patch:
A) Seems out of scope from the rest of these changes.
B) Not sure I agree that "files" is better than "code" here. In the UI and Drupal generally, we tend to use "files" to refer to the uploaded files (e.g. sites/default/files) dir.
C) Does 9.2.x even look at sites/*/modules anymore?
A) Do we really want to spell out "core, your install profile, modules, and/or themes"? Is "install profile" confusing in this context? ;)
B) "above-linked handbook" seems a little awkward. How about:
"... (as described in the handbook page linked above)."?
Ahh, so much better. Thanks! 👍
Meanwhile I grepped the code for 'install' and lo, it's nearly 10K lines. ;) So, yeah, I'm not going to try to go through that to see if we missed anything. I'd be in favor of wrapping this up and getting it in, moving through the rest of the current plan, and if/when we find any other spots we missed, to deal with them in separate follow-ups. Let's not let perfect be the enemy of good.
Thanks!
-Derek
Comment #5
jhodgdonThanks for the review! I actually *did* go through both the *entire* grep -i -R for "install" as well as all of the localize.drupal.org strings. I am sure I missed a few though, since ... well going through everything took a while and my eyes definitely glazed over.
Regarding point 1, I removed that hunk. You are right it is out of scope. But yes, sites/*/modules is (as far as I know) still supported. It was at least in 8.x, not sure about 9.x actually. Anyway, that hunk is not in the patch any more. :)
Regarding point 2, I updated the wording (see interdiff). As a note, we really don't want to refer to the online documentation as the "handbook" at all, but changing that would be out of scope for this issue, so I left it in (and the link referred to as being "above" already says "handbook", so I don't want to change that either).
Comment #9
smustgrave commentedTook a look at #5 and all makes sense to me
Rerolled for 9.5.x
Comment #11
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #12
ranjith_kumar_k_u commentedRe-rolled #9
Comment #13
ranjith_kumar_k_u commentedComment #14
smustgrave commentedJust FYI to help get the message out there.
Starting March 2023, simple rerolls, rebases, or merges will no longer receive issue credit. Only rerolls that address a merge conflict will be credited, and the merge conflict that was resolved must be documented in the text of an issue comment.
To receive credit for contributing to this issue, assist with other outstanding tasks or unaddressed feedback.
See the issue credit guidelines for more information.
So would need to post how the patch no longer applies to 10.1
Comment #15
smustgrave commentedDid a search on phpstorm for "install modules" and the results
Which seem to refer to actually installing a module. Think this is good (though hard to fully serach)
Comment #16
larowlanUpdating issue credits
Comment #18
larowlanCommitted to 10.1.x, not backporting because of the string changes