Problem/Motivation

After successful installation of a theme there should be "Enable" option in the next steps. Because it is really confusing for users after a successful installation message why there is again asked to install that newly added theme.

Step-1

step-1

Step-2

step-2

Step-3

step-3

Remaining tasks

Suggestions and reviews needed.

CommentFileSizeAuthor
#32 interdiff-2856038-29-32.txt1.06 KByogeshmpawar
#32 confusing_instructions-2856038-32.patch6.52 KByogeshmpawar
#29 interdiff-2856038-27-29.txt3.69 KByogeshmpawar
#29 confusing_instructions-2856038-29.patch6.83 KByogeshmpawar
#27 confusing_instructions-2856038-27.patch3.4 KByogeshmpawar
#24 interdiff.txt761 bytesgaurav.kapoor
#24 drupal-2856038-24.patch1.43 KBgaurav.kapoor
#21 drupal-2856038-21.patch2.35 KBgaurav.kapoor
#19 confusing_instructions_2856038_19.patch3.6 KBdbjpanda
#14 confusing_instructions_2856038_14.patch2.6 KBdbjpanda
#14 confusing_instructions_2856038_14.patch2.6 KBdbjpanda
#10 confusing_theme_install_2856038_#10.patch2.6 KBdbjpanda
#2 Confusing_Installation_fix_2856038_#2.patch2.6 KBdbjpanda
step3.PNG26.43 KBdbjpanda
Solution_D8.PNG20.15 KBdbjpanda
install_d8_theme.PNG29.52 KBdbjpanda

Comments

dbjpanda created an issue. See original summary.

dbjpanda’s picture

dbjpanda commented
StatusFileSize
new Confusing_Installation_fix_2856038_#2.patch2.6 KB

Here is the patch for above issue. If the instruction is really confusing then this patch should be committed.

dbjpanda’s picture

dbjpanda commented
Issue summary: View changes
cilefen’s picture

cilefen commented
Version: 8.2.x-dev » 8.4.x-dev
Priority: Major » Normal
Related issues: +#1862094: After installing a theme, display a link to "install another theme", +#2577407: Action of uploading module/theme files should consistently be called "Add", not "Install", +#2839586: Make the wording on the "Install new modules" page more clear
cilefen’s picture

cilefen commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: Confusing_Installation_fix_2856038_#2.patch, failed testing.

himanshu-dixit’s picture

himanshu-dixit commented
Status: Needs work » Needs review
cilefen’s picture

cilefen commented
Status: Needs review » Needs work

See https://www.drupal.org/node/707484

cilefen’s picture

cilefen commented

Also note that I changed the branch.

dbjpanda’s picture

dbjpanda commented
StatusFileSize
new confusing_theme_install_2856038_#10.patch2.6 KB

Rerolled patch for 8.4.x

dbjpanda’s picture

dbjpanda commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: confusing_theme_install_2856038_#10.patch, failed testing.

dbjpanda’s picture

dbjpanda commented

@cilefen why i am getting patch validation error?

dbjpanda’s picture

dbjpanda commented
StatusFileSize
new confusing_instructions_2856038_14.patch2.6 KB
new confusing_instructions_2856038_14.patch2.6 KB
dbjpanda’s picture

dbjpanda commented
Status: Needs work » Needs review

The last submitted patch, 14: confusing_instructions_2856038_14.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 14: confusing_instructions_2856038_14.patch, failed testing.

cilefen’s picture

cilefen commented

The #10 patch seems ok - it was probably a random problem.

The test fails in the #14 patch mean you have to update the tests.

dbjpanda’s picture

dbjpanda commented
Status: Needs work » Needs review
StatusFileSize
new confusing_instructions_2856038_19.patch3.6 KB

Status: Needs review » Needs work

The last submitted patch, 19: confusing_instructions_2856038_19.patch, failed testing.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs work » Needs review
StatusFileSize
new drupal-2856038-21.patch2.35 KB
cilefen’s picture

cilefen commented

Post interdiffs if it isn't a reroll, please!

Status: Needs review » Needs work

The last submitted patch, 21: drupal-2856038-21.patch, failed testing.

gaurav.kapoor’s picture

gaurav.kapoor commented
StatusFileSize
new drupal-2856038-24.patch1.43 KB
new interdiff.txt761 bytes
gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 24: drupal-2856038-24.patch, failed testing.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: dbjpanda » Unassigned
Status: Needs work » Needs review
StatusFileSize
new confusing_instructions-2856038-27.patch3.4 KB

A complete re-roll of patch #10 & also added few changes against test failures.

Status: Needs review » Needs work

The last submitted patch, 27: confusing_instructions-2856038-27.patch, failed testing.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
StatusFileSize
new confusing_instructions-2856038-29.patch6.83 KB
new interdiff-2856038-27-29.txt3.69 KB

Updated patch against test failures & also added interdiff.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 29: confusing_instructions-2856038-29.patch, failed testing.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs work » Needs review
StatusFileSize
new confusing_instructions-2856038-32.patch6.52 KB
new interdiff-2856038-29-32.txt1.06 KB

applied some changes for test failures & also added a interdiff.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented

Any Update on this issue ?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Needs work

The premise of this make sense, thanks for keeping up with it @Yogesh Pawar!

It may be worth double checking some of the other language in comments, some may need to stay but do a search like this to help spot some more spots install.*theme with regular expressions turned on in your editor.

We still refer to it as uninstall/install theme in the API level so this will maybe confuse people more... I'm not sure yet.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Parent issue: » #2888657: [meta] Less confusing and more consistent wording needed in module/theme add/install/update

Adding meta issue as parent of this one.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

FYI -- on the parent issue #2888657: [meta] Less confusing and more consistent wording needed in module/theme add/install/update the Usability team is discussing the UI text for this and about 10 other issues. Until decisions are made, making another patch here would probably be premature.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Closed (duplicate)
Related issues: +#2891294: [Meta] Use Install/Uninstall consistently for turning modules/themes on/off (not Enable)

This is now being handled on #2891294: [Meta] Use Install/Uninstall consistently for turning modules/themes on/off (not Enable), so closing this as a duplicate. Will ask for people here to be credited there.