Problem/Motivation

Module install and uninstall is referred to using enable and disable in the Update module.

Steps to reproduce

Proposed resolution

Fix occurrences in comments.

Remaining tasks

MR
Review

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 3414172-nr-bot.txt90 bytesneeds-review-queue-bot

Issue fork drupal-3414172

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone opened merge request !6131

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Active » Needs review

Fixed the last ones and this is ready for review now.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Reviewed & tested by the community

I'm 99% positive the javascript error is random but I can't rerun as @quietone is a committer.

Reviewing the text changes though and everything still reads fine.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented

The failed test was Drupal\Tests\standard\FunctionalJavascript\StandardPerformanceTest::testLoginBlock which should be fixed by #3420401: StandardPerformanceTest fails randomly on MySQL and consistently on Postgres.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Hm I re-ran PHPUnit Functional Javascript 1/2 which was failing but it still fails.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented

I rebased and tests are passing now

needs-review-queue-bot’s picture

needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commented
Status: Reviewed & tested by the community » Needs work
FileSize
3414172-nr-bot.txt90 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Reviewed & tested by the community

Am seeing all green now.

  • catch committed 4bc99437 on 10.3.x 
    Issue #3414172 by quietone: In update module convert comments to use...

  • catch committed 803fa695 on 11.x 
    Issue #3414172 by quietone: In update module convert comments to use...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.