Baidu Share module provides a Baidu Share buttons to nodes and as a separate block. Baidu Share is a popular button embed code for China and provides embed buttons for QQ, Weibo, RenRen and other China social networks.

Project Page: https://drupal.org/sandbox/jackniu/2090675

Version: Drupal 7.x-1.0
Git: git clone --branch master https://git.drupal.org/sandbox/jackniu/2090675.git baidu_share

Files: 
CommentFileSizeAuthor
baidu_share.png9.99 KBjackniu

Comments

dansboy’s picture

Status: Needs review » Needs work

You need add a 7.x-1.x branch and delect the master branch

dansboy’s picture

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

Review of the 7.x-1.x branch:

  • Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
    ./README.txt:       ASCII text, with CRLF line terminators
    README.txt
    
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    FILE: /var/www/drupal-7-pareview/pareview_temp/README.txt
    --------------------------------------------------------------------------------
    FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
    --------------------------------------------------------------------------------
     7 | ERROR | Files must end in a single new line character
    --------------------------------------------------------------------------------
    
    FILE: /var/www/drupal-7-pareview/pareview_temp/baidu_share.info
    --------------------------------------------------------------------------------
    FOUND 2 ERROR(S) AFFECTING 1 LINE(S)
    --------------------------------------------------------------------------------
     1 | ERROR | "description" property is missing in the info file
     1 | ERROR | "core" property is missing in the info file
    --------------------------------------------------------------------------------
    
karl qin’s picture

jackniu’s picture

Thanks for dansboy's and qinshuguo's review, I have delete the master branch and add description and core to the info file.

PA robot’s picture

Issue summary: View changes
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

jackniu’s picture

Status: Closed (won't fix) » Needs review
PA robot’s picture

Issue summary: View changes
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxjackniu2090675git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

kattekrab’s picture

@jackniu - thank you for contributing this module. I imagine it will be very useful for people building Drupal sites in China!

谢谢

Could please help the review team by also reviewing some other projects, and listing your reviews in the issue summary? The project application review bonus scheme helps everyone get more reviews, and learn more about contributing to Drupal.

I look forward to seeing your project approved!

Here's the results from the automated review:

Review of the 7.x-1.x branch (commit 219d62b):

1. Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting

./baidu_share.module: PHP script, ASCII text, with CRLF line terminators
./README.txt: ASCII text, with CRLF line terminators
baidu_share.module
README.txt

2. Remove all old CVS $Id tags, they are not needed anymore.

baidu_share.module:2:// $Id$

3. Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See http://pareview.sh/pareview/httpsgitdrupalorgsandboxjackniu2090675git for details
And review the Coding Standards here: https://www.drupal.org/node/318

4. DrupalPractice has found some issues with your code, but could be false positives.

FILE: /var/www/drupal-7-pareview/pareview_temp/baidu_share.module
-------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------
136 | WARNING | Unused variable $syntax.
140 | WARNING | There must be no blank line following an inline comment
172 | WARNING | Unused variable $baidu_share_btn.
-------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/baidu_share.admin.inc
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
14 | WARNING | Unused variable $script.
----------------------------------------------------------------------

5. No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.