[D7] Baidu Share

You need add a 7.x-1.x branch and delect the master branch

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

Review of the 7.x-1.x branch:

• Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
  

  ./README.txt:       ASCII text, with CRLF line terminators
  README.txt
  

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: /var/www/drupal-7-pareview/pareview_temp/README.txt
  --------------------------------------------------------------------------------
  FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   7 | ERROR | Files must end in a single new line character
  --------------------------------------------------------------------------------
  

  FILE: /var/www/drupal-7-pareview/pareview_temp/baidu_share.info
  --------------------------------------------------------------------------------
  FOUND 2 ERROR(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   1 | ERROR | "description" property is missing in the info file
   1 | ERROR | "core" property is missing in the info file
  --------------------------------------------------------------------------------
  

git clone http://git.drupal.org/sandbox/jackniu/2090675.git baidu_share

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxjackniu2090675git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

@jackniu - thank you for contributing this module. I imagine it will be very useful for people building Drupal sites in China!

谢谢

Could please help the review team by also reviewing some other projects, and listing your reviews in the issue summary? The project application review bonus scheme helps everyone get more reviews, and learn more about contributing to Drupal.

I look forward to seeing your project approved!

Here's the results from the automated review:

Review of the 7.x-1.x branch (commit 219d62b):

1. Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting

./baidu_share.module: PHP script, ASCII text, with CRLF line terminators
./README.txt: ASCII text, with CRLF line terminators
baidu_share.module
README.txt

2. Remove all old CVS $Id tags, they are not needed anymore.

baidu_share.module:2:// $Id$

3. Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See http://pareview.sh/pareview/httpsgitdrupalorgsandboxjackniu2090675git for details
And review the Coding Standards here: https://www.drupal.org/node/318

4. DrupalPractice has found some issues with your code, but could be false positives.

FILE: /var/www/drupal-7-pareview/pareview_temp/baidu_share.module
-------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------
136 | WARNING | Unused variable $syntax.
140 | WARNING | There must be no blank line following an inline comment
172 | WARNING | Unused variable $baidu_share_btn.
-------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/baidu_share.admin.inc
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
14 | WARNING | Unused variable $script.
----------------------------------------------------------------------

5. No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

I really appreciate this Chinese local service integration module.

You'd better implement hook_help() in your module, in which simply to output the content of README.txt is ok.

/**
 * Implements hook_help().
 */
function baidu_share_help($path, $arg) {
  switch ($path) {
    case "admin/help#baidu_share":
      return check_markup(file_get_contents(dirname(__FILE__) . "/README.txt"));
  }
}

Sample code for implementing hook_help()

Automated Review

[Best practice issues identified by pareview.sh / drupalcs / coder. Please don't copy/paste all of the results unless they are short. If there are a lot, then post a link to the automated review and mention that problems should be addressed.]

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[No: Does not follow] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Please do not mark ticket to RTBC yourself. Please see the workflow https://www.drupal.org/node/532400

@jackniu, good job. I have tested it, and working well on my local.

Hi @jackniu, as result of paraview.sh(https://pareview.sh/node/494), you should remove LICENSE.txt file from your project, which will be added by drupal.org automatically.

@lugir: the existence of the license file alone is surely not an application blocker. Anything else that you found or should this stay RTBC?

Tested, and it works fine :D

Removing review bonus tag, you have not listed any reviews you did in the issue summary? Make sure to read https://www.drupal.org/node/1975228 again. Thanks!

Review of the 7.x-1.x branch (commit 7ecb62c):

No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Please update readme as https://www.drupal.org/node/2181737.

Otherwise all looks good for me.

Thanks for your contribution, jackniu!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.